Don't show Move and Delete options for users without permissions
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	apaskulin
	Oct 23 2020, 4:48 PM

Description

On talk pages, don't show the Move and Delete buttons if users don't have permissions to perform those actions.

Details

	Subject	Repo	Branch	Lines /-
	PageToolsComponent: Don`t show Move and Delete options for users without permissions	mediawiki/skins/WikimediaApiPortal	master	4 -0

Customize query in gerrit

Related Objects

Mentioned In: T266161: Display page action buttons on talk pages

Event Timeline

apaskulin created this task.Oct 23 2020, 4:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2020, 4:48 PM

apaskulin triaged this task as Low priority.Oct 23 2020, 4:48 PM

apaskulin mentioned this in T266161: Display page action buttons on talk pages.

apaskulin moved this task from Backlog to Ready for S&F on the WikimediaApiPortal board.Oct 23 2020, 5:03 PM

apaskulin added a project: Platform Team Workboards (S&F Workboard).Oct 26 2020, 3:25 PM

Helga_sf moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Oct 26 2020, 4:15 PM

Helga_sf set the point value for this task to 8.

Per Cindy's comment on an earlier patch, this can be done as a check for $permissionManager->userHasRight( $user, $requestedAction ) in PageToolsComponent.php.

Helga_sf changed the point value for this task from 8 to 3.Nov 17 2020, 1:14 PM

Vlad.shapik claimed this task.Nov 30 2020, 2:37 PM

Vlad.shapik moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.

Change 645062 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/WikimediaApiPortal@master] PageToolsComponent: Don`t show Move and Delete options for users without permissions

https://gerrit.wikimedia.org/r/645062

gerritbot added a project: Patch-For-Review.Dec 3 2020, 12:14 PM

Vlad.shapik moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Dec 3 2020, 12:50 PM

Change 645062 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] PageToolsComponent: Don`t show Move and Delete options for users without permissions

https://gerrit.wikimedia.org/r/645062

Vlad.shapik moved this task from In Progress/In Review to PM Sign Off on the Platform Team Workboards (S&F Workboard) board.Dec 3 2020, 6:54 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 3 2020, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 3 2020, 7:10 PM

We won't be able to verify this until after the site is live, so I'm resolving this now based on local testing. Thanks, Vlad!

Don't show Move and Delete options for users without permissionsClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Don't show Move and Delete options for users without permissions
Closed, ResolvedPublic3 Estimated Story Points
Actions