Use BlockUser service in SpecialInvestigateBlock
Closed, ResolvedPublic2 Estimated Story PointsOct 20 2020
Actions

Assigned To

Authored By

	• Tchanders
	Oct 1 2020, 12:24 PM

Description

Following T189073: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere, we should update SpecialInvestigateBlock to use the new BlockUser service, instead of the deprecated method SpecialBlock::processForm.

As well as improving the architecture, this will fix an error I encountered locally (unlikely in real life), when a user tries to block themselves - filed as T257918:

ErrorException from line 789 of /var/www/html/mediawiki/core/includes/specials/SpecialBlock.php PHP Notice: Undefined index: PreviousTarget

This is due to SpecialBlock::processForm not expecting to be called from external forms that don't necessarily have the same fields as SpecialBlock.

Details

Due Date: Oct 20 2020, 4:00 AM

	Subject	Repo	Branch	Lines /-
	SpecialInvestigateBlock: Remove dependency on SpecialBlock	mediawiki/extensions/CheckUser	master	34 -19

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Oct 20 2020	• Tchanders	T264303 Use BlockUser service in SpecialInvestigateBlock
Resolved	Sep 22 2020	Urbanecm	T189073 Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere
Resolved		Urbanecm	T248640 Make blockUsers.php script capable of unblocking
Resolved		Urbanecm	T251861 Move SpecialBlock::checkUnblockSelf to a block permissions service
Resolved		Urbanecm	T263326 Deprecate SpecialBlock::checkUnblockSelf
Resolved		Urbanecm	T263327 Deprecate SpecialBlock::canBlockEmail and replace its usages
Resolved		Urbanecm	T263334 Do not call SpecialBlock::canBlockEmail from CheckUser
Resolved		• Tchanders	T264307 Deprecate SpecialBlock::processForm

Event Timeline

• Tchanders created this task.Oct 1 2020, 12:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2020, 12:24 PM

• Tchanders added a parent task: T264307: Deprecate SpecialBlock::processForm.Oct 1 2020, 12:47 PM

dbarratt added a parent task: T189073: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere.Oct 1 2020, 4:57 PM

dbarratt removed a parent task: T189073: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere.

dbarratt removed a parent task: T264307: Deprecate SpecialBlock::processForm.

dbarratt added a subtask: T189073: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere.

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Oct 5 2020, 6:19 PM

Niharika triaged this task as Medium priority.Oct 6 2020, 4:14 PM

Niharika set the point value for this task to 2.

Niharika moved this task from Triage/To be Estimated to The Letter Song on the Anti-Harassment board.

Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

• Tchanders mentioned this in T264307: Deprecate SpecialBlock::processForm.Oct 7 2020, 12:30 PM

• Tchanders claimed this task.Oct 7 2020, 5:48 PM

• Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 632906 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] SpecialInvestigateBlock: Remove dependency on SpecialBlock

https://gerrit.wikimedia.org/r/632906

gerritbot added a project: Patch-For-Review.Oct 8 2020, 12:30 PM

• Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Oct 8 2020, 12:30 PM

• Tchanders updated the task description. (Show Details)Oct 8 2020, 3:09 PM

• Tchanders mentioned this in T257918: Special:InvestigateBlock: "Undefined index: PreviousTarget" when trying to block self.Oct 8 2020, 3:59 PM

ARamirez_WMF set Due Date to Oct 20 2020, 4:00 AM.Oct 8 2020, 10:11 PM

ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

Change 632906 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] SpecialInvestigateBlock: Remove dependency on SpecialBlock

https://gerrit.wikimedia.org/r/632906

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2020, 8:11 PM

• Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Oct 15 2020, 7:42 AM

I used Special:InvestigateBlock to block various users, IPs and ranges, including reblocking users.

I checked that the blocks were created with the correct parameters by looking in the database.

I checked that there were no errors in the logs.

I also tested with $wgBlockAllowsUTEdit = false and with the blockemail right removed from the admin. The checkbox to block user from own User_talk and email (resp.) are removed. Otherwise, form submits fine and block is made.

Test Environment: Local vagrant MediaWiki 1.36.0-alpha (8e68310).

ARamirez_WMF moved this task from Done: Q2 (2020-2021) ✅ to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Oct 19 2020, 6:11 PM

• Tchanders moved this task from In Progress 💪 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.Oct 19 2020, 6:12 PM

Urbanecm closed subtask T189073: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere as Resolved.Oct 24 2020, 8:00 PM

• Tchanders closed this task as Resolved.Dec 3 2020, 1:15 PM