enable mediawiki.page.ready in Minerva
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 6 2020, 10:10 PM

Description

Currently it is not possible to load mediawiki.page.ready in Minerva without pulling in incompatible code relating to table sorting and collapsible content.

This means it's not possible to use the new checkbox hack in Minerva.

T250851 should make mediawiki.page.ready configurable

Acceptance criteria

Minerva should load mediawiki.page.ready on all pages
Minerva uses the new hook added in T250851 to disable table sorting and collapsible content for now.

Sign off steps

Update T111565

Details

	Subject	Repo	Branch	Lines /-
	Load mediawiki.page.ready on Minerva	mediawiki/skins/MinervaNeue	REL1_35	40 -4
	Load mediawiki.page.ready on Minerva	mediawiki/skins/MinervaNeue	master	40 -4

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Open	Feature	None	T232895 [OTRS Feature Request]: Do not ignore navbox templates
Open		None	T124168 Show Navbox templates in mobile skins
Duplicate		None	T257127 "Global account info" looks sortable on mobile but isn't
Resolved		None	T233340 Add sortability to sortable tables for readers of the mobile web site
Invalid		None	T199931 Auto-collapse the Wikidata Infobox when browsing Commons on Mobile
Resolved	BUG REPORT	Jdlrobson	T307078 Navbox bugs in Minerva
Resolved		Jdlrobson	T111565 Enable collapsible templates (including infoboxes) on mobile
Resolved		Peter.ovchyn	T257265 enable mediawiki.page.ready in Minerva

Event Timeline

Jdlrobson created this task.Jul 6 2020, 10:10 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJul 6 2020, 10:10 PM

Jdlrobson added a subtask: T111565: Enable collapsible templates (including infoboxes) on mobile.Jul 6 2020, 10:10 PM

Jdlrobson added a subtask: T233340: Add sortability to sortable tables for readers of the mobile web site.

Jdlrobson mentioned this in T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.Jul 6 2020, 10:12 PM

ovasileva triaged this task as Medium priority.Jul 7 2020, 3:28 PM

ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson removed a project: MediaWiki-Core-Skin-Architecture.Jul 7 2020, 7:31 PM

Ammarpad changed the task status from Open to Stalled.Jul 10 2020, 11:53 AM

Ammarpad claimed this task.

Change 612569 had a related patch set uploaded (by Jdlrobson; owner: Peter.ovchyn):
[mediawiki/skins/MinervaNeue@master] Load mediawiki.page.ready on mobile

https://gerrit.wikimedia.org/r/612569

gerritbot added a project: Patch-For-Review.Jul 15 2020, 5:47 PM

Ammarpad changed the task status from Stalled to Open.Jul 18 2020, 11:32 AM

Ammarpad reassigned this task from Ammarpad to Peter.ovchyn.

Ammarpad subscribed.

Assigning to @Peter.ovchyn as he's already working on this.

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.Jul 23 2020, 8:06 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 28 2020, 8:58 PM

Jdlrobson mentioned this in T259198: Technical: Use checkboxHack in Minerva.Jul 29 2020, 9:55 PM

Jdlrobson moved this task from Upcoming to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 29 2020, 10:10 PM

Jdlrobson mentioned this in T259200: Technical: Two instances of smart logout code are shipped to Minerva.

Change 612569 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Load mediawiki.page.ready on Minerva

https://gerrit.wikimedia.org/r/612569

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2020, 11:10 PM

Jdlrobson closed this task as Resolved.Jul 31 2020, 4:00 PM

Jdlrobson updated the task description. (Show Details)

Ammarpad mentioned this in T260642: Regression: Collapsible forms stopped working on Mobile special page.Aug 18 2020, 6:43 AM

Change 637048 had a related patch set uploaded (by Jdlrobson; owner: Peter.ovchyn):
[mediawiki/skins/MinervaNeue@REL1_35] Load mediawiki.page.ready on Minerva

https://gerrit.wikimedia.org/r/637048

gerritbot added a project: Patch-For-Review.Oct 28 2020, 11:43 PM

Change 637048 abandoned by Jdlrobson:
[mediawiki/skins/MinervaNeue@REL1_35] Load mediawiki.page.ready on Minerva

Reason:

https://gerrit.wikimedia.org/r/637048

Samwalton9-WMF closed subtask T233340: Add sortability to sortable tables for readers of the mobile web site as Resolved.Jul 1 2022, 12:33 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2022, 1:31 PM

Izno removed a subtask: T233340: Add sortability to sortable tables for readers of the mobile web site.Nov 22 2022, 10:53 PM

Izno added a parent task: T233340: Add sortability to sortable tables for readers of the mobile web site.

Izno removed a subtask: T111565: Enable collapsible templates (including infoboxes) on mobile.

Izno added a parent task: T111565: Enable collapsible templates (including infoboxes) on mobile.