Page MenuHomePhabricator
Create Task
Maniphest T253458

Build the Pagelist Input Widget
Open, Needs TriagePublic
Actions

Description

  • Setup selenium tests
  • Write code for API endpoint(Probably will not be required)
  • Write related messages(Is linked to the point above)
  • add a $wg something feature flag (Or use data attribute)
  • conditionally add a module to the edit page
  • Create a custom PagelistInputWidget containing a textbox and a preview button
  • Create a button-based representation of a pagelist to show as preview
  • Bind an event to select each button and open a popup window
  • Popup window should contain the following:
    • some way to look at the thumbnail of the scan for which page number is being set.
    • A button-based way preview of the pagelist
    • Information about the page/scan itself.
  • Find the "best" way to create/edit a pagelist using the widget
  • Implement that particular way
  • Create a wikitext mode to allow experienced users to continue with a improved version of their current workflow
  • Implement the same
  • Create a experimental new (visual) mode that will allow users to create the pagelist without having to memorize the syntax of the pagelist
  • Implement the same
  • Write QUnit tests
  • Write Selenium tests
  • Roll out the widget
  • Document and fix any bugs/issues that may arise

Details

SubjectRepoBranchLines /-
Show errors meaningful errors if the widget has been configured wronglymediawiki/extensions/ProofreadPagemaster 38 -3
Disabled updateButton for when no changes occur and added tooltipmediawiki/extensions/ProofreadPagemaster 10 -7
[WIP] Add QUnit tests for parts of PagelistInputWidgetmediawiki/extensions/ProofreadPagemaster 332 -19
Added support for rows parameters in the PagelistInputWidgetmediawiki/extensions/ProofreadPagemaster 3 -1
Fixed non persistence of the visual-mode preferencemediawiki/extensions/ProofreadPagemaster 4 -2
Fixed misplaced warning in visual modemediawiki/extensions/ProofreadPagemaster 1 -4
Added visual mode to Wikisource Pagelist Widgetmediawiki/extensions/ProofreadPagemaster 1 K -46
Fix loading animation not showing when dialog opensmediawiki/extensions/ProofreadPagemaster 1 -0
Delete unused FormPanel componentmediawiki/extensions/ProofreadPagemaster 0 -49
[WIP] Rough demo of change point methodologymediawiki/extensions/ProofreadPagemaster 281 -37
Fixed unsynced top-panel in PagelistWidgetmediawiki/extensions/ProofreadPagemaster 10 -3
Build the wikitext mode for the PagelistInputWidgetmediawiki/extensions/ProofreadPagemaster 529 -83
Fixed alignment of buttons in pagelist previewmediawiki/extensions/ProofreadPagemaster 13 -0
Add a dialog to PagelistInputWidgetmediawiki/extensions/ProofreadPagemaster 536 -20
Creating a pagelist input widgetmediawiki/extensions/ProofreadPagemaster 473 -7
Selenium: Added preliminary tests to check if Index page loads properlymediawiki/extensions/ProofreadPagemaster 3 K -2
Wrap pagelists in a <span> tag to aid identificationmediawiki/extensions/ProofreadPagemaster 12 -9
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Soda created this task.May 23 2020, 7:14 PM
Aklapper added a project: ProofreadPage.May 23 2020, 7:34 PM

@Soda: Assuming this task is about the ProofreadPage code project, hence adding that project tag so other people can also find this task when searching via projects.

Soda added a comment.May 23 2020, 7:38 PM

@Aklapper Sure :)

Soda updated the task description. (Show Details)May 23 2020, 7:40 PM
Soda renamed this task from Create a basic skeleton, create API endpoint to parse pagelist tags to Create a basic skeleton and get everything ready to build the actual widget.May 29 2020, 6:39 AM
Soda updated the task description. (Show Details)
gerritbot added a comment.May 29 2020, 6:40 AM

Change 599672 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Setting up selenium tests

https://gerrit.wikimedia.org/r/599672

gerritbot added a project: Patch-For-Review.May 29 2020, 6:41 AM
gerritbot added a comment.Jun 2 2020, 4:39 PM

Change 601793 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] [WIP]: Creating a pagelist input widget

https://gerrit.wikimedia.org/r/601793

gerritbot added a comment.Jun 2 2020, 4:52 PM

Change 601795 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Wrap pagelists in a <span> tag to aid identification

https://gerrit.wikimedia.org/r/601795

gerritbot added a comment.Jun 6 2020, 7:12 PM

Change 601795 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Wrap pagelists in a <span> tag to aid identification

https://gerrit.wikimedia.org/r/601795

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 6 2020, 8:00 PM
gerritbot added a comment.Jun 15 2020, 7:28 AM

Change 599672 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Selenium: Added preliminary tests to check if Index page loads properly

https://gerrit.wikimedia.org/r/599672

gerritbot added a comment.Jun 18 2020, 7:06 AM

Change 601793 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Creating a pagelist input widget

https://gerrit.wikimedia.org/r/601793

Maintenance_bot removed a project: Patch-For-Review.Jun 18 2020, 7:10 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.38; 2020-06-23); removed MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 18 2020, 8:01 AM
Soda added a comment.Jun 21 2020, 6:04 AM

It looks like the rows attribute for the PagelistInputWidget's textarea isn't being set... Will put in a fix for that.

gerritbot added a comment.Jun 24 2020, 7:19 PM

Change 607601 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] [WIP] Add a dialog to PagelistInputWidget

https://gerrit.wikimedia.org/r/607601

gerritbot added a project: Patch-For-Review.Jun 24 2020, 7:19 PM
Soda renamed this task from Create a basic skeleton and get everything ready to build the actual widget to Build the dialog and general previewing mechanism.Jul 1 2020, 1:38 PM
Soda updated the task description. (Show Details)
gerritbot added a comment.Jul 13 2020, 3:07 AM

Change 607601 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Add a dialog to PagelistInputWidget

https://gerrit.wikimedia.org/r/607601

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2020, 3:10 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.41; 2020-07-14); removed MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jul 13 2020, 4:00 AM
gerritbot added a comment.Jul 21 2020, 4:07 PM

Change 615244 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] [WIP] Rough demo of change point methodology

https://gerrit.wikimedia.org/r/615244

gerritbot added a project: Patch-For-Review.Jul 21 2020, 4:07 PM
Soda updated the task description. (Show Details)Jul 21 2020, 4:12 PM
Esc3300 mentioned this in T258546: Show page list based on pagination string stored on Commons (files currently not used on WS).Jul 22 2020, 12:45 AM
gerritbot added a comment.Jul 28 2020, 5:57 AM

Change 616650 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Fixed alignment of buttons in pagelist preview

https://gerrit.wikimedia.org/r/616650

gerritbot added a comment.Jul 30 2020, 7:52 PM

Change 617530 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] [WIP] Build the wikitext mode for the PagelistInputWidget

https://gerrit.wikimedia.org/r/617530

gerritbot added a comment.Aug 3 2020, 7:39 AM

Change 616650 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Fixed alignment of buttons in pagelist preview

https://gerrit.wikimedia.org/r/616650

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Aug 3 2020, 8:00 AM
gerritbot added a comment.Aug 11 2020, 4:44 AM

Change 617530 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Build the wikitext mode for the PagelistInputWidget

https://gerrit.wikimedia.org/r/617530

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.5; 2020-08-18); removed MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Aug 11 2020, 5:00 AM
gerritbot added a comment.Aug 11 2020, 2:49 PM

Change 619480 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Fixed unsynced top-panel in PagelistWidget

https://gerrit.wikimedia.org/r/619480

gerritbot added a comment.Aug 11 2020, 5:18 PM

Change 619511 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Disabled updateButton for when no changes occur and added tooltip

https://gerrit.wikimedia.org/r/619511

gerritbot added a comment.Aug 12 2020, 12:21 AM

Change 619480 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Fixed unsynced top-panel in PagelistWidget

https://gerrit.wikimedia.org/r/619480

gerritbot added a comment.Aug 18 2020, 7:41 PM

Change 621053 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] [WIP] Added visual mode to Wikisource Pagelist Widget

https://gerrit.wikimedia.org/r/621053

gerritbot added a comment.Aug 18 2020, 7:42 PM

Change 615244 abandoned by Sohom Datta:
[mediawiki/extensions/ProofreadPage@master] [WIP] Rough demo of change point methodology

Reason:
Supersed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/ /621053

https://gerrit.wikimedia.org/r/615244

Soda renamed this task from Build the dialog and general previewing mechanism to Build the Pagelist Input Widget.Aug 25 2020, 2:37 AM
Soda updated the task description. (Show Details)
gerritbot added a comment.Aug 27 2020, 6:48 PM

Change 622864 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Delete unused FormPanel component

https://gerrit.wikimedia.org/r/622864

gerritbot added a comment.Aug 27 2020, 10:01 PM

Change 622864 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Delete unused FormPanel component

https://gerrit.wikimedia.org/r/622864

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.8; 2020-09-08); removed MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 27 2020, 11:00 PM
gerritbot added a comment.Aug 28 2020, 12:36 PM

Change 622988 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Fix loading animation not showing when dialog opens

https://gerrit.wikimedia.org/r/622988

gerritbot added a comment.Aug 31 2020, 5:17 AM

Change 622988 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Fix loading animation not showing when dialog opens

https://gerrit.wikimedia.org/r/622988

gerritbot added a comment.Aug 31 2020, 5:42 AM

Change 621053 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Added visual mode to Wikisource Pagelist Widget

https://gerrit.wikimedia.org/r/621053

gerritbot added a comment.Sep 3 2020, 12:49 PM

Change 624051 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Fixed non persistence of the visual-mode preference

https://gerrit.wikimedia.org/r/624051

gerritbot added a comment.Sep 3 2020, 1:09 PM

Change 624056 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Fixed misplaced warning in visual mode

https://gerrit.wikimedia.org/r/624056

gerritbot added a comment.Sep 8 2020, 1:09 AM

Change 624056 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Fixed misplaced warning in visual mode

https://gerrit.wikimedia.org/r/624056

gerritbot added a comment.Sep 8 2020, 1:31 AM

Change 624051 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Fixed non persistence of the visual-mode preference

https://gerrit.wikimedia.org/r/624051

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.9; 2020-09-15); removed MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 8 2020, 2:00 AM
gerritbot added a comment.Sep 10 2020, 4:40 AM

Change 626245 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Show errors meaningful errors if the widget has been configured wrongly

https://gerrit.wikimedia.org/r/626245

gerritbot added a comment.Sep 18 2020, 6:26 PM

Change 628425 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Added support for rows parameters in the PagelistInputWidget

https://gerrit.wikimedia.org/r/628425

gerritbot added a comment.Sep 22 2020, 9:23 AM

Change 629071 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] [WIP] Add QUnit tests for parts of PagelistInputWidget

https://gerrit.wikimedia.org/r/629071

Soda mentioned this in T247157: [Proposal] Create OOUI widget for Index page pagelists {Google Summer of Code 2020}.Sep 23 2020, 3:30 PM
gerritbot added a comment.Dec 12 2020, 7:42 PM

Change 628425 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Added support for rows parameters in the PagelistInputWidget

https://gerrit.wikimedia.org/r/628425

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.22; 2020-12-15); removed MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Dec 12 2020, 8:00 PM
gerritbot added a comment.Jun 10 2021, 6:17 PM

Change 629071 abandoned by Sohom Datta:

[mediawiki/extensions/ProofreadPage@master] [WIP] Add QUnit tests for parts of PagelistInputWidget

Reason:

Gonna work on some changes to the architecture and add QUnit tests after that

https://gerrit.wikimedia.org/r/629071

Inductiveload moved this task from Backlog to Pagelist Widget on the ProofreadPage board.Sep 20 2021, 6:35 AM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Aug 16 2022, 10:12 AM
Aklapper removed Soda as the assignee of this task.Sep 26 2022, 10:20 AM

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits