Cannot link to subsections on Special:Preferences
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In desktop refresh the new opt-out link does not link directly to the appropriate subsection in Special:Preferences

A link to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Preferences&wprov=vctw1#mw-prefsection-rendering-skin-skin-prefs or https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-rendering-skin-skin-prefs does not reveal the appropriate section.

Link is generated by

SpecialPage::getTitleFor(
  'Preferences', false,  'mw-prefsection-rendering-skin-skin-prefs'
)->getLinkURL( 'wprov=' . self::OPT_OUT_LINK_TRACKING_CODE ),

Likewise a link to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Preferences#mw-prefsection-personal doesn't work.

As a result the new opt-out link on desktop refresh can only link to the appearance tab.

Footnote: An added question is whether getLocalURL should be generating a more readable URL such as https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences?wprov=vctw1#mw-prefsection-rendering-skin-skin-prefs

Developer notes

T248644#6057102

QA notes

Ensure that clicking the sidebar link will scroll to legacy Vector section in Special:Preferences.

QA Results - Beta

AC	Status	Details
1	✅	T248644#6089870

Details

	Subject	Repo	Branch	Lines /-
	Fix Special:Preferences sub section link	mediawiki/skins/Vector	master	1 -3
	Fix linking to nested sub-sections in preferences	mediawiki/core	master	1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Goal	ovasileva	T242131 [GOAL] Deploy new header to at least one test wiki
Resolved		Jdlrobson	T240856 [EPIC] New header for desktop improvements project
Resolved		ovasileva	T236176 [EPIC] Build opt-in/opt-out mechanism for desktop improvements project
Resolved		Edtadros	T248644 Cannot link to subsections on Special:Preferences

Event Timeline

Jdlrobson created this task.Mar 27 2020, 12:07 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2020, 12:07 AM

• Niedzielski subscribed.Mar 27 2020, 12:22 AM

ovasileva triaged this task as High priority.Mar 27 2020, 10:19 AM

ovasileva subscribed.

ovasileva moved this task from Incoming to Q4 2020 on the Desktop Improvements (Vector 2022) board.Mar 30 2020, 12:18 PM

MBinder_WMF edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q4); removed Web-Team-Backlog (Kanbanana-2019-20-Q3).Mar 31 2020, 10:13 PM

@matmarex Haven't we had similar issue when bringing Special:Preferences to OOUI?

• nray updated the task description. (Show Details)Apr 7 2020, 9:05 PM

ovasileva added a parent task: T240856: [EPIC] New header for desktop improvements project.Apr 10 2020, 1:28 PM

I'm not following how this is related to the header. I'd suggest the parent task to be: T243281: Build opt-out link for logged-in users with new vector on or T236176: [EPIC] Build opt-in/opt-out mechanism for desktop improvements project

• Demian mentioned this in T249918: Desktop Improvements opt-out takes multiple user actions and network roundtrips.Apr 10 2020, 2:51 PM

Jdlrobson removed a parent task: T240856: [EPIC] New header for desktop improvements project.Apr 10 2020, 4:54 PM

This is a deployment blocker for the header. Now marked as subtask of T236176: [EPIC] Build opt-in/opt-out mechanism for desktop improvements project and making the latter a subtask of T240856: [EPIC] New header for desktop improvements project

• Demian removed a subtask: T236176: [EPIC] Build opt-in/opt-out mechanism for desktop improvements project.Apr 13 2020, 10:23 AM

• Demian added a parent task: T236176: [EPIC] Build opt-in/opt-out mechanism for desktop improvements project.

ovasileva assigned this task to Jdrewniak.Apr 13 2020, 5:25 PM

In T248644#6037942, @Volker_E wrote:

@matmarex Haven't we had similar issue when bringing Special:Preferences to OOUI?

Yes, and I fixed it at the time (5fe2e19ac33335458b658388a34f48bde63c1787).

It appears to be working correctly for me, for all sections other than #mw-prefsection-rendering-skin-skin-prefs. For example, https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-watchlist-pageswatchlist jumps to the "Watched pages" section on the "Watchlist" tab.

Apparently we have found something that doesn't work correctly with the nested-sections approach (T246162: Put skin preference in the correct place).

Change 588750 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Fix linking to nested sub-sections in preferences

https://gerrit.wikimedia.org/r/588750

gerritbot added a project: Patch-For-Review.Apr 14 2020, 4:53 PM

Change 588750 merged by jenkins-bot:
[mediawiki/core@master] Fix linking to nested sub-sections in preferences

https://gerrit.wikimedia.org/r/588750

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 14 2020, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 14 2020, 6:10 PM

Link works now: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Preferences#mw-prefsection-rendering-skin-skin-prefs
We just need to update it in Vector.

Jdlrobson updated the task description. (Show Details)Apr 14 2020, 10:07 PM

ovasileva set the point value for this task to 1.Apr 15 2020, 5:24 PM

Change 589071 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] Fix Special:Preferences sub section link

https://gerrit.wikimedia.org/r/589071

gerritbot added a project: Patch-For-Review.Apr 15 2020, 5:27 PM

Jdlrobson moved this task from Upcoming to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 15 2020, 6:23 PM

Jdlrobson reassigned this task from Jdrewniak to Volker_E.Apr 15 2020, 6:33 PM

Jdlrobson moved this task from Needs Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.

Jdlrobson added a subscriber: Jdrewniak.

Change 589161 had a related patch set uploaded (by Jdlrobson; owner: VolkerE):
[mediawiki/skins/Vector@master] Fix Special:Preferences sub section link

https://gerrit.wikimedia.org/r/589161

matmarex unsubscribed.Apr 16 2020, 3:52 PM

Jdlrobson moved this task from Blocked on Others to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 16 2020, 5:49 PM

Volker_E reassigned this task from Volker_E to Edtadros.Apr 16 2020, 6:29 PM

Volker_E moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.

Volker_E updated the task description. (Show Details)

Change 589161 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix Special:Preferences sub section link

https://gerrit.wikimedia.org/r/589161

Edtadros added a project: RW-Feature-DI-Opt-out-Toggle.Apr 21 2020, 9:18 PM

ovasileva moved this task from Needs QA to Needs QA in Prod on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 28 2020, 4:51 PM

ovasileva moved this task from Needs QA in Prod to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.