For various maintenance tasks, like T243980: Find rangeblocks exceeding $wgBlockCIDRLimit to review/lift them. Follows on from T246368: Create maintenance script to block a list of users
Description
Details
Subject | Repo | Branch | Lines /- | |
---|---|---|---|---|
Make blockUsers.php capable of both blocking and unblocking | mediawiki/core | master | 71 -106 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | • Tchanders | T264303 Use BlockUser service in SpecialInvestigateBlock | |||
Resolved | Daimona | T248743 Call BlockUser in AbuseFilterRunner.php | |||
Duplicate | Urbanecm | T264306 Use BlockUser service in GlobalBlocking | |||
Resolved | Urbanecm | T250737 Special:Block should not play the role of a central blocking service/utility | |||
Resolved | Urbanecm | T189073 Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere | |||
Resolved | Urbanecm | T250020 Refactor logic for doing and logging unblock out of SpecialUnblock so it can be easily reused elsewhere | |||
Resolved | Urbanecm | T243980 Find rangeblocks exceeding $wgBlockCIDRLimit to review/lift them | |||
Resolved | Urbanecm | T248640 Make blockUsers.php script capable of unblocking |
Event Timeline
Change 582924 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Add a blockBatch.php script capable of both blocking and unblocking
There's no need for a whole separate script just to add option of unblocking. If the current script does not support unlock, the right thing to do is to add the few lines of code that support unblocking not create a parallel script needlessly.
maintenance/blockUsers.php is is not old or abandoned code. In fact it was created recently by @Reedy
Yeah, this feels a bit odd to me too.
I created the other script in T246368: Create maintenance script to block a list of users less than a month ago. If you're adding another script that does part of the same work, even if you're adding extra/new functionality, you're just adding Technical-Debt
It's not like it's refactoring is needed, just a flag/similar to suggest unblock, then make it call the existing blockUsers else a new unblockUsers or similar
Change 582924 merged by jenkins-bot:
[mediawiki/core@master] Make blockUsers.php capable of both blocking and unblocking