⚓ T248640 Make blockUsers.php script capable of unblocking

	Subject	Repo	Branch	Lines /-
	Make blockUsers.php capable of both blocking and unblocking	mediawiki/core	master	71 -106

Status	Subtype	Assigned	Task
Resolved	Oct 20 2020	• Tchanders	T264303 Use BlockUser service in SpecialInvestigateBlock
Resolved		Daimona	T248743 Call BlockUser in AbuseFilterRunner.php
Duplicate		Urbanecm	T264306 Use BlockUser service in GlobalBlocking
Resolved		Urbanecm	T250737 Special:Block should not play the role of a central blocking service/utility
Resolved	Sep 22 2020	Urbanecm	T189073 Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere
Resolved		Urbanecm	T250020 Refactor logic for doing and logging unblock out of SpecialUnblock so it can be easily reused elsewhere
Resolved		Urbanecm	T243980 Find rangeblocks exceeding $wgBlockCIDRLimit to review/lift them
Resolved		Urbanecm	T248640 Make blockUsers.php script capable of unblocking

Urbanecm created this task.Mar 26 2020, 11:15 PM

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptMar 26 2020, 11:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 582924 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Add a blockBatch.php script capable of both blocking and unblocking

https://gerrit.wikimedia.org/r/582924

gerritbot added a project: Patch-For-Review.Mar 26 2020, 11:15 PM

Urbanecm moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Mar 26 2020, 11:15 PM

Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.

There's already a script that do this maintenance/blockUsers.php

In T248640#6003871, @Ammarpad wrote:

There's already a script that do this maintenance/blockUsers.php

New script is also capable of unblocking, and it doesn't look like that one is

There's no need for a whole separate script just to add option of unblocking. If the current script does not support unlock, the right thing to do is to add the few lines of code that support unblocking not create a parallel script needlessly.

maintenance/blockUsers.php is is not old or abandoned code. In fact it was created recently by @Reedy

Ammarpad added a subscriber: Reedy.Mar 26 2020, 11:50 PM

Yeah, this feels a bit odd to me too.

I created the other script in T246368: Create maintenance script to block a list of users less than a month ago. If you're adding another script that does part of the same work, even if you're adding extra/new functionality, you're just adding Technical-Debt

It's not like it's refactoring is needed, just a flag/similar to suggest unblock, then make it call the existing blockUsers else a new unblockUsers or similar

Ehh, seems I haven't pull MediaWiki and missed this script. I'll update my patch.

In T248640#6004007, @Reedy wrote:

Yeah, this feels a bit odd to me too.

I created the other script in T246368: Create maintenance script to block a list of users less than a month ago. If you're adding another script that does part of the same work, even if you're adding extra/new functionality, you're just adding Technical-Debt

It's not like it's refactoring is needed, just a flag/similar to suggest unblock, then make it call the existing blockUsers else a new unblockUsers or similar

I've merged my script with yours. See linked patch :).

Reedy renamed this task from Add a blockBatch.php script capable of both blocking and unblocking to Make blockUsers.php script capable of unblocking.Mar 28 2020, 2:33 PM

Reedy updated the task description. (Show Details)

Reedy mentioned this in T246397: Refactor blocking code so much boilerplate isn't needed.Mar 28 2020, 2:38 PM

RhinosF1 subscribed.Mar 28 2020, 3:03 PM

daniel triaged this task as Medium priority.Apr 8 2020, 11:28 AM

daniel moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Apr 8 2020, 11:47 AM

Urbanecm edited parent tasks, added: T189073: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere; removed: T243980: Find rangeblocks exceeding $wgBlockCIDRLimit to review/lift them.Apr 11 2020, 6:43 PM

Urbanecm added a parent task: T243980: Find rangeblocks exceeding $wgBlockCIDRLimit to review/lift them.

Urbanecm mentioned this in T250020: Refactor logic for doing and logging unblock out of SpecialUnblock so it can be easily reused elsewhere.Apr 11 2020, 10:11 PM

Urbanecm added a parent task: T250020: Refactor logic for doing and logging unblock out of SpecialUnblock so it can be easily reused elsewhere.

Reedy mentioned this in T251846: Add maintenance script for mass locking.May 5 2020, 12:36 AM

CCicalese_WMF edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).Jul 31 2020, 5:07 PM

Jony subscribed.Aug 1 2020, 8:58 AM