Page MenuHomePhabricator
Create Task
Maniphest T243221

Rewrite LogicException in Cite using safer alternatives
Open, Needs TriagePublic1 Estimated Story Points
Actions

Description

Possibly user-facing throw new LogicException, if there are any (CodeSearch), should be rewritten to:

  • Log at error or warning level, making sure this will be tagged with the extension name.
  • Safely escape from the unknown state. Degrade the output if necessary (for a dramatic example, don't process any remaining references) but without the fatal exception. Another possibility is to throw a recoverable exception and catch it elsewhere.

Details

SubjectRepoBranchLines /-
Remove one unnecessary LogicException from ReferenceStackmediawiki/extensions/Citemaster 2 -17
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Jan 20 2020, 3:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2020, 3:58 PM
thiemowmde added projects: Technical-Debt, User-thiemowmde.Jan 28 2020, 9:07 AM
thiemowmde added subscribers: thiemowmde, WMDE-Fisch.

This task is directly related to T242434: ReferenceStack.php: Unknown ref "BLUE" in group "" and T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php).

Also see T240671: Retrospective and learnings from the Parser/Cite clone incident.

gerritbot added a comment.Jan 28 2020, 3:16 PM

Change 567971 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Remove one unnecessary LogicException from ReferenceStack

https://gerrit.wikimedia.org/r/567971

gerritbot added a project: Patch-For-Review.Jan 28 2020, 3:16 PM
gerritbot added a comment.Feb 3 2020, 2:50 PM

Change 567971 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Remove one unnecessary LogicException from ReferenceStack

https://gerrit.wikimedia.org/r/567971

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 3 2020, 3:01 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 3 2020, 3:10 PM
Izno moved this task from Unsorted backlog to Enhancement backlog on the Cite board.May 5 2020, 11:23 PM
thiemowmde mentioned this in T245376: Reflist with embedded refs no longer shown in section preview.Jul 21 2020, 11:23 AM
awight moved this task from Proposed to Maintenance Backlog on the WMDE-TechWish board.Oct 30 2020, 1:33 PM
thiemowmde set the point value for this task to 1.Nov 3 2020, 9:57 AM
thiemowmde added a project: MediaWiki-extensions-Maintenance (by Skizzerz).
thiemowmde edited projects, added WMDE-TechWish-Maintenance; removed MediaWiki-extensions-Maintenance (by Skizzerz).Nov 3 2020, 11:25 AM
thiemowmde added a comment.Dec 11 2020, 2:33 PM

This might already be resolved. As of now, there are 6 LogicExceptions in 2 files in the Cite extension left. As far as I can tell they are all fine, i.e. they can not be triggered by user input, but only when a dev does make a mistake. To do: Check if this impression is correct. Possibly remove some of the LogicExceptions that aren't needed any more.

Krinkle renamed this task from Rewrite LogicException using safer alternatives to Rewrite LogicException in Cite using safer alternatives.Oct 4 2021, 11:03 PM
awight moved this task from Incoming to Backlog on the WMDE-TechWish-Maintenance board.Dec 7 2021, 2:34 PM
thiemowmde added a project: WMDE-References-FocusArea.Mar 13 2023, 2:10 PM
awight mentioned this in T351997: Identify approachable tasks on the Cite workboard.Nov 28 2023, 3:35 PM
thiemowmde updated the task description. (Show Details)Dec 1 2023, 1:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits