Page MenuHomePhabricator

OpenID needs uses of global $wgUser removed
Closed, DeclinedPublic

Description

See parent task.

Event Timeline

DannyS712 triaged this task as Medium priority.Jan 13 2020, 1:24 AM
DannyS712 created this task.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 563754 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/OpenID@master] Remove use of global $wgUser (part 1)

https://gerrit.wikimedia.org/r/563754

Change 563754 merged by jenkins-bot:
[mediawiki/extensions/OpenID@master] Remove use of global $wgUser (part 1)

https://gerrit.wikimedia.org/r/563754

Change 564106 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/OpenID@master] Remove use of global $wgUser (part 2)

https://gerrit.wikimedia.org/r/564106

Change 564106 merged by jenkins-bot:
[mediawiki/extensions/OpenID@master] Remove use of global $wgUser (part 2)

https://gerrit.wikimedia.org/r/564106

Change 565363 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/OpenID@master] Remove uses of global $wgUser (part 3)

https://gerrit.wikimedia.org/r/565363

Change 565363 merged by jenkins-bot:
[mediawiki/extensions/OpenID@master] Remove uses of global $wgUser (part 3)

https://gerrit.wikimedia.org/r/565363

Change 574974 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/OpenID@master] Remove uses of global $wgUser (part 4)

https://gerrit.wikimedia.org/r/574974

Change 574974 merged by jenkins-bot:
[mediawiki/extensions/OpenID@master] Remove uses of global $wgUser (part 4)

https://gerrit.wikimedia.org/r/574974

One of the remaining uses is in if ( empty( $wgUser->mPassword ) && empty( $wgUser->mNewpassword ) ) { - those fields were made private in 1.27 by @Anomie - see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/ /3d0b4fea3dfb94610be0f0e9d8ff1cb24f106707^!/#F1

Not sure how to deal with the remaining uses - not WMF deployed, so not a priority