Page MenuHomePhabricator
Create Task
Maniphest T241971

useEntitySourceBasedFederation true by default in Wikibase
Closed, ResolvedPublic
Actions

Description

Commons has been using these services for quite some time now.

Having the default switched would have stopped us running into things like T232040#5774510 as all dev machines would have already been switched.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Jan 6 2020, 9:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2020, 9:16 AM
Addshore added a subscriber: WMDE-leszek.Jan 6 2020, 9:16 AM
Addshore updated the task description. (Show Details)Jan 6 2020, 9:20 AM
Addshore added a parent task: T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config.Jan 6 2020, 9:23 AM
Addshore mentioned this in T232040: Add label and description collision detectors for new terms store.
Addshore added a parent task: T242087: entitysources: Directly create entitySources config for WMF sites instead of using compat layer.Jan 7 2020, 10:12 AM
Addshore removed a parent task: T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config.
Addshore moved this task from Incoming to Ready to pick up on the Wikidata-Campsite board.Jan 7 2020, 10:30 AM
Addshore moved this task from Ready to pick up to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 7 2020, 1:30 PM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 7 2020, 2:15 PM
gerritbot added a comment.Jan 7 2020, 6:44 PM

Change 562578 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/mediawiki-config@master] Set useEntitySourceBasedFederation to true for Wikidata

https://gerrit.wikimedia.org/r/562578

Ladsgroup claimed this task.Jan 7 2020, 6:45 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 7 2020, 6:45 PM
gerritbot added a project: Patch-For-Review.Jan 7 2020, 6:45 PM
gerritbot added a comment.Jan 7 2020, 6:53 PM

Change 562579 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Set useEntitySourceBasedFederation true by default

https://gerrit.wikimedia.org/r/562579

Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Jan 7 2020, 7:15 PM
Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 8 2020, 5:10 AM
gerritbot added a comment.Jan 8 2020, 5:43 AM

Change 562694 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Stop resetting the TermBuffer service

https://gerrit.wikimedia.org/r/562694

gerritbot added a comment.Jan 8 2020, 9:35 AM

Change 562775 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Introduce resetPrefetchingTermLookup in WikibaseServices

https://gerrit.wikimedia.org/r/562775

gerritbot added a comment.Jan 8 2020, 9:38 AM

Change 562776 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Reset TermBuffer service properly in tests

https://gerrit.wikimedia.org/r/562776

Ladsgroup removed Ladsgroup as the assignee of this task.Jan 8 2020, 6:48 PM
Ladsgroup moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Ladsgroup subscribed.

@WMDE-leszek said he will look into this.

WMDE-leszek claimed this task.Jan 9 2020, 5:43 PM
WMDE-leszek moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jan 9 2020, 6:11 PM

Change 563235 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] NOT READY: work on T241971

https://gerrit.wikimedia.org/r/563235

gerritbot added a comment.Jan 10 2020, 2:10 PM

Change 563235 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Adjust integration test clean up to have test pass also when EntitySources based federation is in use

https://gerrit.wikimedia.org/r/563235

gerritbot added a comment.Jan 13 2020, 12:48 PM

Change 563235 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Adjust integration test clean up to have test pass also when EntitySources based federation is in use

https://gerrit.wikimedia.org/r/563235

Addshore triaged this task as High priority.Jan 14 2020, 4:08 PM
Addshore merged a task: T243190: entitysources: Switch the default value of the useEntitySourceBasedFederation to true in both Repo and Client.Jan 20 2020, 2:11 PM
Addshore mentioned this in T214557: Allow accessing Wikibase entities from multiple (Wikibase) databases.
Addshore added subscribers: gerritbot, Jdforrester-WMF, Jheald, • Pablo-WMDE.
Addshore removed a subtask: T241972: wmgUseEntitySourceBasedFederation true for Wikidata.org.Jan 22 2020, 12:12 PM

Just added T243395: wmgUseEntitySourceBasedFederation true for Wikimedia clients (all sites) which should probably happen first.

WMDE-leszek removed WMDE-leszek as the assignee of this task.Jan 24 2020, 12:12 PM
WMDE-leszek moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jan 28 2020, 10:07 AM

Change 562579 abandoned by Ladsgroup:
Set useEntitySourceBasedFederation true by default

Reason:
Other patches exist already

https://gerrit.wikimedia.org/r/562579

gerritbot added a comment.Jan 28 2020, 10:07 AM

Change 562775 abandoned by Ladsgroup:
Introduce resetPrefetchingTermLookup in WikibaseServices

Reason:
Other patches exist already

https://gerrit.wikimedia.org/r/562775

Addshore moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 28 2020, 10:15 AM
gerritbot added a comment.Jan 30 2020, 3:58 PM

Change 569016 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] WikibaseRepoTest: adjust test entity source to also provide items

https://gerrit.wikimedia.org/r/569016

gerritbot added a comment.Jan 30 2020, 3:58 PM

Change 569017 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Unify localEntitySourceName config setting in client and repo

https://gerrit.wikimedia.org/r/569017

gerritbot added a comment.Jan 31 2020, 5:58 PM

Change 569252 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Set useEntitySourceBasedFederation config option to true by default

https://gerrit.wikimedia.org/r/569252

gerritbot added a comment.Jan 31 2020, 5:59 PM

Change 569262 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[operations/mediawiki-config@master] Set wmgUseEntitySourceBasedFederation to true for all wikibase-enabled wikis

https://gerrit.wikimedia.org/r/569262

gerritbot added a comment.Feb 1 2020, 6:24 PM

Change 569323 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Swap federation mode in RepoLinker constructor in some tests

https://gerrit.wikimedia.org/r/569323

gerritbot added a comment.Feb 1 2020, 6:24 PM

Change 569324 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Swap federation mode in some more tests

https://gerrit.wikimedia.org/r/569324

gerritbot added a comment.Feb 1 2020, 6:25 PM

Change 569328 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Reorganized slightly ValidatorBuildersTest

https://gerrit.wikimedia.org/r/569328

Addshore closed subtask T243395: wmgUseEntitySourceBasedFederation true for Wikimedia clients (all sites) as Resolved.Feb 6 2020, 7:14 PM
Addshore moved this task from Stalled/Waiting to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 7 2020, 8:33 AM
gerritbot added a comment.Feb 7 2020, 8:54 AM

Change 569016 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] WikibaseRepoTest: adjust test entity source to also provide items

https://gerrit.wikimedia.org/r/569016

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 7 2020, 9:00 AM
gerritbot added a comment.Feb 7 2020, 9:05 AM

Change 569262 abandoned by WMDE-leszek:
Set wmgUseEntitySourceBasedFederation to true for all wikibase-enabled wikis

Reason:
done in Ie3fe016c07d6aefec2ef33632458a148e0d90135

https://gerrit.wikimedia.org/r/569262

gerritbot added a comment.Feb 7 2020, 2:03 PM

Change 569328 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Reorganized slightly ValidatorBuildersTest

https://gerrit.wikimedia.org/r/569328

gerritbot added a comment.Feb 7 2020, 2:04 PM

Change 569323 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Swap federation mode in RepoLinker constructor in some tests

https://gerrit.wikimedia.org/r/569323

gerritbot added a comment.Feb 7 2020, 2:04 PM

Change 569324 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Swap federation mode in some more tests

https://gerrit.wikimedia.org/r/569324

gerritbot added a comment.Feb 7 2020, 2:11 PM

Change 569017 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Unify localEntitySourceName config setting in client and repo

https://gerrit.wikimedia.org/r/569017

gerritbot added a comment.Feb 7 2020, 4:08 PM

Change 569252 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Set useEntitySourceBasedFederation config option to true by default

https://gerrit.wikimedia.org/r/569252

WMDE-leszek closed this task as Resolved.Feb 10 2020, 9:30 AM
WMDE-leszek claimed this task.
WMDE-leszek moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.Feb 10 2020, 10:15 AM
gerritbot added a comment.Jan 27 2022, 4:08 PM

Change 562776 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/WikibaseLexeme@master] Reset TermBuffer service properly in tests

Reason:

no longer relevant

https://gerrit.wikimedia.org/r/562776

gerritbot added a comment.Jan 27 2022, 4:09 PM

Change 562694 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/WikibaseLexeme@master] Stop resetting the TermBuffer service

Reason:

no longer relevant

https://gerrit.wikimedia.org/r/562694

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits