Edge case category link output difference
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ssastry
	Oct 24 2019, 5:24 PM

Description

See below. Found on scandium.

[subbu@earth:~/work/wmf/parsoid] echo "[[Category:Foo|0]]" | parse.js --body_only
<link rel="mw:PageProp/Category" href="./Category:Foo#0" data-parsoid='{"stx":"piped","a":{"href":"./Category:Foo"},"sa":{"href":"Category:Foo"},"dsr":[0,18,null,null]}'/>

[subbu@earth:~/work/wmf/parsoid] echo "[[Category:Foo|0]]" | php bin/parse.php --body_only
<link rel="mw:PageProp/Category" href="./Category:Foo" data-parsoid='{"stx":"piped","a":{"href":"./Category:Foo"},"sa":{"href":"Category:Foo"},"dsr":[0,18,null,null]}'/>

Details

	Subject	Repo	Branch	Lines /-
	Fix for "0" in category link output not being present	mediawiki/services/parsoid	master	1 -1

Customize query in gerrit

Related Objects

Mentioned In: T239830: Add metrics for startup time for language variant code
T214649: VE's gallery representation differs enough so that selser is never applied?
T239929: Class 'Parsoid\Language\LanguageKk' not found
T236912: Return value of Parsoid\Wt2Html\PP\Processors\WrapSections::getDSR() must be of the type integer, null returned
T240091: "PHP Notice: Undefined offset: 2" in WikitextEscapeHandlers
Mentioned Here: T214649: VE's gallery representation differs enough so that selser is never applied?
T236912: Return value of Parsoid\Wt2Html\PP\Processors\WrapSections::getDSR() must be of the type integer, null returned
T239830: Add metrics for startup time for language variant code
T239929: Class 'Parsoid\Language\LanguageKk' not found
T240091: "PHP Notice: Undefined offset: 2" in WikitextEscapeHandlers
rGPAR8ccc08587e24: Account for undefined dsr

Event Timeline

ssastry triaged this task as Medium priority.Oct 24 2019, 5:24 PM

ssastry created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2019, 5:24 PM

ssastry moved this task from Backlog to Bugs, Notices, Crashers on the Parsoid-PHP board.Oct 24 2019, 5:24 PM

But check with "|1" instead of "|0":

[subbu@earth:~/work/wmf/parsoid] echo "[[Category:Foo|1]]" | php bin/parse.php --body_only
<link rel="mw:PageProp/Category" href="./Category:Foo#1" data-parsoid='{"stx":"piped","a":{"href":"./Category:Foo"},"sa":{"href":"Category:Foo"},"dsr":[0,18,null,null]}'/>

So, probably some bad falsy value check.

ssastry assigned this task to • Sbailey.Dec 12 2019, 5:17 PM

Change 557149 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] Fix for "0" in category link output not being present

https://gerrit.wikimedia.org/r/557149

gerritbot added a project: Patch-For-Review.Dec 13 2019, 11:24 PM

Change 557149 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Fix for "0" in category link output not being present

https://gerrit.wikimedia.org/r/557149

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2019, 3:10 AM

• Sbailey closed this task as Resolved.Dec 16 2019, 3:29 PM