Special:NewSection does not properly handle preloadparams
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ylevental
	Aug 23 2019, 2:45 PM

Description

This edit on the English Wikipedia caused the "Submit an edit request" button to begin going to URLs like https://en.wikipedia.org/w/index.php?title=Special:NewSection/Template_talk:Submit_an_edit_request&preload=Template:Submit an edit request/preload&editintro=Template:Edit protected/editintro&preloadtitle=Protected edit request on 23 August 2019&preloadparams[]=edit fully-protected&preloadparams[]=Template:Submit an edit request. The redirect from Special:NewSection drops the preloadparams parameter, preventing the $1 and $2 from being replaced in the preload text.

original report

Go to https://en.wikipedia.org/wiki/Selman_Akbulut, and click "View Source". Click "Submit an edit request". Following the directions on this page creates "Template:$1" in a new section, which does not exist.

Example result: https://en.wikipedia.org/w/index.php?title=Talk:Selman_Akbulut&diff=next&oldid=912140199

Details

	Subject	Repo	Branch	Lines /-
	SpecialNewSection: Fix handling of 'preloadparams'	mediawiki/core	master	1 -1

Customize query in gerrit

Related Objects

Mentioned In: T231382: VisualEditor/NWE does not handle 'preloadparams' with explicit indexes

Event Timeline

Ylevental created this task.Aug 23 2019, 2:45 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptAug 23 2019, 2:45 PM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript

Anomie edited projects, added MediaWiki-Page-editing; removed VisualEditor, TemplateStyles, TemplateData.Aug 23 2019, 2:53 PM

Anomie renamed this task from Submitting an edit request for the Selman Akbulut article creates a template that does not exist to Special:NewSection does not properly handle preloadparams.Aug 23 2019, 3:11 PM

Anomie updated the task description. (Show Details)

Anomie added subscribers: DannyS712, Umherirrender.

Change 532421 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] SpecialNewSection: Fix handling of 'preloadparams'

https://gerrit.wikimedia.org/r/532421

gerritbot added a project: Patch-For-Review.Aug 26 2019, 6:03 PM

As a side note, I noticed that the redirect generates URL parameters that don't work in VE. I submitted a patch for that too: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/ /532424

Change 532421 merged by jenkins-bot:
[mediawiki/core@master] SpecialNewSection: Fix handling of 'preloadparams'

https://gerrit.wikimedia.org/r/532421

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 27 2019, 12:01 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2019, 12:10 AM

DannyS712 closed this task as Resolved.Aug 27 2019, 12:17 AM

DannyS712 assigned this task to matmarex.

matmarex mentioned this in T231382: VisualEditor/NWE does not handle 'preloadparams' with explicit indexes.Aug 27 2019, 8:23 PM

Aklapper removed subscribers: TemplateStyles, TemplateData.May 16 2023, 12:19 PM