Overview
This task involves the work with answering the following question:
For context items in mobile VE, are the right logging events being fired by the right user actions/inputs at the right times?
The above is intended to help us verify the work we recently did to enhance instrumentation for mobile context items and dialogs in mobile VE is working as we expect it to: T221252
Open issues
Instructions
In the mobile visual editor, perform each of the actions listed below and verify that a VisualEditorFeatureUse event fires with the appropriate feature and action values (written in the table as feature:action). These events should fire in all sessions (not just a sample).
The easiest way to monitor events is by enabling the in-site monitoring UI (see instructions at https://www.mediawiki.org/wiki/Extension:EventLogging/Programming#Monitoring_events).
Testing an event
Follow these steps to test whether the right event is firing when tapping an existing link:
- View the mobile version of the following page on your laptop, in Chrome: https://en.wikipedia.org/wiki/Biological_life_cycle?trackdebug=1&useformat=mobile
- Open the inspector in Chrome
- Make sure you are on the “Console” tab within the inspector (you most likely will have landed in the “Element” tab)
- Tap an edit pencil
- Tap an existing link internal link
- Look in the browser's console to confirm the following event was fired: mf.schemaVisualEditorFeatureUse {feature: "link/internal", action: "context-show", editingSessionId: "88ef878111dc034c9c5c"}
Actions and Events
Opening of windows
| Action | Event | Event fired (Y/N) | Next Steps |
| Tap edit in an existing context item | window-open-from-context | Yes | None. Re-tested after this patch was merged. Working properly. |
| A keyboard shortcut is used to open a context item [1] | window-open-from-trigger | Skip testing | |
| Enter {{ to open a template dialog | window-open-from-sequence/ | ||
| Tap an edit tool in the editing toolbar | window-open-from-tool | Yes | None. Re-tested after this patch was merged. Working properly. |
| Tap to add a new citation, tap "Manual" tab, tap "Book" | window-open-from-command | No | @Ryasmeen file ticket; place here once filed. Done: T229255 |
| Open an existing link, tap edit, tap "X" in the search dialog | dialog-abort | Yes | |
| Insert a new link, in "Link" dialog, enter new text into "Search pages" search field, tap "Done" | dialog-apply | Yes dialog-done showed instead of dialog-apply. This behavior is expected. | |
- window-open-from-trigger: not technically desktop only, but requires an external bluetooth keyboard on mobile, so unlikely this will be used.
Context items
| Action | Event | Event fired (Y/N) | Next Steps |
| Tap an existing link, citation, image, table, etc. [2] | context-show | Yes | |
| Tap an existing annotation - link, citation, etc., tap "trash" or "unlink" icon | context-clear | What I am seeing is that context-clear only gets fired when I click on "unlink" icon, and for all "trash" icons it fires context-delete | @DLynch to confirm these events are firing as they should. |
| Delete an existing node - table, etc. | context-delete | Yes | |
- Several events at once could be fired
Links
| Action | Event | Event fired (Y/N) | Next steps |
| Tap an existing internal link, tap "edit" | link/internal:context-show then link:window-open-from-context | Yes | |
| Tap an existing external link, tap "edit" | link:context-show then link:window-open-from-context | Yes | |
| With a link dialog open, type text into the "Search pages" search field | link:search-pages-input | Yes | |
| With a link dialog open, type text into the "External link" link field | link:external-link-input | Yes | |
| With the link dialog open, switch between the "Search pages" and "External link" tabs | link:panel-switch | Yes | |
| Tap a link from the "Search pages" article search results list | link:search-pages-choose | Yes | |
| Tap "Done" from either the "Search pages" or "External link" tabs | link:dialog-apply | Yes dialog-done showed instead of dialog-apply. This behavior is expected. | |
Citations
| Action | Event | Event fired (Y/N) | Next steps |
| Tap citation icon in toolbar, | citoid:window-open | Yes | None. Re-tested after this patch was merged. Working properly. |
| Tap the "Automatic", "Manual" and "Re-use" tabs | citoid:panel-switch | Yes | - |
| Tap the "Manual" tab, tap a template: "Website", "Book" etc. | citoid:manual-choose | citoid:manual-choose firing correctly for all cases; however citoid:dialog-abort is also firing. This behavior is expected. | After patch 526444, citoid:dialog-abort is replaced by citoid:dialog-manual-choose. |
| Tap citation icon in toolbar, tap "Automatic" tab (if not already selected), insert URL, tap "Generate" | citoid:automatic-generate | citoid:automatic-generate firing correctly when tapping "Automatic" tab; however citoid panel-switch is also firing. This behavior is expected. | |
| Tap "insert" | citoid:automatic-insert | Yes | |
| Tap citation icon in toolbar, tap "Re-use" tab, tap an existing citation | citoid:reuse-choose | Yes | |
| Edit an existing citation, make changes in dialog, tap "Apply changes" | citoid:dialog-apply | Yes | None. Re-tested after this patch was merged. Working properly. |
| Edit an existing citation, tap "X" in the dialog that appears | citoid:dialog-abort | Yes | |
"Done"
- We know which of the actions listed in the "Instrumentation" section of the **VE feature instrumentation spec are firing logging events in the way they should be.