Page MenuHomePhabricator
Create Task
Maniphest T225939

System and composite block messages on mobile contain confusing information
Closed, ResolvedPublic
Actions

Description

From T225748#5261787

Screenshot of a composite block message on mobile:

mobile_composite_message.png (307×506 px, 17 KB)

  1. Block message reports the blocking user as "MediaWiki default", which may be confusing
  2. The "Details" link takes you to /w/index.php?title=Special:BlockList&wpTarget=#null, which confusingly does not show details of the composite block or system block

More about (1): Some system blocks report an arguably-more-useful message for the blocking user (e.g. "Proxy blocker" in en for proxy blocks). "Mediawiki default" is hard-coded for soft blocks and composite blocks. One thing that complicates this is that the 'byText' option for a system block needs to be defined in $wgReservedUsernames; presumably "Mediawiki default" was chosen as an alternative to defining a new message there.

More about (2): This is problematic for all system blocks. System and composite blocks don't have block IDs and aren't listed on Special:BlockList, so having this link for them is not helpful.

One solution could be to remove both the information about the blocker and the "Details" link from the mobile block message for system and composite blocks. The important information for these blocks, including links to helpful information, could be delivered via the reason instead.

Details

SubjectRepoBranchLines /-
Fix block message drawer to link correctly to Special:BlockListmediawiki/extensions/MobileFrontendmaster 10 -6
Remove link from block message drawer for blocks with no IDmediawiki/extensions/MobileFrontendmaster 21 -9
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Jun 17 2019, 1:27 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptJun 17 2019, 1:27 PM
Tchanders mentioned this in T225748: Fix block message for CompositeBlocks.Jun 17 2019, 1:28 PM
Tchanders added a subscriber: dbarratt.
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Jun 18 2019, 4:19 PM
Niharika subscribed.Jun 18 2019, 4:26 PM

Ideally, the information displayed on mobile should be the same as the information on desktop which we decided on in T212326: Overlapping blocks may display incorrect block notice.

In T212326#5257452, @Niharika wrote:

From the estimation meeting:

  • Add the block IDs
  • Show the expiry (last expiry from the blocks)
  • Show the reason (if we can)

I think it makes sense to get rid of the Blocked by part entirely.

Ideally, the Details link should take them to someplace where they have a way to appeal against the block. If we can't think of a good way to do that, it might just be better to remove that. I do think linking to the block IDs is helpful - can we do that from the Reason for the block?

Niharika triaged this task as Medium priority.Jun 18 2019, 4:27 PM
Tchanders mentioned this in T212326: Overlapping blocks may display incorrect block notice.Jul 11 2019, 1:52 PM
Tchanders mentioned this in T233996: Mobile block notice not showing block reason or block log entry for global blocks.Sep 30 2019, 7:57 PM
Niharika mentioned this in T227174: Improve the consistency of block error notices.Sep 30 2019, 10:22 PM
Niharika moved this task from Triage/To be Estimated to Product/Tech backlog on the Anti-Harassment board.
gerritbot added a comment.Oct 24 2019, 8:52 PM

Change 545939 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/MobileFrontend@master] Remove link from block message drawer for blocks with no ID

https://gerrit.wikimedia.org/r/545939

gerritbot added a project: Patch-For-Review.Oct 24 2019, 8:52 PM
gerritbot added a comment.Oct 24 2019, 11:43 PM

Change 545939 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove link from block message drawer for blocks with no ID

https://gerrit.wikimedia.org/r/545939

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2019, 12:10 AM
dom_walden subscribed.Oct 31 2019, 11:33 AM

@Tchanders I am finding on beta and test that the "Details" link in mobile block messages has an empty href.

Experimenting locally, it seems to first happen when I checkout commit ae63069bea9e928ab706783d9360a78dbce793a2.

Niharika moved this task from Product/Tech backlog to The Letter Song on the Anti-Harassment board.Oct 31 2019, 2:18 PM
Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
gerritbot added a comment.Oct 31 2019, 7:47 PM

Change 547641 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/MobileFrontend@master] Fix block message drawer to link correctly to Special:BlockList

https://gerrit.wikimedia.org/r/547641

gerritbot added a project: Patch-For-Review.Oct 31 2019, 7:47 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Oct 31 2019, 7:50 PM
  1. Block message reports the blocking user as "MediaWiki default", which may be confusing

Fixed by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/ /546991/

Tchanders claimed this task.Nov 1 2019, 12:15 PM
gerritbot added a comment.Nov 1 2019, 1:11 PM

Change 547641 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix block message drawer to link correctly to Special:BlockList

https://gerrit.wikimedia.org/r/547641

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Nov 1 2019, 1:11 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 1 2019, 2:10 PM
dbarratt updated the task description. (Show Details)Nov 1 2019, 3:27 PM
dom_walden moved this task from QA/Testing 🐞 to Done (2019-20: Q2) on the Anti-Harassment (The Letter Song) board.Nov 13 2019, 11:47 AM

On Beta, testing username, IP, autoblocks and cookie blocks. The "Details" link appears and links to the correct block ID in Special:BlockList.

Testing composite blocks the "Details" link does not appear.

On my local VM, testing system blocks ($wgProxyList, $wgSoftBlockRanges, and $wgEnableDnsBlacklist) the "Details" link does not appear.

On my local vagrant, I tested the local blocks created by CentralAuth. The "Details" link ID is correct, but the block is hidden so a regular user would not see anything when they click through to Special:BlockList (just "No matching blocks found for the requested IP address or username."). It might still be useful to show users the link so they can send it to an admin, for example. @Niharika any strong opinions?

I only tested how the error message looked on mobile editing.

dbarratt closed this task as Resolved.Nov 13 2019, 4:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits