Page MenuHomePhabricator
Create Task
Maniphest T225366

"Fatal exception: MediaWiki\Revision\InvalidArgumentException" when trying to move user JS page on en.wp
Open, MediumPublicPRODUCTION ERROR
Actions

Description

Attempting to move in own user space JS from

to

caused uncaught

Fatal exception of type "InvalidArgumentException"

several times. The origial plan has been not to move talk page, but trying other options without watching or with moving talk page brought the same error.

In T225309#5243275, @Aklapper wrote:
Thanks for reporting this! Please always post the exception_ID

Okay, here we are:

  • XPwI7wpAMFgAADILjcgAAAAG
  • XPwJYwpAIDAAAFTPS18AAACF
  • XPwJfApAICIAAIrzugkAAABP
  • XPwJogpAICsAAH5VdoIAAABS

Actually, I am not used to report fatal errors over years.

Details

SubjectRepoBranchLines /-
RevisionStore and PageUpdater: handle stale page IDmediawiki/coremaster 161 -9
Do move options checks before the movemediawiki/coremaster 13 -13
Customize query in gerrit

Related Objects

Event Timeline

PerfektesChaos created this task.Jun 8 2019, 7:27 PM
Reedy added projects: Wikimedia-production-error, MediaWiki-General.Jun 8 2019, 7:36 PM
Reedy subscribed.
2019-06-08 19:13:52 [XPwI7wpAMFgAADILjcgAAAAG] mw1253 enwiki 1.34.0-wmf.8 exception ERROR: [XPwI7wpAMFgAADILjcgAAAAG] /w/index.php?title=Special:MovePage&action=submit   InvalidArgumentException from line 100 of /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStoreRecord.php: The given Title does not belong to page ID 41443888 but actually belongs to 60994499 {"exception_id":"XPwI7wpAMFgAADILjcgAAAAG","exception_url":"/w/index.php?title=Special:MovePage&action=submit","caught_by":"mwe_handler"} 
[Exception InvalidArgumentException] (/srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStoreRecord.php:100) The given Title does not belong to page ID 41443888 but actually belongs to 60994499
  #0 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(1826): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
  #1 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(2167): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
  #2 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(1535): MediaWiki\Revision\RevisionStore->loadRevisionFromConds(Wikimedia\Rdbms\DBConnRef, array, integer, Title)
  #3 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(1032): MediaWiki\Revision\RevisionStore->getRevisionByTitle(Title)
  #4 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(264): MediaWiki\Permissions\PermissionManager->checkUserConfigPermissions(string, User, array, string, boolean, Title)
  #5 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(145): MediaWiki\Permissions\PermissionManager->getPermissionErrorsInternal(string, User, Title, string)
  #6 /srv/mediawiki/php-1.34.0-wmf.8/includes/Title.php(2252): MediaWiki\Permissions\PermissionManager->getPermissionErrors(string, User, Title, string, array)
  #7 /srv/mediawiki/php-1.34.0-wmf.8/includes/specials/SpecialMovepage.php(655): Title->getUserPermissionsErrors(string, User)
  #8 /srv/mediawiki/php-1.34.0-wmf.8/includes/specials/SpecialMovepage.php(130): MovePageForm->doSubmit()
  #9 /srv/mediawiki/php-1.34.0-wmf.8/includes/specialpage/SpecialPage.php(570): MovePageForm->execute(NULL)
  #10 /srv/mediawiki/php-1.34.0-wmf.8/includes/specialpage/SpecialPageFactory.php(575): SpecialPage->run(NULL)
  #11 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
  #12 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(865): MediaWiki->performRequest()
  #13 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(515): MediaWiki->main()
  #14 /srv/mediawiki/php-1.34.0-wmf.8/index.php(42): MediaWiki->run()
  #15 /srv/mediawiki/w/index.php(3): require(string)
  #16 {main}
2019-06-08 19:15:48 [XPwJYwpAIDAAAFTPS18AAACF] mw1327 enwiki 1.34.0-wmf.8 exception ERROR: [XPwJYwpAIDAAAFTPS18AAACF] /w/index.php?title=Special:MovePage&action=submit   InvalidArgumentException from line 100 of /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStoreRecord.php: The given Title does not belong to page ID 41443888 but actually belongs to 60994510 {"exception_id":"XPwJYwpAIDAAAFTPS18AAACF","exception_url":"/w/index.php?title=Special:MovePage&action=submit","caught_by":"mwe_handler"} 
[Exception InvalidArgumentException] (/srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStoreRecord.php:100) The given Title does not belong to page ID 41443888 but actually belongs to 60994510
  #0 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(1826): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
  #1 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(2167): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
  #2 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(1535): MediaWiki\Revision\RevisionStore->loadRevisionFromConds(Wikimedia\Rdbms\DBConnRef, array, integer, Title)
  #3 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(1032): MediaWiki\Revision\RevisionStore->getRevisionByTitle(Title)
  #4 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(264): MediaWiki\Permissions\PermissionManager->checkUserConfigPermissions(string, User, array, string, boolean, Title)
  #5 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(145): MediaWiki\Permissions\PermissionManager->getPermissionErrorsInternal(string, User, Title, string)
  #6 /srv/mediawiki/php-1.34.0-wmf.8/includes/Title.php(2252): MediaWiki\Permissions\PermissionManager->getPermissionErrors(string, User, Title, string, array)
  #7 /srv/mediawiki/php-1.34.0-wmf.8/includes/specials/SpecialMovepage.php(655): Title->getUserPermissionsErrors(string, User)
  #8 /srv/mediawiki/php-1.34.0-wmf.8/includes/specials/SpecialMovepage.php(130): MovePageForm->doSubmit()
  #9 /srv/mediawiki/php-1.34.0-wmf.8/includes/specialpage/SpecialPage.php(570): MovePageForm->execute(NULL)
  #10 /srv/mediawiki/php-1.34.0-wmf.8/includes/specialpage/SpecialPageFactory.php(575): SpecialPage->run(NULL)
  #11 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
  #12 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(865): MediaWiki->performRequest()
  #13 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(515): MediaWiki->main()
  #14 /srv/mediawiki/php-1.34.0-wmf.8/index.php(42): MediaWiki->run()
  #15 /srv/mediawiki/w/index.php(3): require(string)
  #16 {main}
2019-06-08 19:16:12 [XPwJfApAICIAAIrzugkAAABP] mw1332 enwiki 1.34.0-wmf.8 exception ERROR: [XPwJfApAICIAAIrzugkAAABP] /w/index.php?title=Special:MovePage&action=submit   InvalidArgumentException from line 100 of /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStoreRecord.php: The given Title does not belong to page ID 41443888 but actually belongs to 60994514 {"exception_id":"XPwJfApAICIAAIrzugkAAABP","exception_url":"/w/index.php?title=Special:MovePage&action=submit","caught_by":"mwe_handler"} 
[Exception InvalidArgumentException] (/srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStoreRecord.php:100) The given Title does not belong to page ID 41443888 but actually belongs to 60994514
  #0 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(1826): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
  #1 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(2167): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
  #2 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(1535): MediaWiki\Revision\RevisionStore->loadRevisionFromConds(Wikimedia\Rdbms\DBConnRef, array, integer, Title)
  #3 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(1032): MediaWiki\Revision\RevisionStore->getRevisionByTitle(Title)
  #4 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(264): MediaWiki\Permissions\PermissionManager->checkUserConfigPermissions(string, User, array, string, boolean, Title)
  #5 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(145): MediaWiki\Permissions\PermissionManager->getPermissionErrorsInternal(string, User, Title, string)
  #6 /srv/mediawiki/php-1.34.0-wmf.8/includes/Title.php(2252): MediaWiki\Permissions\PermissionManager->getPermissionErrors(string, User, Title, string, array)
  #7 /srv/mediawiki/php-1.34.0-wmf.8/includes/specials/SpecialMovepage.php(655): Title->getUserPermissionsErrors(string, User)
  #8 /srv/mediawiki/php-1.34.0-wmf.8/includes/specials/SpecialMovepage.php(130): MovePageForm->doSubmit()
  #9 /srv/mediawiki/php-1.34.0-wmf.8/includes/specialpage/SpecialPage.php(570): MovePageForm->execute(NULL)
  #10 /srv/mediawiki/php-1.34.0-wmf.8/includes/specialpage/SpecialPageFactory.php(575): SpecialPage->run(NULL)
  #11 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
  #12 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(865): MediaWiki->performRequest()
  #13 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(515): MediaWiki->main()
  #14 /srv/mediawiki/php-1.34.0-wmf.8/index.php(42): MediaWiki->run()
  #15 /srv/mediawiki/w/index.php(3): require(string)
  #16 {main}
2019-06-08 19:16:51 [XPwJogpAICsAAH5VdoIAAABS] mw1322 enwiki 1.34.0-wmf.8 exception ERROR: [XPwJogpAICsAAH5VdoIAAABS] /w/index.php?title=Special:MovePage&action=submit   InvalidArgumentException from line 100 of /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStoreRecord.php: The given Title does not belong to page ID 41443888 but actually belongs to 60994518 {"exception_id":"XPwJogpAICsAAH5VdoIAAABS","exception_url":"/w/index.php?title=Special:MovePage&action=submit","caught_by":"mwe_handler"} 
[Exception InvalidArgumentException] (/srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStoreRecord.php:100) The given Title does not belong to page ID 41443888 but actually belongs to 60994518
  #0 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(1826): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
  #1 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(2167): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
  #2 /srv/mediawiki/php-1.34.0-wmf.8/includes/Revision/RevisionStore.php(1535): MediaWiki\Revision\RevisionStore->loadRevisionFromConds(Wikimedia\Rdbms\DBConnRef, array, integer, Title)
  #3 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(1032): MediaWiki\Revision\RevisionStore->getRevisionByTitle(Title)
  #4 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(264): MediaWiki\Permissions\PermissionManager->checkUserConfigPermissions(string, User, array, string, boolean, Title)
  #5 /srv/mediawiki/php-1.34.0-wmf.8/includes/Permissions/PermissionManager.php(145): MediaWiki\Permissions\PermissionManager->getPermissionErrorsInternal(string, User, Title, string)
  #6 /srv/mediawiki/php-1.34.0-wmf.8/includes/Title.php(2252): MediaWiki\Permissions\PermissionManager->getPermissionErrors(string, User, Title, string, array)
  #7 /srv/mediawiki/php-1.34.0-wmf.8/includes/specials/SpecialMovepage.php(655): Title->getUserPermissionsErrors(string, User)
  #8 /srv/mediawiki/php-1.34.0-wmf.8/includes/specials/SpecialMovepage.php(130): MovePageForm->doSubmit()
  #9 /srv/mediawiki/php-1.34.0-wmf.8/includes/specialpage/SpecialPage.php(570): MovePageForm->execute(NULL)
  #10 /srv/mediawiki/php-1.34.0-wmf.8/includes/specialpage/SpecialPageFactory.php(575): SpecialPage->run(NULL)
  #11 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
  #12 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(865): MediaWiki->performRequest()
  #13 /srv/mediawiki/php-1.34.0-wmf.8/includes/MediaWiki.php(515): MediaWiki->main()
  #14 /srv/mediawiki/php-1.34.0-wmf.8/index.php(42): MediaWiki->run()
  #15 /srv/mediawiki/w/index.php(3): require(string)
  #16 {main}
Aklapper edited projects, added MediaWiki-Core-Revision-backend; removed MediaWiki-General.Jun 8 2019, 9:47 PM
Tgr subscribed.Jun 9 2019, 3:36 PM

DB lag or some uninvalidated cache, presumably. Note that the permission check is triggered from a security patch that's more or less the equivalent of gerrit 502667 (would be nice to get that merged or dropped) so that will be needed to reproduce it. (I tried but worked fine for me locally. Which is not surprising if it is indeed DB lag.)

PerfektesChaos added a comment.Jun 10 2019, 6:35 PM

Persisting:

[XP6iKApAICIAAJV-xuIAAACS] 2019-06-10 18:32:10

At least no temporary DB lag.

Move worked in March.

Krinkle moved this task from Untriaged to Jun 2019 / 1.34.wmf.8 on the Wikimedia-production-error board.Jun 10 2019, 8:17 PM
Krinkle added a project: Platform Engineering.
• WDoranWMF triaged this task as Medium priority.Jun 11 2019, 12:46 PM
• WDoranWMF added a project: Platform Team Legacy (Next).
• WDoranWMF edited projects, added Platform Team Workboards; removed Platform Team Legacy (Next).
• WDoranWMF moved this task from Not a real column to Ready on the Platform Team Workboards board.
• WDoranWMF edited projects, added Platform Engineering (Needs Cleaning - Code Health (TEC13)); removed Platform Engineering.
• WDoranWMF edited projects, added Platform Engineering (Release Automation (TEC1)); removed Platform Engineering (Needs Cleaning - Code Health (TEC13)).
CCicalese_WMF edited projects, added Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)); removed Platform Engineering (Release Automation (TEC1)).Jun 11 2019, 12:48 PM
daniel subscribed.EditedJun 12 2019, 9:48 AM
In T225366#5247743, @PerfektesChaos wrote:

At least no temporary DB lag.

So this is caused by SpecialMovepage checking the move-subpages right just after moving the page to a different title, which, with the patch mentioned by @Tgr applied, will try to load the latest revision of each subpage to see whether it's a redirect. This seems to fail because it's loading a new Title object from a stale replica, ending up with the wrong page ID.

One quick fix would be to simply check the right to move the subpages before moving the page itself. I see no need to do this after the move.

But the whole situation confuses me a lot:

  • Looking at the code in the patch on gerrit, it seems like the permission check is done on the "base" page, not for each subpage. But I must be confused about this, since the check should be skipped if Title::isUserJsConfigPage returns false.
  • Looking at RevisionStore::getRevisionbyTitle, it seems like the same Title object is used for querying the revision and constructing the RevisionRecord. So there should be no inconsistency there, even if the Title has the wrong page ID.
  • Since we should be checking whether the subpage is a redirect, not the "base" page, there is no reason for the Title object to be stale - the subpage wasn't moved yet.

My suspicion is that the security patch that does the check somehow uses the wrong Title object.

Also, there is code duplication between SpecialMovepage (aka PageMoveForm) and the MovePage helper. Both have code to move subpages. Perhaps this duplication could be removed when fixing this problem.

Tgr added a comment.Jun 12 2019, 11:02 AM

move-subpages is just a right like any other; I don't see any special-casing that would actually try to check anything about the subpages. User:PerfektesChaos/js/WikiSyntaxTextMod/rO.js does not have subpages, anyway. So if there is a replag issue, that can only affect the Title object of the base page.

Given that the bug started in March, and the security patch has been around for a long time, maybe the refactoring from Title to LinkTarget caused a new Title object to be created where previously the same object would have been passed along, preserving any state changes. But then, LinkCache should preserve the state change anyway and MovePage does seem to invalidate it correctly.

Tgr added a comment.Jun 12 2019, 11:25 AM
In T225366#5252653, @daniel wrote:

One quick fix would be to simply check the right to move the subpages before moving the page itself. I see no need to do this after the move.

It seems more correct, even. If that permission somehow depends on the content of the page (say, users are only allowed to move subpages of pages they created), that check should be performed on the page that is to be moved, not on the redirect that gets created in its place.

daniel added a comment.Jun 12 2019, 11:42 AM
In T225366#5252843, @Tgr wrote:

Given that the bug started in March, and the security patch has been around for a long time, maybe the refactoring from Title to LinkTarget caused a new Title object to be created where previously the same object would have been passed along, preserving any state changes.

Given the fact that Title::newFromLinkTarget will just return the parameter unchanged if it's already a Title, that should still work. And given that RevisionStore uses the same Title for querying and object construction should ensure consistency, even if it's stale. It's rather odd.

daniel added a comment.Jun 12 2019, 11:44 AM
In T225366#5252914, @Tgr wrote:
In T225366#5252653, @daniel wrote:

One quick fix would be to simply check the right to move the subpages before moving the page itself. I see no need to do this after the move.

It seems more correct, even. If that permission somehow depends on the content of the page (say, users are only allowed to move subpages of pages they created), that check should be performed on the page that is to be moved, not on the redirect that gets created in its place.

Right. Moreover, we should probably only check that right if moving subpages was requested in the first place.

I'll make a patch, but I feel uneasy about the fact that this will hide the stale Title issue instead of finding it.

gerritbot added a comment.Jun 12 2019, 11:47 AM

Change 516614 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Do move options checks before the move

https://gerrit.wikimedia.org/r/516614

gerritbot added a project: Patch-For-Review.Jun 12 2019, 11:47 AM
Tgr added a comment.Jun 12 2019, 8:02 PM

I wonder what exactly triggers the error... I can't reproduce it on beta enwiki, which does have replicas. Also, there seem to be plenty of JS subpage moves on enwiki (although they all change the username, not the filename, so probably rename-related; and maybe that skips some permission checks?)

gerritbot added a comment.Jun 13 2019, 10:13 AM

Change 516614 merged by jenkins-bot:
[mediawiki/core@master] Do move options checks before the move

https://gerrit.wikimedia.org/r/516614

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 13 2019, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 13 2019, 11:10 AM
Amorymeltzer subscribed.Jun 17 2019, 9:11 PM
RhinosF1 subscribed.Jun 30 2019, 8:43 AM
• WDoranWMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards.Jul 5 2019, 3:12 PM
PerfektesChaos added a comment.Jul 5 2019, 4:11 PM

For the record: success on 2019-07-03.

daniel added a comment.Jul 5 2019, 5:12 PM

So, the concrete issue was fixed by moving the check, but we still don't know the root cause. Is that correct?

Tgr added a comment.Jul 5 2019, 5:31 PM

Yeah. The error was reproducible so I suppose someone could revert on mwdebug, add logging if needed, and test there.

Krinkle mentioned this in Blog Post: Production Excellence #12: June 2019.Jul 31 2019, 6:44 PM
Krinkle moved this task from Untriaged to Revision on the MediaWiki-Core-Revision-backend board.Aug 1 2019, 7:56 PM
PerfektesChaos added a comment.Aug 11 2019, 8:03 PM

This time a regular article page, no JS nor user page.

[XVBv5wpAADsAAGy2lboAAACV] 2019-08-11 19:43:36: Fataler Ausnahmefehler des Typs „InvalidArgumentException“

Attempt to move back Albert Feldstein‎ back over Al Feldstein.

Same attempt before, same message already on 2 May 2019.

May have similar cause, or might require new thread.

• WDoranWMF removed a project: Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)).Aug 13 2019, 7:00 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM
Aklapper mentioned this in T232464: Getting InvalidArgumentException when running a query on the API.Sep 10 2019, 12:10 PM
daniel moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Oct 8 2019, 9:57 AM
Umherirrender subscribed.Dec 4 2019, 9:22 PM

The error message is

The given Title does not belong to page ID 41443888 but actually belongs to 60994499

41443888 is User:PerfektesChaos/js/WikiSyntaxTextMod/rO.6.js, the page to move
I have not found a current page or a archive page with page_id 60994499, so I would assume that is the redirect to leave behind for the move

When the permission check is done after the move (as before the gerrit patch https://gerrit.wikimedia.org/r/#/c/mediawiki/core/ /516614/) than the Title is stale. It still represent the state before the move with the old name and the page id of the page to move. When requesting the Revision with content the title is checked and now fails, because the code there is reading a fresh title objects and has the new page id of the redirect (but still the old name).

I would assume that the issue with js pages is fixed with the patch mention here.

Maybe WikiPage::getRedirectTarget is better to avoid reading the content and just using the values from the redirect table, but that could be hard in a service locator

The move of article pages may some of the other bugs with timeouts on redirects

Krinkle mentioned this in T246720: Unable to save edit due to "The given Title does not belong to page" error (Wikipedias with FlaggedRevs enabled).Mar 10 2020, 1:35 AM
DannyS712 added a project: MediaWiki-Page-rename.Apr 8 2020, 4:32 PM
gerritbot added a comment.Apr 9 2020, 12:08 PM

Change 587722 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] RevisionStore and PageUpdater: handle stale page ID

https://gerrit.wikimedia.org/r/587722

gerritbot added a project: Patch-For-Review.Apr 9 2020, 12:08 PM
daniel moved this task from Backlog to Later on the Platform Team Workboards (Clinic Duty Team) board.Apr 14 2020, 9:00 PM
gerritbot added a comment.Apr 27 2020, 9:16 PM

Change 587722 merged by jenkins-bot:
[mediawiki/core@master] RevisionStore and PageUpdater: handle stale page ID

https://gerrit.wikimedia.org/r/587722

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2020, 10:12 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 28 2020, 8:00 AM
Krinkle removed projects: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error.Jun 9 2020, 2:28 PM
Krinkle subscribed.

Untagging from prod-error as the above acknowledged the root cause and provides it with a fallback to allow basic functionality to still work.

Keeping the task open as the root cause has not yet been found or fixed. The detection added by Daniel's patch is regularly finding these inconsistencies. It is also still to be determined what the damage might be as a result of this. (If this is known, please document it here.)

I also note that the secondary dection added by Daniel's patch (for entirely corrupt rows) has not been triggered in production. So you were correct in assuming it is a problem around two code paths not agreeing where or how to fetch the revision rows from the database. E.g. maybe one of them is bypassing the replica transaction snapshot, or wrongly hitting a cache somewhere, or ignoring an object that should have been passed down etc.

Androl subscribed.EditedOct 4 2020, 5:15 PM

I got the same error when trying to move an article over a redirect on de.wp.
Error id: 59953272-7b9d-4051-a51f-7e3182705cf1

DannyS712 subscribed.Oct 4 2020, 7:26 PM
Umherirrender unsubscribed.Feb 27 2021, 9:51 PM
Seppl2013 subscribed.Apr 9 2021, 12:37 PM

https://www.openresearch.org/wiki/Undeletable/EUROCRYPT_2017 is an example for the problem.

daniel added a comment.Apr 9 2021, 1:15 PM
In T225366#6987345, @Seppl2013 wrote:

https://www.openresearch.org/wiki/Undeletable/EUROCRYPT_2017 is an example for the problem.

Are you sure this is related? InvalidArgumentException is a very generic exception type, it could have all kinds of unrelated causes. This ticket is specifically about being unable to move a page to a .js page in the user namespace, not about being unable to delete.

Seppl2013 added a comment.Apr 9 2021, 2:40 PM

thx for pointing this out so my issue is linked to the wrong phabricator task. Is there already one for the "zombie" case i am experiencing where i can't delete a page?

daniel added a comment.Apr 9 2021, 3:05 PM
In T225366#6987628, @Seppl2013 wrote:

thx for pointing this out so my issue is linked to the wrong phabricator task. Is there already one for the "zombie" case i am experiencing where i can't delete a page?

Probably, but that as well can have many different reasons. A stack trace would help narrow it down. See https://www.mediawiki.org/wiki/Manual:How_to_debug

hgzh mentioned this in T304156: InvalidArgumentException when trying to move a page in the german language version.Mar 18 2022, 12:37 PM
M2k_dewiki subscribed.Mar 18 2022, 12:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits