Can't change image caption selection with mouse on Firefox
Closed, ResolvedPublic
Actions

Description

Image captions can't be selected in Firefox. The media dialog caption editor still works.

Details

	Subject	Repo	Branch	Lines /-
	Update VE core submodule to master (226ff19e5)	mediawiki/extensions/VisualEditor	master	1 -1
	Remove -moz-user-select:none from hack and buttonElement	VisualEditor/VisualEditor	master	8 -7

Customize query in gerrit

Related Objects

Mentioned In: T214976: Can't select across block images in Firefox
Mentioned Here: T214976: Can't select across block images in Firefox
rGVED226ff19e55b4: Fix check in paintAuthor

Event Timeline

Esanders created this task.Feb 25 2019, 3:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2019, 3:49 PM

Change 492698 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Allow selection of active nodes within focusable nodes in Firefox

https://gerrit.wikimedia.org/r/492698

Esanders mentioned this in T214976: Can't select across block images in Firefox.Feb 25 2019, 3:50 PM

gerritbot added a project: Patch-For-Review.Feb 25 2019, 3:50 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Feb 25 2019, 4:32 PM

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Feb 28 2019, 1:17 PM

Change 492698 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Remove -moz-user-select:none from hack and buttonElement

https://gerrit.wikimedia.org/r/492698

Change 493507 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (226ff19e5)

https://gerrit.wikimedia.org/r/493507

Ryasmeen added a project: Editing QA.Feb 28 2019, 9:42 PM

@matmarex/@Esanders: This is still not working for me on Beta cluster for some reason.

Same for T214976.

Change 493507 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (226ff19e5)

https://gerrit.wikimedia.org/r/493507

Sorry, I moved it to the QA column early – we still needed to merge this patch to update the submodule. Now that it's merged, the fix should be available on the beta cluster now (…soon; I'm not sure how long it takes to be deployed from when the patch is merged).

Cirdan subscribed.Mar 4 2019, 8:03 PM

Ryasmeen edited projects, added Verified; removed Editing QA, Patch-For-Review.Mar 4 2019, 8:07 PM

matmarex moved this task from QA to Product owner review on the VisualEditor (Current work) board.Mar 4 2019, 8:17 PM