hey @alexhollender , I've submitted a patch with the requested changes, including the mechanism that changes the layout to "equally spaced" if there are 5 or more items.

However, there is a problem :(

Something that I did not anticipate is that, because extra items are loaded via javascript (i.e. download/share etc.) , that means they are inserted after pageload. That means that the initial layout is parsed as only have 4 items, and then it changes rather abruptly when the extra items are inserted.

I have a video showing this effect.
https://drive.google.com/file/d/10GguWhX2WXQC5U-whE04xvWy_k80gvuk/view?usp=sharing

As you can see, the pageload occurs quite late in the game (especially on long articles).

I've put the above patch on staging for review & some more input http://reading-web-staging.wmflabs.org/wiki/Samsung

If http://reading-web-staging.wmflabs.org/wiki/Special:Version#mw-version-skin is on version ebeb204 then that's the right patch.

documenting a conversation @Jdrewniak and I had offline. It seems like we may largely avoid the awkwardness loading situation, at least for now, because the following default cases will not be affected by it:

AMC off (iOS)	AMC off (Android)	AMC on (iOS/Android)

the cases that will be affected by it are where there are 5 icons in the toolbar (because that's when the icons switch to equal spacing), and one (or more) of them is being loaded via Javascript. Examples are:

• AMC off, Android, map gadget and/or Share beta on (image)
• AMC off, iOS, map gadget and Share beta on

An alternative we could try out would be the non-equal spacing approach:

After speaking with @Jdrewniak a bit more, we think the best course of action is to continue using the current toolbar layout for now, which means there will be no jumping icons. With the addition of the history icon AMC users will see:

iOS	Android	Android w/ map

@ovasileva @Jdlrobson @Jdrewniak shall I update the task description?

We generated some ideas for how to better handle the jumping icon stuff, and hope to have something figured out by the time we get around to introducing the overflow/more menu, so we can switch to our awesome, new, equally spaced icon toolbar.

In T213352#5002174, @alexhollender wrote:

After speaking with @Jdrewniak a bit more, we think the best course of action is to continue using the current toolbar layout for now, which means there will be no jumping icons. With the addition of the history icon AMC users will see:

iOS	Android	Android w/ map

@ovasileva @Jdlrobson @Jdrewniak shall I update the task description?

Sounds good

Change 493415 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Add history icon to page actions menu for AMC mode

https://gerrit.wikimedia.org/r/493415

Change 495067 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Add config option for showing history link in page actions menu

https://gerrit.wikimedia.org/r/495067

Change 495067 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Add config option for showing history link in page actions menu

https://gerrit.wikimedia.org/r/495067

Test Result

Status: In Progress
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X $ iPad Pro)

Test Artifact(s):

• Test on AMC (mobile) (with map gadget on and off)
  
  Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode)
  
  Clicking history will navigate to the mobile version of the history page
  
  If a page does not have a history page, do not display history icon
  
  In AMC mode the three left-most icons should always be: edit, history, watch (in that order, with edit being the furthest left)
  
  In non-AMC mode the two left-most icons should always be: edit, watch (in that order, with edit being the furthest left)
  
  The history link should be feature flagged a la wgMinervaTalkAtTop - it should be possible to turn it on and off in AMC mode.
  
  There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

• Test on AMC Tablet (with map gadget on and off)
  
  Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode)
  
  Clicking history will navigate to the mobile version of the history page
  
  If a page does not have a history page, do not display history icon
  
  In AMC mode the three left-most icons should always be: edit, history, watch (in that order, with edit being the furthest left)
  
  In non-AMC mode the two left-most icons should always be: edit, watch (in that order, with edit being the furthest left)
  
  The history link should be feature flagged a la wgMinervaTalkAtTop - it should be possible to turn it on and off in AMC mode.
  
  There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

• Test on non-AMC tablet (with map gadget on and off)
  
  
  
  
  Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode) : NA
  
  Clicking history will navigate to the mobile version of the history page : NA
  
  If a page does not have a history page, do not display history icon : NA
  
  In AMC mode the three left-most icons should always be: edit, history, watch (in that order, with edit being the furthest left): Should this be rightmost?
  
  In non-AMC mode the two left-most icons should always be: edit, watch (in that order, with edit being the furthest left)Should this be rightmost?
  
  The history link should be feature flagged a la wgMinervaTalkAtTop - it should be possible to turn it on and off in AMC mode.
  
  There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML. Pass

• Test on cached HTML (mobile) (with map gadget on and off)
  
  Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode)
  
  Clicking history will navigate to the mobile version of the history page
  
  If a page does not have a history page, do not display history icon
  
  In AMC mode the three left-most icons should always be: edit, history, watch (in that order, with edit being the furthest left)
  
  In non-AMC mode the two left-most icons should always be: edit, watch (in that order, with edit being the furthest left)
  
  The history link should be feature flagged a la wgMinervaTalkAtTop - it should be possible to turn it on and off in AMC mode.
  
  There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

• Test on cached HTML tablet (with map gadget on and off)
  
  Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode)
  
  Clicking history will navigate to the mobile version of the history page
  
  If a page does not have a history page, do not display history icon
  
  In AMC mode the three left-most icons should always be: edit, history, watch (in that order, with edit being the furthest left)
  
  In non-AMC mode the two left-most icons should always be: edit, watch (in that order, with edit being the furthest left)
  
  The history link should be feature flagged a la wgMinervaTalkAtTop - it should be possible to turn it on and off in AMC mode.
  
  There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

hey @Edtadros , I don't think I know of a simple way to test using cached HTML, but 2, 3, 4:

2. The map gadget - you have to be logged in to wikipedia, then (on desktop) under preferences -> gadgets -> check "Add map popups to coordinates in the mobile website" - then switch to mobile, and pages with locations should have the gadget.
3. Yes, right-most :)
4. I think this can be checked by a developer on a local machine, since it involves changes a MediaWiki config file and seeing if the change takes effect.

In T213352#5019434, @Jdlrobson wrote:

Fleshed out these. I suggest we do not test the map gadget as part of this change, cc @ovasileva

Sounds good - I'll add creating the separate QA task to the signoff criteria here.

Test Results

Status: In Progress
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X and iPad)

Test Artifact(s):

Test on AMC (mobile)

AC1.1: ✅ PASS
Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode) ✅

AC1.2: ✅ PASS
Clicking history will navigate to the mobile version of the history page

❌ - Navigated to: http://readingwebstaging.wmflabs.org/wiki/Special:History/Qatar Page shows error. Failing this for now.

✅ Retested on 3/19/2019: http://readingwebstaging.wmflabs.org/wiki/Amc_test_me

AC1.3: ❌ FAIL
If a page does not have a history page, do not display history icon

❌ History Icon was displayed but the history page appears to not exist.

❌ Retested on 3/19/2019: http://readingwebstaging.wmflabs.org/wiki/User:Edtadros The history link still shows. This time on the far left.

AC1.4: ✅ PASS
In AMC mode the three right-most icons should always be: edit, history, watch (in that order, with edit being the furthest left)

❌ - Order appears to be reversed.

✅ Retested on 3/19/2019: QA steps updated

AC1.5: ✅ PASS
In non-AMC mode the two right-most icons should always be: edit, watch (in that order, with edit being the furthest left)

❌ - Order appears to be reversed.

✅ Retested on 3/19/2019: QA steps updated

AC1.6: ✅ PASS
There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

Test on AMC Tablet

AC2.1: ✅ PASS
Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode) ✅

AC2.2: ✅ PASS
Clicking history will navigate to the mobile version of the history page:

❌ Navigated to: http://readingwebstaging.wmflabs.org/wiki/Special:History/Qatar Page shows error. Failing this for now.

✅ Retested on 3/19/2019: This works now

AC2.3: ❌ FAIL
If a page does not have a history page, do not display history icon
❌ History Icon was displayed but the history page appears to not exist.

❌ Retested on 3/19/2019: This is still failing

AC2.4: ✅ PASS
In AMC mode the three right-most icons should always be: edit, history, watch (in that order, with edit being the furthest left):

❌ Order appears to be reversed.

✅ Retested on 3/19/2019: QA steps updated

AC2.5: ✅ PASS
In non-AMC mode the two right-most icons should always be: edit, watch (in that order, with edit being the furthest left):

❌ - Order appears to be reversed.

✅ Retested on 3/19/2019: QA steps updated

AC2.6: ✅ PASS
There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

Test on non-AMC tablet

AC3.1: ⬜ NA
Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode)

AC3.2: ⬜ NA
Clicking history will navigate to the mobile version of the history page

AC3.3: ⬜ NA
If a page does not have a history page, do not display history icon

AC3.4: ⬜ NA
In AMC mode the three right-most icons should always be: edit, history, watch (in that order, with edit being the furthest left)

AC3.5: ✅ PASS
In non-AMC mode the right left-most icons should always be: edit, watch (in that order, with edit being the furthest left)

✅ Retested on 3/19/2019: QA steps updated

AC3.6: ✅ PASS
There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

A couple of notes on the acceptance criteria (will fix in the description):

• In AMC mode the three right-most icons should always be: edit, history, watch (in that order, with edit being the furthest left) - this is incorrect. Edit is always furthest right.
• In non-AMC mode the two right-most icons should always be: edit, watch (in that order, with edit being the furthest left) - edit is always furthest right

@Edtadros Test on page (http://readingwebstaging.wmflabs.org/wiki/Amc_test_me). All acceptance criteria met except Clicking history will navigate to the mobile version of the history page. Leaving in needs more work.

Test on AMC tablet, non-AMC tablet, AMC mobile

• Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode)

PASS

• Clicking history will navigate to the mobile version of the history page

FAIL - it's navigating to the desktop version

• If a page does not have a history page, do not display history icon

PASS - tested on contributions page, watchlist

• In AMC mode the three right-most icons should always be: download, watch, history, edit (in that order, with edit being the furthest right)

PASS see screenshots above

• In non-AMC mode the two right-most icons should always be: download, watch, edit (in that order, with edit being the furthest left)

PASS

• There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

PASS - see screenshots above

Test on beta cluster page https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog. All acceptance criteria passed:

Test on AMC tablet, non-AMC tablet, AMC mobile

• Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode)

PASS

• Clicking history will navigate to the mobile version of the history page

PASS

• If a page does not have a history page, do not display history icon

PASS - tested on contributions page, watchlist

• In AMC mode the three right-most icons should always be: download, watch, history, edit (in that order, with edit being the furthest right)

PASS see screenshots above

• In non-AMC mode the two right-most icons should always be: download, watch, edit (in that order, with edit being the furthest left)

PASS

• There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

PASS - see screenshot above

Note: tested map gadget on wikis for deployment in T217643. The gadget is not available on Spanish, Arabic, or Indonesian Wikipedias. Testing the map gadget is not a blocker for this deployment. However, a followup task will be created and testing will be a blocker for future deployment to other Wikipedias.

In T213352#5039090, @Edtadros wrote:

@ovasileva I tested in staging and beta and the behavior is the same in both. I updated T213352#5028939 but it's a bit cluttered. In a nutshell, the only thing that isn't passing is the history icon showing up on a page with no history. I used my user page to test this, so this may or may not be valid. The good news is that in both environments when I click on a valid history link it goes to the mobile history page.

Good catch! I read this mostly as pages that couldn't possibly have a history page - but it makes sense - shouldn't show up for pages that don't exist yet.

Change 498051 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Only show history link in page-actions menu if page exists

https://gerrit.wikimedia.org/r/498051

QA Blocked on T218807

Change 498051 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Only show history link in page-actions menu if page exists

https://gerrit.wikimedia.org/r/498051

@Jdlrobson I may be doing something wrong. The link you gave redirects to the New_user_landing_page. I'm logged in with AMC on. See the attached video:

That page has history so I couldn't verify.

Test Results: Production

Status: In Progress
OS: iOS
Browser: Chrome (iPhoneXS Max and iPad Pro)

Test Artifact(s):

Test on AMC (mobile)

AC1.1:
Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode) ✅

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC1.2:
Clicking history will navigate to the mobile version of the history page

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC1.3:
If a page does not have a history page, do not display history icon

eswiki: ❌	arwiki: ❌	idwiki: ✅

AC1.4:
In AMC mode the three right-most icons should always be: watch, history, edit (in that order, with edit being the furthest right) *Reversed for arwiki

AC1.5:
In non-AMC mode the two right-most icons should always be: watch, edit (in that order, with edit being the furthest right) *Reversed for arwiki

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC1.6:
There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

Test on AMC Tablet

AC2.1:
Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode)

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC2.2:
Clicking history will navigate to the mobile version of the history page:

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC2.3:
If a page does not have a history page, do not display history icon

eswiki: ❌	arwiki: ❌	idwiki: ✅

AC2.4:
In AMC mode the three right-most icons should always be: watch, history, edit (in that order, with edit being the furthest right) *Reversed for arwiki

AC2.5:
In non-AMC mode the two right-most icons should always be: edit, watch (in that order, with edit being the furthest left):

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC2.6:
There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

Test on non-AMC tablet

AC3.1:
Add history link to toolbar of pages in all namespaces where History exists (when user is in AMC mode)

AC3.2:
Clicking history will navigate to the mobile version of the history page

AC3.3:
If a page does not have a history page, do not display history icon

AC3.4:
In AMC mode the three right-most icons should always be: watch, history, edit (in that order, with edit being the furthest right) *Reversed for arwiki

AC3.5:
In non-AMC mode the right left-most icons should always be: edit, watch (in that order, with edit being the furthest left)

AC3.6:
There should be no visible changes to non-AMC mode (at least for now) to avoid problems with cached HTML.

@Edtadros - This should be ready to test in production now