Page MenuHomePhabricator
Create Task
Maniphest T212340

VisualEditor silently changes <references responsive="1" /> to <references responsive="" />
Closed, ResolvedPublic
Actions

Description

This was reported on the German-language Wikipedia's feedback page and although it has no visible effect caused some confusion among editors.

Steps to reproduce:

  1. Go to the Internet Archive article or [[https://de.wikipedia.org/w/index.php?search=insource:/responsive=""/&title=Spezial:Suche&profile=advanced&fulltext=1&advancedSearch-current={"namespaces":[0]}&ns0=1|any other article with <references responsive="1" />]]
  2. Open the article for visual editing and make a small change such that Änderungen veröffentlichen... (Publish changes...) turns blue (e.g. delete and add back a character)
  3. Click on Änderungen veröffentlichen (Publish changes...) and select Überprüfe deinen Änderungen (Review your changes)
  4. Observe that <references responsive="1" /> was converted to <references responsive="" />

Details

SubjectRepoBranchLines /-
RefList: Avoid changing 'responsive' value if meaning hasn't changedmediawiki/extensions/Citemaster 14 -7
Customize query in gerrit

Related Objects

Event Timeline

Cirdan created this task.Dec 19 2018, 9:03 PM
Restricted Application added a project: Internet-Archive. · View Herald TranscriptDec 19 2018, 9:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Cirdan mentioned this in T212342: VisualEditor sometimes changes <references responsive> to <references responsive ="">.Dec 19 2018, 9:14 PM
XanonymusX subscribed.Dec 19 2018, 9:55 PM
Cirdan removed a project: Internet-Archive.Dec 20 2018, 4:04 PM
DLynch added subscribers: Esanders, DLynch.Mar 4 2019, 6:04 PM

This is because we don't actually try to preserve the value of the attribute, just its meaning. More potentially-confusing is that we discard the attribute entirely if it's the same as the wiki's default, so if the default changes lots of edits will suddenly be dirtied... and then toggle away from it if the default switches back again.

@Esanders: You set it up this way in the first place -- think it's worth changing to avoid dirty diffs?

JTannerWMF moved this task from To Triage to Up next on the VisualEditor board.Mar 12 2019, 3:36 PM
Esanders claimed this task.Mar 28 2019, 4:41 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Mar 28 2019, 4:41 PM

Change 499814 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Cite@master] RefList: Avoid changing 'responsive' value if meaning hasn't changed

https://gerrit.wikimedia.org/r/499814

gerritbot added a project: Patch-For-Review.Mar 28 2019, 4:41 PM
gerritbot added a comment.Mar 28 2019, 6:38 PM

Change 499814 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] RefList: Avoid changing 'responsive' value if meaning hasn't changed

https://gerrit.wikimedia.org/r/499814

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 28 2019, 7:01 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Mar 28 2019, 10:01 PM
Cirdan added a comment.Mar 29 2019, 5:45 AM

This will resolve T212342: VisualEditor sometimes changes <references responsive> to <references responsive =""> (as a special case of T101841: Value-less extension attributes not preserved) as well, right?

Ryasmeen added a project: Verified.Apr 2 2019, 8:09 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 1:41 PM
ppelberg closed this task as Resolved.May 24 2019, 11:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits