⚓ T208238 [bug] blue and yellow line are reversed

Subject	Repo	Branch	Lines /-
Fix (accidentally?) reversed blue and yellow lines	mediawiki/extensions/RevisionSlider	wmf/1.33.0-wmf.4	6 -6
Fix (accidentally?) reversed blue and yellow lines	mediawiki/extensions/RevisionSlider	wmf/1.33.0-wmf.3	6 -6
Fix (accidentally?) reversed blue and yellow lines	mediawiki/extensions/RevisionSlider	master	6 -6
Reversed the colour of sliders	mediawiki/extensions/RevisionSlider	master	4 -4

Charlie_WMDE created this task.Oct 29 2018, 4:48 PM

Restricted Application added projects: TCB-Team (now WMDE-TechWish), Design. · View Herald TranscriptOct 29 2018, 4:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Lea_WMDE added a project: Season of RevisionSlider.Oct 30 2018, 11:58 AM

• Lea_WMDE awarded a token.

Swathi-0901 claimed this task.Nov 4 2018, 10:42 AM

Vijay9908 mentioned this in rERSL784c5b554d3d: Reversed the colour of sliders.Nov 4 2018, 12:00 PM

Vijay9908 mentioned this in rERSLd1d2b1bd4320: Reversed the colour of sliders.Nov 4 2018, 2:15 PM

Vijay9908 mentioned this in rERSLa7671e1e137f: Reversed the colour of sliders.Nov 4 2018, 2:42 PM

Change 471541 had a related patch set uploaded (by Zoranzoki21; owner: Vijay9908):
[mediawiki/extensions/RevisionSlider@master] Reversed the colour of sliders

https://gerrit.wikimedia.org/r/471541

gerritbot added a project: Patch-For-Review.Nov 4 2018, 2:43 PM

Kizule mentioned this in rERSL80bb3a580158: Reversed the colour of sliders.Nov 4 2018, 2:45 PM

Shivangi1702 claimed this task.Nov 4 2018, 6:04 PM

Shivangi1702 added a subscriber: Swathi-0901.

Shivangi1702 removed a project: Season of RevisionSlider.Nov 4 2018, 6:06 PM

Shivangi1702 removed subscribers: Swathi-0901, gerritbot, • Lea_WMDE and 2 others.

Vijay9908 mentioned this in rERSLca0d7c1b9e9a: Reversed the colour of sliders.Nov 4 2018, 6:28 PM

Change 471776 had a related patch set uploaded (by Vijay9908; owner: Vijay9908):
[mediawiki/extensions/RevisionSlider@master] Bug: T208238 Reversed the colors of the sliders

https://gerrit.wikimedia.org/r/471776

Vijay9908 mentioned this in rERSL3b7dd75c575e: Bug: T208238 Reversed the colors of the sliders.Nov 5 2018, 6:00 PM

Vijay9908 claimed this task.Nov 8 2018, 3:35 PM

Vijay9908 added a subscriber: Shivangi1702.

Vijay9908 removed a subscriber: Shivangi1702.

Change 471541 abandoned by Vijay9908:
Reversed the colour of sliders

https://gerrit.wikimedia.org/r/471541

Change 473217 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/RevisionSlider@master] Fix reversed blue and yellow lines

https://gerrit.wikimedia.org/r/473217

thiemowmde mentioned this in rERSL3246f8534ce0: Fix reversed blue and yellow lines.Nov 13 2018, 2:42 PM

thiemowmde mentioned this in rERSL024c15e0fbb8: Fix reversed blue and yellow lines.

thiemowmde mentioned this in rERSLe227de5a48f1: Fix (accidentally?) reversed blue and yellow lines.Nov 13 2018, 2:45 PM

Change 471776 abandoned by Thiemo Kreuz (WMDE):
Bug: T208238 Reversed the colors of the sliders

Reason:
This patch is empty. I created I0c03e47 as a fix for the bug mentioned. Please have a look.

https://gerrit.wikimedia.org/r/471776

I tracked the issue down to the following change in the patch about T162119: Add keyboard shortcuts to move between revisions: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/RevisionSlider/ /459678/5/modules/ext.RevisionSlider.SliderView.js. I am not sure, but it looks to me like this particular change might have been nothing but a mistake. @SrishtiSethi, can you have a look, please?

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-11-06 board.Nov 13 2018, 2:51 PM

thiemowmde claimed this task.Nov 13 2018, 2:54 PM

thiemowmde triaged this task as Medium priority.

thiemowmde added subscribers: Vijay9908, WMDE-Fisch, • Lea_WMDE.

Change 473217 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Fix (accidentally?) reversed blue and yellow lines

https://gerrit.wikimedia.org/r/473217

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 13 2018, 4:00 PM

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-11-06 board.Nov 14 2018, 11:06 AM

Change 473710 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/RevisionSlider@wmf/1.33.0-wmf.4] Fix (accidentally?) reversed blue and yellow lines

https://gerrit.wikimedia.org/r/473710

Change 473711 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/RevisionSlider@wmf/1.33.0-wmf.3] Fix (accidentally?) reversed blue and yellow lines

https://gerrit.wikimedia.org/r/473711

thiemowmde mentioned this in rERSL553082466922: Fix (accidentally?) reversed blue and yellow lines.Nov 15 2018, 10:21 AM

thiemowmde mentioned this in rERSL987c32b40739: Fix (accidentally?) reversed blue and yellow lines.

Change 473711 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@wmf/1.33.0-wmf.3] Fix (accidentally?) reversed blue and yellow lines

https://gerrit.wikimedia.org/r/473711

Change 473710 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@wmf/1.33.0-wmf.4] Fix (accidentally?) reversed blue and yellow lines

https://gerrit.wikimedia.org/r/473710

Mentioned in SAL (#wikimedia-operations) [2018-11-15T12:37:06Z] <lucaswerkmeister-wmde@deploy1001> Started scap: php-1.33.0-wmf.3/extensions/RevisionSlider/modules/ext.RevisionSlider.SliderView.js [[gerrit:473710|Fix (accidentally?) reversed blue and yellow lines (T162119, T208238)]]

Mentioned in SAL (#wikimedia-operations) [2018-11-15T12:37:17Z] <lucaswerkmeister-wmde@deploy1001> sync aborted: php-1.33.0-wmf.3/extensions/RevisionSlider/modules/ext.RevisionSlider.SliderView.js [[gerrit:473710|Fix (accidentally?) reversed blue and yellow lines (T162119, T208238)]] (duration: 00m 11s)

Mentioned in SAL (#wikimedia-operations) [2018-11-15T12:38:33Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.33.0-wmf.3/extensions/RevisionSlider/modules/ext.RevisionSlider.SliderView.js: [[gerrit:473710|Fix (accidentally?) reversed blue and yellow lines (T162119, T208238)]] (duration: 00m 54s)

Mentioned in SAL (#wikimedia-operations) [2018-11-15T12:59:47Z] <tarrow@deploy1001> Synchronized php-1.33.0-wmf.4/extensions/RevisionSlider/modules/ext.RevisionSlider.SliderView.js: [[gerrit:473710]] Fix (accidentally?) reversed blue and yellow lines SWAT T208238 T162119 again (duration: 00m 55s)