Page MenuHomePhabricator
Create Task
Maniphest T205231

Separate out node classes into separate files
Closed, ResolvedPublic
Actions

Description

A few abstract node classes have their concrete subclasses defined in the same file, which can make them more difficult to discover and is inconsistent with the other nodes.

Details

SubjectRepoBranchLines /-
Separate node classes into individual filesmediawiki/extensions/SyntaxHighlight_GeSHimaster 139 -80
Update VE core submodule to master (2d668bdbb)mediawiki/extensions/VisualEditormaster 17 -1
Separate node classes into individual filesmediawiki/extensions/VisualEditormaster 717 -553
Separate node classes into individual filesVisualEditor/VisualEditormaster 303 -207
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Sep 23 2018, 10:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2018, 10:49 PM
gerritbot subscribed.Sep 23 2018, 10:51 PM

Change 462324 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/VisualEditor@master] Separate node classes into individual files

https://gerrit.wikimedia.org/r/462324

gerritbot added a project: Patch-For-Review.Sep 23 2018, 10:51 PM
gerritbot added a comment.Sep 23 2018, 11:54 PM

Change 462327 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Separate node classes into individual files

https://gerrit.wikimedia.org/r/462327

gerritbot added a comment.Sep 24 2018, 11:40 AM

Change 462327 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Separate node classes into individual files

https://gerrit.wikimedia.org/r/462327

gerritbot added a comment.Sep 24 2018, 1:00 PM

Change 462456 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2d668bdbb)

https://gerrit.wikimedia.org/r/462456

gerritbot added a comment.Sep 24 2018, 1:18 PM

Change 462324 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Separate node classes into individual files

https://gerrit.wikimedia.org/r/462324

gerritbot added a comment.Sep 24 2018, 1:28 PM

Change 462464 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Separate node classes into individual files

https://gerrit.wikimedia.org/r/462464

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 24 2018, 2:00 PM
Jdforrester-WMF added projects: Technical-Debt, VisualEditor-DataModel, Phlogiston (Technical Debt).Sep 24 2018, 3:41 PM
Jdforrester-WMF removed a project: Phlogiston (Technical Debt).
gerritbot added a comment.Sep 24 2018, 4:07 PM

Change 462456 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2d668bdbb)

https://gerrit.wikimedia.org/r/462456

Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.Sep 24 2018, 6:08 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Sep 24 2018, 6:15 PM

Change 462464 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Separate node classes into individual files

https://gerrit.wikimedia.org/r/462464

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Sep 28 2018, 6:59 AM
• Deskana closed this task as Resolved.Sep 28 2018, 12:22 PM
• Deskana triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits