Almost all "Save" buttons have been relabeled to say "Publish" with T131132: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action. Two-Column-Edit-Conflict-Merge should do the same, I believe.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines /- | |
|---|---|---|---|---|
| Change "save" to "publish" everywhere | mediawiki/extensions/TwoColConflict | master | 8 -8 |
Related Objects
Related Objects
- Mentioned In
- T195724: Adapt Save-, Preview- and Cancel buttons to new version (No. 8)
rESCCc582ea2f74ab: Change "save" to "publish" everywhere
T202053: Update headers of the conflicting versions - Mentioned Here
- T131132: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action
Event Timeline
Comment Actions
Change 453108 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Change "save" to "publish" everywhere
Comment Actions
Change 453108 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Change "save" to "publish" everywhere
Comment Actions
We realized later that we might need to respect the $wgEditSubmitButtonLabelPublish setting in some (probably not all) of the situations changed in the patch above.
Comment Actions
I reviewed again what we have in our extension-specific https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/TwoColConflict/ /refs/heads/master/i18n/en.json. The word "publish" appears a few times, but always in the middle of a sentence. It would be terrible if we would have to duplicate all these messages. Core does this in a few situations, but this is very rare, and typically only done for button labels. For TwoColConflict I suggest to stick to "publish" for now.
However, we can probably avoid both "save" and "publish" in a few messages by rewording them to say "something was edited", for example.
The only exception is the "Simulate publish changes" button, which is – well – only for the simulation special page. The real page uses the original button, which already correctly says "Save" or "Publish" depending on the configuration. As above, I don't think it's worth it fiddling with this temporary special page.