Update [16/08]
Patch merged.
Update [08/08]
Originally in this tasks we had not considered subsections. Subsection issues required writing code to identify which section contents belongs to - much trickier than a 3 pointer. Some nitpicks on patches remain.
Background
In T191303: Mobile page issues - visual styling changes we noted that there are some issues with displaying section issues. This task is to clarify and apply the expected behavior
Acceptance criteria
- Continue displaying section issues on the page
- When a section issue is selected, only display issues from the given section in the page issues modal
- Perform full QA for section issues
- for the existing treatment, we should ensure we do not show section issues and do not show them inside the issues overlay when open (i.e. keep existing behaviour)
Testing steps
Group B
Ensure you have been bucketed in test group B (banner visible at top of Equity_release)
- Visit page https://reading-web-staging.wmflabs.org/wiki/Albert_Sidney_Johnston and open the "United States" section. There should be an issue banner with an orange circle icon. Click on that and make sure there's only one issue listed in the modal.
- Visit page https://reading-web-staging.wmflabs.org/wiki/Alberta and open the "Culture" section. There should be an issue banner with an orange circle icon. Click on that and make sure there's only one issue listed in the modal.
- Visit page https://reading-web-staging.wmflabs.org/wiki/Equity_release. This page has both a page issue and a section issue (in the "United States" section). Clicking the page issue at the top of the page should lead to a modal with only a description of that issue. Likewise for the section issue. Neither of the modals should contain descriptions of both issues.
- Visit https://reading-web-staging.wmflabs.org/wiki/Pharmacovigilance. This page has multiple page issues (3) as well as section issues (the first five sections each have an issue). Again click the issues and check the modal to make sure that only the issue descriptions pertaining to the respective issues are appearing. So each of the section issues should only display one issue in their modals.
- Check https://reading-web-staging.wmflabs.org/wiki/Category:Use_American_English_from_January_2014 and http://reading-web-staging.wmflabs.org/wiki/Talk:Pharmacovigilance — make sure they both show an "About this page" link under the title
Group A
- On Albert Sidney Johnston and Alberta "Page issues" gray text below page title should NOT show (current issues only displays for lead section). This should match what is currently in production.
- On Equity_release ensure "This page has issues" banner shows at top and only contains one issue relating to citations. This should match what is currently in production.
- On Pharmacovigilance ensure "This page has issues" banner shows at top and only contains three issues. This should match what is currently in production.
- Check "Category:Use_American_English_from_January_2014" and "Talk:Pharmacovigilance" show a link under the title. This should match what is currently in production.
developer notes
Right now we only extract issues from the first section. We will need to run this code on every section when the user is in the new treatment.
Right now the issues overlay is tied to the route #/issues. We will need to expand the route to #/issues/《sectionNum》to link overlays to their corresponding section. Should be relatively straightforward but may require storing an object which links section id to list of issues (right now we store section 0s issues in a local one dimensional array).
Note on desktop there is currently no concept of sections. Here it's probably best to show all issues inside a single overlay linked to from all issues in page. Dont worry too much about desktop Minerva. Long term the parser will have sections and this problem will go away.
