Maniphest T196289

Review a diff including Senses
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	• RazShuty
	Jun 3 2018, 11:30 AM

Description

Narrative:
As an editor of Wikidata-Lexeme I want to be able to review a diff including Senses to see what exactly was changed in an edit.

Screenshots/mockups:

How it should look like when changing a Gloss:

(analogous for adding and removing a Gloss)

For statement edits the breadcrumbs would be analogous to this diff on a Form: https://wikidata.beta.wmflabs.org/w/index.php?title=Lexeme:L1&diff=1045864&oldid=1045863

Acceptance criteria:

Any diff including a Sense is showing all the changes made in the edit

Personas to take into account:
Niels - Active editor on Wikidata
Alex - Data user in small startup

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T196288 Review Edits
Resolved	Ladsgroup	T196289 Review a diff including Senses
Resolved	Ladsgroup	T200795 Add SenseDiff interface and implementations
Resolved	Ladsgroup	T200797 Add SenseDiffer
Resolved	Ladsgroup	T200796 Add SenseDiffView
Resolved	Ladsgroup	T200798 Hook up diffing senses in wiring files
Resolved	Ladsgroup	T200812 Add SensePatcher

Event Timeline

• RazShuty created this task.Jun 3 2018, 11:30 AM

• RazShuty moved this task from incoming to features/bugs for next release (Senses) on the Wikidata Lexicographical data board.

• Vvjjkkii renamed this task from Review a diff including Senses to uqbaaaaaaa.Jul 1 2018, 1:06 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

CommunityTechBot renamed this task from uqbaaaaaaa to Review a diff including Senses.Jul 2 2018, 12:01 AM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Example: beta:Special:Diff/1041639 is a diff for an edit that added a sense. Currently, the diff is empty.

Lydia_Pintscher updated the task description. (Show Details)Jul 31 2018, 8:21 AM

Lydia_Pintscher updated the task description. (Show Details)Jul 31 2018, 8:24 AM

WMDE-leszek set the point value for this task to 8.Jul 31 2018, 11:19 AM

Lucas_Werkmeister_WMDE added a project: Wikidata-Senses-Iteration2.Jul 31 2018, 1:22 PM

Ladsgroup claimed this task.Jul 31 2018, 1:25 PM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 31 2018, 1:25 PM

Ladsgroup moved this task from To Do to Doing on the Wikidata-Senses-Iteration2 board.Jul 31 2018, 2:44 PM

Lucas_Werkmeister_WMDE closed subtask T200798: Hook up diffing senses in wiring files as Resolved.Aug 7 2018, 10:24 AM

Lucas_Werkmeister_WMDE closed subtask T200797: Add SenseDiffer as Resolved.

Lucas_Werkmeister_WMDE closed subtask T200795: Add SenseDiff interface and implementations as Resolved.

Lucas_Werkmeister_WMDE closed subtask T200796: Add SenseDiffView as Resolved.

Lucas_Werkmeister_WMDE closed subtask T200812: Add SensePatcher as Resolved.

This seems to be working. Some example edits:

Note that messages of some edits before T200817: Add language codes to sense edit summaries was deployed will have an empty language code (“[]”).

Lucas_Werkmeister_WMDE mentioned this in T196287: See changes with summary diff of new Sense on Recent Changes view.Aug 7 2018, 10:52 AM

\o/

	F24359823: Screenshot_20180731_101803.png
	Jul 31 2018, 8:21 AM

Review a diff including SensesClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Related ObjectsSearch...

Event Timeline

Review a diff including Senses
Closed, ResolvedPublic8 Estimated Story Points
Actions

Related Objects
Search...