Page MenuHomePhabricator
Create Task
Maniphest T196228

Lemmas widget: HTML validity
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Jakob_WMDE
Authored By
abian
Jun 2 2018, 3:05 PM
Tags
Referenced Files
F25750340: Bildschirmfoto von 2018-09-10 14-23-48.png
Sep 10 2018, 12:24 PM
F25750341: Bildschirmfoto von 2018-09-10 14-23-42.png
Sep 10 2018, 12:24 PM
Subscribers
abian
Addshore
gerritbot
KaMan
Lydia_Pintscher
• Pablo-WMDE
Tarrow

Description

The HTML structure of lexeme pages should contais only well-organized elements. Mediawiki provides us with a skeleton for most parts of the page. Amongst these is an HTML element for the primary title of a page, .firstHeading - being an h1 tag. Currently the lexeme page provides another h1 with invalid mark-up (not only phrasing content).

AC

  • the default mediawiki h1 contains all lemmas, well marked-up including language and directionality
  • the default mediawiki h1 is not visible
  • #wb-lexeme-header-lemmas uses a div instead of an h1 tag

Info

  • this was researched in T199081 - see when addressing the rendering of the lemmas into the default mediawiki h1
  • spike at https://gerrit.wikimedia.org/r/456571
  • The h1 in the Lexeme header also causes some styles to be applied (e.g. serif font) which will be resolved this way
  • lemma hyphenation is addressed in T203242

Details

SubjectRepoBranchLines /-
Render all lemmas in lexeme page h1mediawiki/extensions/WikibaseLexememaster 232 -232
LexemeView: no h1 for lexeme headermediawiki/extensions/WikibaseLexememaster 2 -2
LexemeView: no h1 for lexeme headermediawiki/extensions/WikibaseLexememaster 4 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJakob_WMDET196228 Lemmas widget: HTML validity
 ResolvedNoneT199081 [timebox 4h] Research implementation for lemma h1

Event Timeline

abian created this task.Jun 2 2018, 3:05 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJun 2 2018, 3:05 PM
Lydia_Pintscher moved this task from incoming to features/bugs for next release (editor experience improvements) on the Wikidata Lexicographical data board.Jun 3 2018, 6:12 PM
• Pablo-WMDE updated the task description. (Show Details)Jun 20 2018, 12:10 PM
• Pablo-WMDE mentioned this in T195298: [UI glitch] Representation widgets overlapping toolbar buttons when too many.Jun 22 2018, 7:27 AM
• Pablo-WMDE mentioned this in T197929: [UI glitch] Huge base font size distorts lemma widget in header.Jun 22 2018, 8:23 AM
• Vvjjkkii renamed this task from h1 should only contain phrasing content in Wikidata lexeme pages to jsbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
CommunityTechBot renamed this task from jsbaaaaaaa to h1 should only contain phrasing content in Wikidata lexeme pages.Jul 2 2018, 1:10 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
• Pablo-WMDE mentioned this in T199081: [timebox 4h] Research implementation for lemma h1.Jul 9 2018, 9:21 AM
Lydia_Pintscher added a subtask: T199081: [timebox 4h] Research implementation for lemma h1.Aug 7 2018, 8:20 AM
• Pablo-WMDE renamed this task from h1 should only contain phrasing content in Wikidata lexeme pages to Lemmas widget: HTML validity.Aug 31 2018, 12:19 PM
• Pablo-WMDE updated the task description. (Show Details)
• Pablo-WMDE subscribed.
gerritbot subscribed.Aug 31 2018, 12:20 PM

Change 456571 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LexemeView: no h1 for lexeme header

https://gerrit.wikimedia.org/r/456571

gerritbot added a project: Patch-For-Review.Aug 31 2018, 12:20 PM
• Pablo-WMDE mentioned this in rEWLE9f8f16ae9373: LexemeView: no h1 for lexeme header.Aug 31 2018, 12:23 PM
• Pablo-WMDE updated the task description. (Show Details)Aug 31 2018, 1:10 PM
• Pablo-WMDE set the point value for this task to 3.Sep 3 2018, 9:03 AM
• Pablo-WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration6.
• Pablo-WMDE added a subscriber: Wikidata-Editor-Experience-Improvements-Iteration6.
• Pablo-WMDE removed a subscriber: Wikidata-Editor-Experience-Improvements-Iteration6.
KaMan subscribed.Sep 4 2018, 8:39 AM

I'm not sure if this is related but there is another report about html of h1 and perhaps it can be solved together: https://www.wikidata.org/w/index.php?title=Wikidata_talk:Lexicographical_data&oldid=739634790#HTML_language_tags

• Pablo-WMDE added a comment.Sep 4 2018, 2:52 PM

@KaMan It will be, that's what the first AC is about. Thanks for the pointer.

• Pablo-WMDE closed subtask T199081: [timebox 4h] Research implementation for lemma h1 as Resolved.Sep 5 2018, 8:43 AM
Jakob_WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration7.Sep 5 2018, 9:23 AM
• Pablo-WMDE added a comment.Sep 5 2018, 10:12 AM

To make the "default mediawiki h1 contains all lemmas" we'll drop htmlTermRenderer and getMainTerm() from LexemeView and the logic in LexemeLinkFormatter::getLemmaHtml() will be exposed so that it can be used instead to render all lemmas and their correct attributes into it.

Jakob_WMDE claimed this task.Sep 6 2018, 9:56 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration7 board.
Jakob_WMDE mentioned this in rEWLE0737f627147c: LexemeView: no h1 for lexeme header.Sep 6 2018, 11:04 AM
gerritbot added a comment.Sep 6 2018, 12:24 PM

Change 456571 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] LexemeView: no h1 for lexeme header

https://gerrit.wikimedia.org/r/456571

gerritbot added a comment.Sep 6 2018, 12:43 PM

Change 458493 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LexemeView: no h1 for lexeme header

https://gerrit.wikimedia.org/r/458493

• Pablo-WMDE mentioned this in rEWLEc856a7a48da9: LexemeView: no h1 for lexeme header.Sep 6 2018, 12:47 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 6 2018, 1:00 PM
gerritbot added a comment.Sep 6 2018, 1:39 PM

Change 458505 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Render all lemmas in lexeme page h1

https://gerrit.wikimedia.org/r/458505

Jakob_WMDE mentioned this in rEWLE3db5ca957fae: Render all lemmas in lexeme page h1.Sep 6 2018, 1:41 PM
Jakob_WMDE mentioned this in rEWLE147bdfa60651: Render all lemmas in lexeme page h1.Sep 6 2018, 1:53 PM
gerritbot added a comment.Sep 6 2018, 1:55 PM

Change 458493 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] LexemeView: no h1 for lexeme header

https://gerrit.wikimedia.org/r/458493

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration7 board.Sep 6 2018, 3:28 PM
Jakob_WMDE mentioned this in rEWLE2913ba903aea: Render all lemmas in lexeme page h1.Sep 10 2018, 9:29 AM
Jakob_WMDE mentioned this in rEWLEbefae5a96106: Render all lemmas in lexeme page h1.Sep 10 2018, 9:50 AM
Jakob_WMDE mentioned this in rEWLEe12873f9d502: Render all lemmas in lexeme page h1.Sep 10 2018, 10:39 AM
Tarrow subscribed.Sep 10 2018, 10:43 AM

The failing browser test of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/ /458505 does seem to be a real problem:

Stack Trace from Special recent changes.

[c9365c8e6c9f4fb89869aeb5] /mediawiki/index.php?title=Special:RecentChanges TypeError from line 49 of /var/www/mediawiki/extensions/WikibaseLexeme/src/Hooks/Formatters/LexemeLinkFormatter.php: Argument 4 passed to Wikibase\Lexeme\Hooks\Formatters\LexemeLinkFormatter::__construct() must be an instance of Language, instance of RequestContext given, called in /var/www/mediawiki/extensions/WikibaseLexeme/WikibaseLexeme.entitytypes.repo.php on line 288

Backtrace:

#0 /var/www/mediawiki/extensions/WikibaseLexeme/WikibaseLexeme.entitytypes.repo.php(288): Wikibase\Lexeme\Hooks\Formatters\LexemeLinkFormatter->__construct(Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup, Wikibase\Repo\Hooks\Formatters\DefaultEntityLinkFormatter, Wikibase\Lexeme\Formatters\LexemeTermFormatter, RequestContext, Language)
#1 /var/www/mediawiki/extensions/Wikibase/repo/includes/Hooks/Formatters/EntityLinkFormatterFactory.php(72): Wikibase\Lexeme\WikibaseLexemeHooks::{closure}(Language)
#2 /var/www/mediawiki/extensions/Wikibase/repo/includes/Hooks/Formatters/EntityLinkFormatterFactory.php(64): Wikibase\Repo\Hooks\Formatters\EntityLinkFormatterFactory->createAndCacheLinkFormatter(string)
#3 /var/www/mediawiki/extensions/Wikibase/repo/includes/Hooks/Formatters/EntityLinkFormatterFactory.php(52): Wikibase\Repo\Hooks\Formatters\EntityLinkFormatterFactory->getOrCreateLinkFormatter(string)
#4 /var/www/mediawiki/extensions/Wikibase/repo/includes/Hooks/HtmlPageLinkRendererBeginHookHandler.php(252): Wikibase\Repo\Hooks\Formatters\EntityLinkFormatterFactory->getLinkFormatter(string)
#5 /var/www/mediawiki/extensions/Wikibase/repo/includes/Hooks/HtmlPageLinkRendererBeginHookHandler.php(140): Wikibase\Repo\Hooks\HtmlPageLinkRendererBeginHookHandler->doHtmlPageLinkRendererBegin(MediaWiki\Linker\LinkRenderer, Title, NULL, array, RequestContext, NULL)
#6 /var/www/mediawiki/includes/Hooks.php(174): Wikibase\Repo\Hooks\HtmlPageLinkRendererBeginHookHandler::onHtmlPageLinkRendererBegin(MediaWiki\Linker\LinkRenderer, Title, NULL, array, array, NULL)
#7 /var/www/mediawiki/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#8 /var/www/mediawiki/includes/linker/LinkRenderer.php(180): Hooks::run(string, array)
#9 /var/www/mediawiki/includes/linker/LinkRenderer.php(251): MediaWiki\Linker\LinkRenderer->runBeginHook(Title, NULL, array, array, boolean)
#10 /var/www/mediawiki/includes/linker/LinkRenderer.php(298): MediaWiki\Linker\LinkRenderer->makePreloadedLink(Title, NULL, string, array, array)
#11 /var/www/mediawiki/includes/changes/RCCacheEntryFactory.php(129): MediaWiki\Linker\LinkRenderer->makeKnownLink(Title)
#12 /var/www/mediawiki/includes/changes/RCCacheEntryFactory.php(68): RCCacheEntryFactory->buildCLink(RCCacheEntry)
#13 /var/www/mediawiki/includes/changes/EnhancedChangesList.php(119): RCCacheEntryFactory->newFromRecentChange(RecentChange, boolean)
#14 /var/www/mediawiki/includes/specials/SpecialRecentchanges.php(453): EnhancedChangesList->recentChangesLine(RecentChange, boolean, integer)
#15 /var/www/mediawiki/includes/specialpage/ChangesListSpecialPage.php(1610): SpecialRecentChanges->outputChangesList(Wikimedia\Rdbms\ResultWrapper, FormOptions)
#16 /var/www/mediawiki/includes/specialpage/ChangesListSpecialPage.php(675): ChangesListSpecialPage->webOutput(Wikimedia\Rdbms\ResultWrapper, FormOptions)
#17 /var/www/mediawiki/includes/specials/SpecialRecentchanges.php(167): ChangesListSpecialPage->execute(NULL)
#18 /var/www/mediawiki/includes/specialpage/SpecialPage.php(569): SpecialRecentChanges->execute(NULL)
#19 /var/www/mediawiki/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#20 /var/www/mediawiki/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#21 /var/www/mediawiki/includes/MediaWiki.php(868): MediaWiki->performRequest()
#22 /var/www/mediawiki/includes/MediaWiki.php(525): MediaWiki->main()
#23 /var/www/mediawiki/index.php(42): MediaWiki->run()
#24 {main}
• Pablo-WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration7 board.EditedSep 10 2018, 11:21 AM

To be seen on beta. Validator result:

Bildschirmfoto von 2018-09-10 14-23-42.png (965×877 px, 127 KB)
Bildschirmfoto von 2018-09-10 14-23-48.png (965×877 px, 100 KB)

gerritbot added a comment.Sep 10 2018, 11:30 AM

Change 458505 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Render all lemmas in lexeme page h1

https://gerrit.wikimedia.org/r/458505

• Pablo-WMDE added a subscriber: Addshore.Sep 10 2018, 2:02 PM

This does require a purge of page caches to come to full fruition in production. Not functionally critically, though. /cc @Addshore

Lydia_Pintscher closed this task as Resolved.Sep 16 2018, 10:41 AM
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Editor-Experience-Improvements-Iteration7 board.
Lydia_Pintscher subscribed.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits