We have DOMComplete in WebPageTest but we don't send it to Graphite. Let us add it so we can follow changes when we do the Resource Loader 2018 review.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Krinkle | T127328 Optimise critical rendering path | |||
| Resolved | Krinkle | T192623 ResourceLoader 2018 Review | |||
| Resolved | Peter | T193719 Pick up DOMComplete and send to Graphite |
Event Timeline
Comment Actions
Change 430569 had a related patch set uploaded (by Phedenskog; owner: Phedenskog):
[performance/WebPageTest@master] Collect domContentLoadedEventEnd
Comment Actions
Change 430569 merged by jenkins-bot:
[performance/WebPageTest@master] Collect DOMComplete.
Comment Actions
Change 439654 had a related patch set uploaded (by Phedenskog; owner: Phedenskog):
[performance/WebPageTest@master] Rollback DOMComplete.
Comment Actions
Reopening since this is rollbacked in https://gerrit.wikimedia.org/r/#/c/performance/WebPageTest/ /439654/
Somehow this broke sending a lot of other metrics to Graphite. Lets make sure we log the full URL in Jenkins in step 1 so it's easier to just see the problem.
Comment Actions
Change 439654 merged by jenkins-bot:
[performance/WebPageTest@master] Rollback DOMComplete.
Comment Actions
So the message looked like this:
webpagetest.enwiki.anonymous.Facebook.us-east.Chrome.firstView.domComplete=2494.5999999982ms&
I've changed so WebPageTest parse it to an int.
Comment Actions
Change 441216 had a related patch set uploaded (by Phedenskog; owner: Phedenskog):
[performance/WebPageTest@master] Enable pick up DOMComplete.
Comment Actions
Change 441216 merged by jenkins-bot:
[performance/WebPageTest@master] Enable pick up DOMComplete.