Maniphest T193480

External link icon is cut off in the "Insert link" box
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Srdjan
	May 1 2018, 10:54 AM

Description

Steps to reproduce

Open any page in the source editor (for example, https://en.wikipedia.org/w/index.php?title=Moonlight_(2016_film)&action=edit )
Click on the link icon in the toolbar to open the "Insert link" box
Click on the radio button labelled "To an external web page"

Expected

The external link icon to the right of "Target page or URL" should be shown in its entirety.

Actual

The external link icon is cut off.

Details

	Subject	Repo	Branch	Lines /-
	LinkDialog: fix size of background image	mediawiki/extensions/WikiEditor	master	1 -0

Customize query in gerrit

Event Timeline

Srdjan created this task.May 1 2018, 10:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2018, 10:54 AM

Srdjan added a project: MediaWiki-General.May 1 2018, 10:55 AM

Aklapper edited projects, added MediaWiki-Page-editing; removed MediaWiki-General.May 1 2018, 3:07 PM

Thanks for reporting this.
Seems to be defined in WikiEditor (2010):

#wikieditor-toolbar-link-int-target-status-external {
	padding-left: 30px;
	background-position: 0 50%;
	background-repeat: no-repeat;
	.background-image('images/dialogs/insert-link-external.png');
	background-position: left;
}

• Vvjjkkii renamed this task from External link icon is cut off in the "Insert link" box to vwdaaaaaaa.Jul 1 2018, 1:13 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from vwdaaaaaaa to External link icon is cut off in the "Insert link" box.Jul 1 2018, 1:49 PM

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

CommunityTechBot raised the priority of this task from High to Needs Triage.Jul 3 2018, 1:53 AM

Change 473634 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/WikiEditor@master] LinkDialog: fix size of background image

https://gerrit.wikimedia.org/r/473634

gerritbot added a project: Patch-For-Review.Nov 14 2018, 10:19 PM

Change 473634 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] LinkDialog: fix size of background image

https://gerrit.wikimedia.org/r/473634

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 14 2018, 11:00 PM

matmarex closed this task as Resolved.Nov 14 2018, 11:12 PM

matmarex assigned this task to TheDJ.

matmarex removed a project: Patch-For-Review.

TheDJ moved this task from Backlog to Closed on the WikiEditor (2010) board.Nov 27 2018, 1:47 PM

	F17485925: insert link - external link icon.png
	May 1 2018, 10:54 AM

External link icon is cut off in the "Insert link" boxClosed, ResolvedPublicActions