Page MenuHomePhabricator
Create Task
Maniphest T192601

AuthorityControl sometimes removes Commons media statement values since wmf.30
Closed, ResolvedPublic
Actions

Description

Since the deployment of the wmf.30 branch to Wikidata (which includes T46727: [Story] Statement should show a thumbnail for image/video/audio properties), with the AuthorityControl gadget enabled values for “Commons media” statements sometimes disappear entirely a short time after loading the entity.

DbLIuyhW4AAZuXF.jpg:large.jpeg (518×912 px, 35 KB)

This happens only some of the time (probably some kind of race condition), but I can reproduce it fairly reliably after some reloads with the AuthorityControl gadget enabled (in different accounts), and not at all with the gadget disabled.

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 19 2018, 9:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2018, 9:11 PM
hoo added a comment.Apr 19 2018, 11:14 PM

I fixed something very similar in the commons media gadget: https://www.wikidata.org/w/index.php?diff=667100296&oldid=370730384

Are we sure this is another issue?

Lea_Lacroix_WMDE subscribed.Apr 24 2018, 10:29 AM

FYI I disabled AuthorityControl, but the issue still randomly happens. I could find if it follows a pattern or not, so the bug is difficult to track.

WMDE-leszek added a project: Wikidata-Ministry-Of-Magic.Apr 24 2018, 1:27 PM
WMDE-leszek moved this task from Tasks to User Stories on the Wikidata-Ministry-Of-Magic board.
WMDE-leszek mentioned this in T192910: Investigate why AuthorityControl sometimes removes Commons media statement.Apr 24 2018, 1:56 PM
hoo closed this task as Resolved.Apr 24 2018, 3:04 PM
hoo claimed this task.
hoo moved this task from User Stories to Test (Product Review) on the Wikidata-Ministry-Of-Magic board.

To keep it short: The gadget always mangles/ re-does the html for all string-value snaks with a formatter URL set on the property (except for external ids that are already handled). As P18 (and others) have a formatter URL set, the gadget tries to re-do their html, which results in the reported problems.

Fixed: https://www.wikidata.org/w/index.php?diff=668951347&oldid=667850658 (please note that this might need some time to propagate due to caching)

Note: If someone were to set a formatter URL on a math-property the same would happen there :/

hoo closed subtask T192910: Investigate why AuthorityControl sometimes removes Commons media statement as Resolved.Apr 24 2018, 3:05 PM
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Ministry-Of-Magic board.May 2 2018, 8:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits