Page MenuHomePhabricator

Add regex functionality to User Agent IP blocks
Closed, DeclinedPublic

Description

We're building T100070: Allow CheckUsers to set User agent (UA)-based IP Blocks and there is a strong use case to allow CheckUsers to provide regular expressions in the User Agent field.

Event Timeline

TBolliger created this task.

FWIW, I have serious doubts about the use case here. The only rationale I could see for regex based UA blocking is to block someone who uses a browser that regularly auto-updates (The version number changes, reset of UA stays the same). If they are doing that, then they are almost certainly using a popular browser, and blocking based on user-agent is going to have massive collateral damage.

As user agent based blocking is only allowed in combination with ip r(ange) blocking, the collateral damage shouldn't be really large.

As user agent based blocking is only allowed in combination with ip r(ange) blocking, the collateral damage shouldn't be really large.

👍

My only concern is that regex isn't very user fridley/forgiving. I suppose we could at least have some sort of client-side syntax checker.

Cleaning our backlog of indefinitely unprioritized projects.

Should solve T100070 before re-opening or reconsidering.