Page MenuHomePhabricator
Create Task
Maniphest T174038

Initial implementation of MCR page update interface
Closed, ResolvedPublic
Actions

Description

This ticket covers the implementation of a mechanism for creating new page revisions with multiple content objects.

The functionality provided is roughly equivalent to the doEditContent functionality offered by the WikiPage class. The WikiPage class should remain a thin layer on top of the new page update interface, as a legacy proxy.

Design draft: https://www.mediawiki.org/wiki/Multi-Content_Revisions/Page_Update_Controller

Details

SubjectRepoBranchLines /-
[MCR][EXP] Move RevisionRecord creation into DerivedPageDataUpdater.mediawiki/coremaster 72 -43
[MCR] Factor PageUpdater out of WikiPagemediawiki/coremaster 5 K -740
[MCR] Introduce RevisionSlotsUpdate.mediawiki/coremaster 782 -32
[WIP][MCR] Replace WikiPage::doEditContentmediawiki/coremaster 65 -54
[MCR] Prepare PreparedEdit for MCRmediawiki/coremaster 532 -89
[MCR][WIP] Factor PageUpdater out of WikiPagemediawiki/coremaster 3 K -709
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
daniel created subtask T174039: Implement MCR page update legacy version.Aug 24 2017, 2:55 PM
daniel added subtasks: T174026: Implement MCR content meta-data storage service, T174030: Implement DB schema migration tools for MCR.
daniel added subtasks: T161671: Compacting the revision table, T166732: Refactor comment storage in the database and abstract access in MediaWiki.
daniel updated the task description. (Show Details)Aug 25 2017, 4:04 PM
daniel updated the task description. (Show Details)
Anomie closed subtask T166732: Refactor comment storage in the database and abstract access in MediaWiki as Resolved.Sep 7 2017, 1:35 PM
CCicalese_WMF moved this task from Inbox to MWPT-Q2-Oct-Dec-2017 on the MediaWiki-Platform-Team-Archived board.Oct 13 2017, 6:55 PM
CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q2-Oct-Dec-2017); removed MediaWiki-Platform-Team-Archived.
• Ramsey-WMF moved this task from Backlog to Continuous tasks / Epics on the SDC General board.Nov 17 2017, 5:37 PM
daniel added a subtask: T180989: Improve Test Coverage for WikiPage class.Nov 20 2017, 7:28 PM
daniel added a project: Multi-Content-Revisions.
Addshore closed subtask T180989: Improve Test Coverage for WikiPage class as Resolved.Dec 7 2017, 6:54 PM
Addshore reopened subtask T180989: Improve Test Coverage for WikiPage class as Open.
thiemowmde triaged this task as Medium priority.Dec 11 2017, 4:06 PM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Dec 18 2017, 3:12 PM
CCicalese_WMF moved this task from MWPT-Q2-Oct-Dec-2017 to MWPT-Q3-Jan-Mar-2018 on the MediaWiki-Platform-Team-Archived board.Dec 21 2017, 4:19 PM
CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018); removed MediaWiki-Platform-Team-Archived (MWPT-Q2-Oct-Dec-2017).
daniel removed a subtask: T161671: Compacting the revision table.Dec 21 2017, 7:04 PM
CCicalese_WMF moved this task from MWPT-Q3-Jan-Mar-2018 to Watching on the MediaWiki-Platform-Team-Archived board.Jan 2 2018, 4:09 PM
CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived; removed MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018).
daniel added a subtask: T174024: Implement MCR revision retrieval interface.Jan 4 2018, 6:51 PM
Addshore closed subtask T180989: Improve Test Coverage for WikiPage class as Resolved.Jan 5 2018, 10:37 AM
gerritbot subscribed.Mar 8 2018, 7:02 PM

Change 406388 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [MCR] Prepare PreparedEdit for MCR

https://gerrit.wikimedia.org/r/406388

gerritbot added a project: Patch-For-Review.Mar 8 2018, 7:02 PM
gerritbot added a comment.Mar 15 2018, 5:28 PM

Change 419803 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [MCR][WIP] First basic refactoring step for WikiPage

https://gerrit.wikimedia.org/r/419803

daniel added a subtask: T190063: Tracking dependencies for multiple Content objects per page (MCR).Mar 19 2018, 4:00 PM
gerritbot added a comment.Mar 19 2018, 8:47 PM

Change 406388 abandoned by Daniel Kinzler:
[MCR] Prepare PreparedEdit for MCR

Reason:
merged this into If610c68f4912e89af616cdcac1d35a1be3946afa

https://gerrit.wikimedia.org/r/406388

gerritbot added a comment.Mar 30 2018, 11:31 AM

Change 423146 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Introduce RevisionSlotsUpdate.

https://gerrit.wikimedia.org/r/423146

daniel mentioned this in T174039: Implement MCR page update legacy version.Apr 19 2018, 4:57 PM
daniel closed subtask T174039: Implement MCR page update legacy version as Invalid.
daniel mentioned this in T192777: Do not use Content::prepareSave when importing or undeleting (drop hard global constraints).Apr 23 2018, 1:05 PM
daniel moved this task from Inbox to Done on the Multi-Content-Revisions board.May 7 2018, 10:39 AM
daniel claimed this task.May 7 2018, 10:49 AM
gerritbot added a comment.May 7 2018, 12:42 PM

Change 421433 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [WIP][MCR] Replace WikiPage::doEditContent

https://gerrit.wikimedia.org/r/421433

daniel added a subtask: T194037: Track dependencies for multiple Content objects per page.May 7 2018, 12:51 PM
CCicalese_WMF moved this task from Done to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 8 2018, 12:55 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.
CCicalese_WMF moved this task from Backlog to In Progress on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 8 2018, 1:06 PM
gerritbot added a comment.May 9 2018, 1:27 PM

Change 423146 merged by jenkins-bot:
[mediawiki/core@master] [MCR] Introduce RevisionSlotsUpdate.

https://gerrit.wikimedia.org/r/423146

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)).May 9 2018, 2:00 PM
daniel mentioned this in T194429: Remove the need to generate ParserOutput before PageContentSave hook is called.May 14 2018, 7:59 AM
daniel mentioned this in T194729: Allow Wikibase Entities to be stored in alternative slots [MCR].May 15 2018, 8:38 AM
daniel removed a subtask: T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles..May 15 2018, 11:33 AM
CCicalese_WMF moved this task from In Progress to Blocked on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 15 2018, 3:07 PM
CCicalese_WMF subscribed.

Waiting for testing.

daniel mentioned this in T195069: Factor PageStore and PageRecord out of WikiPage.May 19 2018, 2:24 PM
gerritbot added a comment.May 24 2018, 9:42 AM

Change 434183 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [MCR] Move RevisionRecord creation into DerivedPageDataUpdater.

https://gerrit.wikimedia.org/r/434183

daniel added a parent task: T194729: Allow Wikibase Entities to be stored in alternative slots [MCR].May 29 2018, 4:36 PM
CCicalese_WMF added a subtask: T180210: Improve test coverage for Revision class.May 31 2018, 2:38 AM
CCicalese_WMF renamed this task from Implement MCR page update interface to Initial implementation of MCR page update interface.May 31 2018, 5:22 PM
CCicalese_WMF edited parent tasks, added: T196087: Refactored implementation of MCR page update interface; removed: T174023: Implement MCR storage layer.
CCicalese_WMF removed a subtask: T192307: Provide MCR-aware hook points.May 31 2018, 6:14 PM
CCicalese_WMF removed a subtask: T194042: Replace usages of WikiPage::prepareContentForEdit.
CCicalese_WMF removed a subtask: T194037: Track dependencies for multiple Content objects per page.
CCicalese_WMF added a parent task: T174023: Implement MCR storage layer.May 31 2018, 6:38 PM
CCicalese_WMF removed a parent task: T174023: Implement MCR storage layer.
CCicalese_WMF added a subtask: T196653: Test MCR Storage Layer Patches.Jun 7 2018, 5:30 PM
gerritbot added a comment.Jun 14 2018, 1:35 PM

Change 405015 merged by jenkins-bot:
[mediawiki/core@master] [MCR] Factor PageUpdater out of WikiPage

https://gerrit.wikimedia.org/r/405015

daniel closed this task as Resolved.Jun 14 2018, 1:39 PM

\o/

daniel closed subtask T174024: Implement MCR revision retrieval interface as Resolved.Jun 14 2018, 3:58 PM
daniel closed subtask T196653: Test MCR Storage Layer Patches as Resolved.
CCicalese_WMF moved this task from Blocked to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jun 15 2018, 3:35 AM
daniel removed a subtask: T194043: Replace usages of Content::getSecondaryDataUpdates.Jun 15 2018, 11:31 AM
daniel removed a subtask: T194034: Make rollback inherit all slots from the target version.Jun 15 2018, 11:35 AM
daniel mentioned this in T194043: Replace usages of Content::getSecondaryDataUpdates.Jun 18 2018, 5:00 PM
daniel reopened this task as Open.Jun 19 2018, 1:36 PM

Reopening until T193690: RFC: How should we fix the undeletion system? is resolved.

daniel removed a subtask: T190063: Tracking dependencies for multiple Content objects per page (MCR).Jun 19 2018, 5:40 PM
daniel closed subtask T174030: Implement DB schema migration tools for MCR as Resolved.Jun 20 2018, 5:30 PM
• Fjalapeno moved this task from Done to Blocked on Review on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jun 21 2018, 4:40 PM
daniel closed this task as Resolved.Jun 22 2018, 3:40 PM
daniel closed subtask T197685: Clarify semantics of "base revision" and "parent revision" in EditPage, WikiPage, and PageUpdater as Resolved.

With T197685 resolved, this can no be closed again.

daniel mentioned this in T198075: Factoring page update logic out of WikiPage.Jun 25 2018, 10:16 AM
CCicalese_WMF moved this task from Blocked on Review to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jun 26 2018, 4:24 AM
• Vvjjkkii reopened subtask T197685: Clarify semantics of "base revision" and "parent revision" in EditPage, WikiPage, and PageUpdater as Open.Jul 1 2018, 1:02 AM
• Vvjjkkii reopened subtask T196653: Test MCR Storage Layer Patches as Open.Jul 1 2018, 1:05 AM
CommunityTechBot closed subtask T197685: Clarify semantics of "base revision" and "parent revision" in EditPage, WikiPage, and PageUpdater as Resolved.Jul 2 2018, 11:47 AM
CommunityTechBot closed subtask T196653: Test MCR Storage Layer Patches as Resolved.Jul 2 2018, 1:29 PM
CCicalese_WMF removed a project: Patch-For-Review.Jul 10 2018, 3:24 AM
CCicalese_WMF removed a project: MediaWiki-Platform-Team-Archived.Jul 12 2018, 12:45 AM
Krinkle mentioned this in T205464: Flaky unit test "DerivedPageDataUpdaterTest::testGetPreparedEditAfterPrepareUpdate".Sep 25 2018, 5:49 PM
gerritbot added a comment.Sep 28 2018, 3:41 PM

Change 434183 abandoned by Daniel Kinzler:
[MCR][EXP] Move RevisionRecord creation into DerivedPageDataUpdater.

https://gerrit.wikimedia.org/r/434183

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits