Add snak hashes to entity HTML output
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Jul 26 2017, 11:26 AM

Description

To make snaks of any kind identifiable in the DOM, we should add their IDs / hashes to the HTML, as classes (not as element id: one snak can appear several times in the same entity). This is required for T168532: Check constraints on qualifiers and references.

This slightly increases the page size, but not excessively: even for large entities, the increase is only slightly above 5%, and typical entities seem to grow by 1-3% (see gist).

Details

	Subject	Repo	Branch	Lines /-
	Add snak hashes to entity HTML	mediawiki/extensions/Wikibase	master	28 -5
	Propagate statementview changes to subwidgets	mediawiki/extensions/Wikibase	master	17 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lucas_Werkmeister_WMDE	T173695 Enable constraint checks by default for users
Resolved	Lucas_Werkmeister_WMDE	T168532 Check constraints on qualifiers and references
Resolved	Lucas_Werkmeister_WMDE	T171725 Add snak hashes to entity HTML output
Resolved	thiemowmde	T171607 Main snak and reference snaks do not include hash in JSON output
Resolved	Lucas_Werkmeister_WMDE	T174011 Add snak IDs (hashes) to wikibase-datamodel-javascript
Resolved	Lucas_Werkmeister_WMDE	T176604 Snak hashes for qualifiers and references missing in entity HTML after statement save
Resolved	Lucas_Werkmeister_WMDE	T176633 Saved snaks have wikibase-snakview- class

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 26 2017, 11:26 AM

Restricted Application added subscribers: PokestarFan, Aklapper. · View Herald TranscriptJul 26 2017, 11:26 AM

The PHP side of this is easy, but it looks like the JS side of this will require T171607: Main snak and reference snaks do not include hash in JSON output (including for wbsetclaim and similar API actions).

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 26 2017, 12:03 PM

Lucas_Werkmeister_WMDE mentioned this in T171607: Main snak and reference snaks do not include hash in JSON output.Jul 27 2017, 2:28 PM

Lucas_Werkmeister_WMDE added a parent task: T168532: Check constraints on qualifiers and references.Aug 24 2017, 10:55 AM

Lucas_Werkmeister_WMDE added a subtask: T171607: Main snak and reference snaks do not include hash in JSON output.

Lucas_Werkmeister_WMDE mentioned this in T174011: Add snak IDs (hashes) to wikibase-datamodel-javascript.Aug 24 2017, 12:00 PM

Lucas_Werkmeister_WMDE created subtask T174011: Add snak IDs (hashes) to wikibase-datamodel-javascript.

Change 373858 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Propagate statementview changes to subwidgets

https://gerrit.wikimedia.org/r/373858

Change 373860 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add snak hashes to entity HTML

https://gerrit.wikimedia.org/r/373860

Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.Aug 25 2017, 10:27 AM

Lucas_Werkmeister_WMDE added a project: Wikidata-Former-Sprint-Board.

Lucas_Werkmeister_WMDE moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.

Change 373858 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Propagate statementview changes to subwidgets

https://gerrit.wikimedia.org/r/373858

Lucas_Werkmeister_WMDE renamed this task from Add snak IDs to entity HTML output to Add snak hashes to entity HTML output.Aug 31 2017, 4:03 PM

Lucas_Werkmeister_WMDE mentioned this in T174692: Announce changes regarding inclusion of snak hashes.Aug 31 2017, 4:07 PM

thiemowmde closed subtask T174011: Add snak IDs (hashes) to wikibase-datamodel-javascript as Resolved.Sep 4 2017, 10:45 AM

Change 373860 merged by Thiemo Mättig (WMDE):
[mediawiki/extensions/Wikibase@master] Add snak hashes to entity HTML

https://gerrit.wikimedia.org/r/373860

thiemowmde closed this task as Resolved.Sep 4 2017, 12:45 PM