Page MenuHomePhabricator
Create Task
Maniphest T162630

'Wikidata edits' filter with 'Contribution quality prediction' or 'User intent prediction' returns results but the filter selection displayed as a conflict
Closed, ResolvedPublic
Actions

Description

  1. On plwiki, select 'Wikidata edits' and one of conflicting filters: 'Contribution quality prediction' or 'User intent prediction' .
  2. The selected filters will be displayed in red and with the correct warning tooltip, but the results will be displayed. Event highlighting will work, marking some records as being in conflicting categories.

Screen Shot 2017-04-10 at 12.40.45 PM.png (599×836 px, 212 KB)

Screen Shot 2017-04-10 at 12.39.36 PM.png (565×758 px, 163 KB)

Details

SubjectRepoBranchLines /-
ChangesListStringOptionsFilter: Make isSelected() respect ALLmediawiki/coremaster 6 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Apr 10 2017, 8:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2017, 8:18 PM
Etonkovidova renamed this task from 'Wikidata edits' filter with 'Contribution quality prediction' or 'User intent prediction' returns results but the filter selection displayed as conflicting states to 'Wikidata edits' filter with 'Contribution quality prediction' or 'User intent prediction' returns but the filter selection displayed as a conflict.Apr 10 2017, 8:18 PM
Etonkovidova renamed this task from 'Wikidata edits' filter with 'Contribution quality prediction' or 'User intent prediction' returns but the filter selection displayed as a conflict to 'Wikidata edits' filter with 'Contribution quality prediction' or 'User intent prediction' returns results but the filter selection displayed as a conflict.
Etonkovidova added a parent task: T159787: Add Wikidata to new RC Filters UI.Apr 10 2017, 8:54 PM
Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Apr 10 2017, 11:46 PM
• Mattflaschen-WMF claimed this task.Apr 12 2017, 11:22 PM
• Mattflaschen-WMF subscribed.

We should explicitly exclude RC_EXTERNAL, since it will trigger a false match due to https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/client/includes/RecentChanges/RecentChangeFactory.php;5023d440478a34e76a10d6a9458044a9f1a7d2cb$150 .

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).Jul 12 2017, 10:00 PM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 12 2017, 10:25 PM
Catrope moved this task from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 13 2017, 5:25 PM
Catrope subscribed.

Since we now short-circuit all conflict states, the bug as written no longer occurs. If you select that particular combination of filters, no results are shown.

Catrope mentioned this in T159787: Add Wikidata to new RC Filters UI.Jul 14 2017, 9:45 PM
• jmatazzoni mentioned this in T170501: Graduate 'New filters for edit review' out of beta, making it standard on all wikis.Jul 14 2017, 9:50 PM
• jmatazzoni mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).Jul 17 2017, 8:53 PM
Etonkovidova added a comment.Jul 17 2017, 11:22 PM

Checked with plwiki - 'Wikidata' with full coverage in 'Contribution quality prediction' or 'User intent prediction' (when all options are selected) will still return the results.

gerritbot subscribed.Jul 17 2017, 11:54 PM

Change 365878 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] ChangesListStringOptionsFilter: Make isSelected() respect ALL

https://gerrit.wikimedia.org/r/365878

gerritbot added a project: Patch-For-Review.Jul 17 2017, 11:54 PM
Catrope added a comment.Jul 17 2017, 11:55 PM
In T162630#3446746, @Etonkovidova wrote:

Checked with plwiki - 'Wikidata' with full coverage in 'Contribution quality prediction' or 'User intent prediction' (when all options are selected) will still return the results.

It turned out that selecting all filters in the ORES group along with the Wikidata filter was detected as a conflict by the UI but not by the backend, and so the query wasn't short-circuited. The patch I just uploaded fixes that.

gerritbot added a comment.Jul 18 2017, 12:28 PM

Change 365878 merged by jenkins-bot:
[mediawiki/core@master] ChangesListStringOptionsFilter: Make isSelected() respect ALL

https://gerrit.wikimedia.org/r/365878

ReleaseTaggerBot added a project: MW-1.30-release-notes.Jul 18 2017, 1:00 PM
Etonkovidova added a comment.Jul 20 2017, 9:12 PM

Checked in 1.30.0-wmf.10 (enwiki, plwiki)

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 20 2017, 9:12 PM
• Mattflaschen-WMF reassigned this task from • Mattflaschen-WMF to Catrope.Jul 20 2017, 9:38 PM
• jmatazzoni mentioned this in T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis.Jul 21 2017, 7:26 PM
• jmatazzoni added a parent task: T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis.Jul 21 2017, 7:34 PM
• jmatazzoni closed this task as Resolved.Jul 28 2017, 8:43 PM
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 28 2017, 8:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits