- On plwiki, select 'Wikidata edits' and one of conflicting filters: 'Contribution quality prediction' or 'User intent prediction' .
- The selected filters will be displayed in red and with the correct warning tooltip, but the results will be displayed. Event highlighting will work, marking some records as being in conflicting categories.
Description
Details
Subject | Repo | Branch | Lines /- | |
---|---|---|---|---|
ChangesListStringOptionsFilter: Make isSelected() respect ALL | mediawiki/core | master | 6 -4 |
Event Timeline
We should explicitly exclude RC_EXTERNAL, since it will trigger a false match due to https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/client/includes/RecentChanges/RecentChangeFactory.php;5023d440478a34e76a10d6a9458044a9f1a7d2cb$150 .
Since we now short-circuit all conflict states, the bug as written no longer occurs. If you select that particular combination of filters, no results are shown.
Checked with plwiki - 'Wikidata' with full coverage in 'Contribution quality prediction' or 'User intent prediction' (when all options are selected) will still return the results.
Change 365878 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] ChangesListStringOptionsFilter: Make isSelected() respect ALL
It turned out that selecting all filters in the ORES group along with the Wikidata filter was detected as a conflict by the UI but not by the backend, and so the query wasn't short-circuited. The patch I just uploaded fixes that.
Change 365878 merged by jenkins-bot:
[mediawiki/core@master] ChangesListStringOptionsFilter: Make isSelected() respect ALL