Removing and inserting table cells breaks diff
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Feb 19 2017, 10:14 PM

Description

In T158294#3037198, @Esanders wrote:

Remove the last column, then insert a new row in the middle (zxy):

	Subject	Repo	Branch	Lines /-
	Update VE core submodule to master (41134af2b)	mediawiki/extensions/VisualEditor	master	4 -4
	Generalize DiffElement logic (improves lists and tables)	VisualEditor/VisualEditor	master	203 -116

Status	Assigned	Task
Open	None	T143341 When re-starting a local draft, show the user a diff so they know what they're getting into
Open	None	T105173 HTML diffs of edits for everything
Resolved	• Tchanders	T143350 Let users choose a visual or wikitext diff in the review-your-changes tab
Resolved	• Tchanders	T158518 Removing and inserting table cells breaks diff

After fixing T158769 this looks a little less broken:

But EFG on row 3 should be green for this to be technically correct, or better not duplicated at all.

Jdforrester-WMF set the point value for this task to 8.

Change 340656 had a related patch set uploaded (by Tchanders):
[VisualEditor/VisualEditor] Generalize DiffElement logic (improves lists and tables)

Change 340656 merged by jenkins-bot:
[VisualEditor/VisualEditor] Generalize DiffElement logic (improves lists and tables)

Change 342651 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (bc6417ba5)

Change 342651 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (41134af2b)

	F5765720: pasted_file
	Feb 22 2017, 3:05 PM