Page MenuHomePhabricator
Create Task
Maniphest T156189

Have the visual diff system display content attribute changes
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

At the moment the differ displays content attribute changes (e.g. adding a link to some text, removing bold styling, etc) as removing the old content and inserting the new. We should work out a more informative way to display such changes.

Details

SubjectRepoBranchLines /-
Update VE core submodule to master (8817821b6)mediawiki/extensions/VisualEditormaster 2 -1
VisualDiff: Show attribute changes in a sidebarVisualEditor/VisualEditormaster 450 -38
VisualDiff: Distinguish between annotation/character changesVisualEditor/VisualEditormaster 89 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Tchanders created this task.Jan 24 2017, 9:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2017, 9:32 PM
• Tchanders mentioned this in T151404: Have the visual diff system display node attribute changes.Jan 24 2017, 9:33 PM
Esanders moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Jan 27 2017, 4:49 PM
gerritbot subscribed.Feb 7 2017, 10:39 PM

Change 336547 had a related patch set uploaded (by Tchanders):
VisualDiff: Distinguish between annotation/character changes

https://gerrit.wikimedia.org/r/336547

gerritbot added a project: Patch-For-Review.Feb 7 2017, 10:39 PM
Jdforrester-WMF triaged this task as High priority.Feb 8 2017, 11:16 PM
Jdforrester-WMF added a project: Design.
Jdforrester-WMF set the point value for this task to 8.
gerritbot added a comment.Feb 15 2017, 5:07 PM

Change 336547 merged by jenkins-bot:
VisualDiff: Distinguish between annotation/character changes

https://gerrit.wikimedia.org/r/336547

Jdforrester-WMF removed a project: Patch-For-Review.Feb 15 2017, 7:06 PM
Jdforrester-WMF subscribed.

Hard bit done, now it 'just' needs to be turned into UI.

gerritbot added a comment.Mar 15 2017, 10:21 PM

Change 340160 had a related patch set uploaded (by Esanders):
[VisualEditor/VisualEditor] VisualDiff: Show attribute changes in a sidebar

https://gerrit.wikimedia.org/r/340160

gerritbot added a project: Patch-For-Review.Mar 15 2017, 10:21 PM
gerritbot added a comment.Mar 15 2017, 10:43 PM

Change 340160 merged by jenkins-bot:
[VisualEditor/VisualEditor] VisualDiff: Show attribute changes in a sidebar

https://gerrit.wikimedia.org/r/340160

gerritbot added a comment.Mar 15 2017, 11:32 PM

Change 342963 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (8817821b6)

https://gerrit.wikimedia.org/r/342963

Jdforrester-WMF added a parent task: T143350: Let users choose a visual or wikitext diff in the review-your-changes tab.Mar 15 2017, 11:42 PM
Jdforrester-WMF closed this task as Resolved.Mar 16 2017, 3:38 PM
Jdforrester-WMF edited projects, added VisualEditor-EditingTools; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 16 2017, 3:38 PM
gerritbot added a comment.Mar 16 2017, 3:42 PM

Change 342963 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (8817821b6)

https://gerrit.wikimedia.org/r/342963

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)).Mar 16 2017, 4:00 PM
Dvorapa subscribed.Mar 16 2017, 8:42 PM
Dvorapa unsubscribed.
Jdforrester-WMF added a project: VisualEditor-VisualDiffs.Apr 10 2017, 10:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits