Page MenuHomePhabricator
Create Task
Maniphest T151233

[betalabs-regression] Flow board - switching to VE produces "TypeError: this.parseHtml is not a function"
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

  1. On a Flow board in betalabs, open any entry for editing and switch to VE.
  2. The switching to VE never ends - the following error is displayed in the Console:

load.php?debug=false&lang=en&modules=jquery,mediawiki&only=scripts&skin=vector&version=1u1uxh5:176 TypeError: this.parseHtml is not a function

Screen Shot 2016-11-21 at 11.32.38 AM.png (449×1 px, 144 KB)

  1. The same error is displayed everywhere where the switch to VE is available.

Details

SubjectRepoBranchLines /-
Adjust to breaking change Icca471541173 in VisualEditormediawiki/extensions/Flowmaster 1 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Nov 21 2016, 7:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2016, 7:35 PM
• Catrope subscribed.Nov 22 2016, 7:09 PM

Caused by rEVEDe1a887ccf857: Migrate DesktopWikitextArticleTarget code upstream which renamed ve.init.mw.Target#parseHtml without adding a [BREAKING CHANGE] tag or grepping for callers.

ssastry removed a project: Parsoid.Nov 22 2016, 7:12 PM
gerritbot subscribed.Nov 22 2016, 7:28 PM

Change 322948 had a related patch set uploaded (by Catrope):
Adjust to breaking change Icca471541173 in VisualEditor

https://gerrit.wikimedia.org/r/322948

gerritbot added a project: Patch-For-Review.Nov 22 2016, 7:28 PM
Jdforrester-WMF assigned this task to • Catrope.Nov 22 2016, 7:40 PM
Jdforrester-WMF added a project: VisualEditor.
Jdforrester-WMF set the point value for this task to 0.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot added a comment.Nov 22 2016, 7:43 PM

Change 322948 merged by jenkins-bot:
Adjust to breaking change Icca471541173 in VisualEditor

https://gerrit.wikimedia.org/r/322948

Jdforrester-WMF triaged this task as Unbreak Now! priority.Nov 22 2016, 8:04 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptNov 22 2016, 8:04 PM
• Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Nov 24 2016, 12:44 AM
• Catrope added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).
• Catrope added a subscriber: ReleaseTaggerBot.

Not sure why @ReleaseTaggerBot didn't tag this...

Etonkovidova added a comment.EditedNov 24 2016, 1:30 AM

Checked the fix in betalabs and in production 1.29.0-wmf.4

• Catrope moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Nov 24 2016, 1:36 AM
Jdforrester-WMF closed this task as Resolved.Nov 29 2016, 1:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits