| • Prtksxna | |
| Oct 17 2016, 10:24 PM |
| F6361918: Screen Shot 2017-03-09 at 3.14.24 PM.png | |
| Mar 9 2017, 9:46 AM |
| F6361905: Screen Shot 2017-03-09 at 3.14.20 PM.png | |
| Mar 9 2017, 9:46 AM |
From @matmarex's comment on https://gerrit.wikimedia.org/r/#/c/283652/
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Prtksxna | T130434 Break up TextInputWidget | |||
| Resolved | • Prtksxna | T148471 Break out search stuff in TextInputWidget into SearchInputWidget |
Change 283652 had a related patch set uploaded (by Prtksxna):
Break out parts of TextInputWidget into a new SearchInputWidget
Change 283652 merged by jenkins-bot:
Break out parts of TextInputWidget into a new SearchInputWidget
Deprecation will go out in the next release (0.18.0), flagged in the notes; following our practice, that means we should find and fix all users in Wikimedia git, and wait a couple of weeks.
From https://github.com/search?l=JavaScript&q="oo.ui" "type: 'search'" @wikimedia&ref=searchresults&type=Code&utf8=✓ it vaguely looks like this is now all updated?
Change 333584 had a related patch set uploaded (by Prtksxna):
[BREAKING CHANGE] TextInputWidget: Remove search related methods
Getting this on https://www.mediawiki.org/w/index.php?search=Example
TextInputWidget: config.type='search' is deprecated. Use the SearchInputWidget instead. See T148471 for details.
- MwWidgetsTitleInputWidget
- MwWidgetsSearchInputWidget
- OO.ui.infuse
Eeeks!
mw.widgets.SearchInputWidget is using config.type = 'search'. It's doing so as it inherits from mw.widgets.TitleInputWidget, which inherits from OO.ui.TextInputWidget. We can't have TitleInputWidget inherit from OO.ui.SearchInputWidget because not all of its uses are search related. I am not able to figure out an obvious way to fix this.
 |  |
Hm, I guess we need to implement OO.ui.SearchInputWidget functionality in mw.widgets.SearchInputWidget. That shouldn't be too difficult.
Change 342718 had a related patch set uploaded (by Bartosz Dziewoński):
[mediawiki/core] mw.widgets.SearchInputWidget: Do not pass type: 'search' to TextInputWidget
I'm not really sure why mw.widgets.SearchInputWidget inherits from mw.widgets.TitleInputWidget, most of its code seems to be workarounds for its behaviors… oh well, some other time.
Change 342718 merged by jenkins-bot:
[mediawiki/core] mw.widgets.SearchInputWidget: Do not pass type: 'search' to TextInputWidget
Change 342773 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/core] mw.widgets.SearchInputWidget: Do not pass type: 'search' to TextInputWidget
Change 342773 merged by jenkins-bot:
[mediawiki/core] mw.widgets.SearchInputWidget: Do not pass type: 'search' to TextInputWidget
Mentioned in SAL (#wikimedia-operations) [2017-03-15T18:34:13Z] <legoktm@tin> Synchronized php-1.29.0-wmf.16/includes/widget/SearchInputWidget.php: mw.widgets.SearchInputWidget: Do not pass to TextInputWidget - T148471 (1/2) (duration: 00m 41s)
Mentioned in SAL (#wikimedia-operations) [2017-03-15T18:35:32Z] <legoktm@tin> Synchronized php-1.29.0-wmf.16/resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js: mw.widgets.SearchInputWidget: Do not pass to TextInputWidget - T148471 (2/2) (duration: 00m 42s)
@Jdforrester-WMF Want to take another look at a freshly rebased https://gerrit.wikimedia.org/r/#/c/333584/?
Change 333584 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] TextInputWidget: Remove search related methods