Some input to Citoid extension, may already be URL encoded, and the Citoid extension encodes it again, resulting in double-encoded input to citoid.
Open, MediumPublic0 Estimated Story Points
Actions

Assigned To

None

Authored By

	Pols12
	Sep 24 2016, 1:50 PM

Description

Reproduction steps: Load https://en.wikipedia.org/api/rest_v1/data/citation/mediawiki/http://ticri.univ-lorraine.fr/wicri-lor.fr/index.php/Laboratoire_mat%C3%A9riaux_optiques,_photonique_et_syst%C3%A8mes?action=query&format=json

Expected result: Should return citation information for https://lorexplor.istex.fr/wicri-lor.fr/index.php/Laboratoire_matériaux_optiques,_photonique_et_systèmes.

Actual result: Returns a not found error.

Details

	Subject	Repo	Branch	Lines /-
	Decode input before sending to citoid	mediawiki/extensions/Citoid	master	8 -1

Customize query in gerrit

Related Objects

Mentioned In: T136911: Citoid should recognise per cent-encoded URLs and avoid double-encoding them

Event Timeline

Pols12 created this task.Sep 24 2016, 1:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2016, 1:50 PM

Izno moved this task from Unsorted backlog to External on the Cite board.Sep 24 2016, 2:27 PM

Change 313428 had a related patch set uploaded (by DLynch):
Decode likely URLs before sending them to citoid

https://gerrit.wikimedia.org/r/313428

gerritbot added a project: Patch-For-Review.Sep 29 2016, 4:49 PM

I noticed that it was clearly fetching the wrong page as well, since it was showing "mauvais titre" rather than the actual article title. Therefore, the patch decodes URLs before sending them to the citoid service.

This is should really be done in the backend (citoid). (But probably no harm in duplicating it on front end).

Mvolz removed a project: Cite.Sep 30 2016, 12:21 PM

Mvolz triaged this task as Medium priority.Sep 30 2016, 1:42 PM

Mvolz merged a task: T136911: Citoid should recognise per cent-encoded URLs and avoid double-encoding them.

Mvolz mentioned this in T136911: Citoid should recognise per cent-encoded URLs and avoid double-encoding them.

Mvolz added subscribers: zhaofengli, Jdforrester-WMF, Josve05a and 2 others.

Mvolz renamed this task from Cite tool should not encode percent char in URI to Some input to citoid may already be URL encoded, and the Citoid extension encodes it again, resulting in double-encoded input. .Sep 30 2016, 1:59 PM

Mvolz renamed this task from Some input to citoid may already be URL encoded, and the Citoid extension encodes it again, resulting in double-encoded input. to Some input to Citoid extension, may already be URL encoded, and the Citoid extension encodes it again, resulting in double-encoded input to citoid..

Change 313428 merged by jenkins-bot:
Decode input before sending to citoid

https://gerrit.wikimedia.org/r/313428

Mvolz removed a project: Patch-For-Review.Sep 30 2016, 5:02 PM

Mvolz updated the task description. (Show Details)

Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Oct 3 2016, 6:44 PM

Mvolz closed this task as Resolved.Oct 10 2016, 2:24 PM

Mvolz updated the task description. (Show Details)

Jdforrester-WMF assigned this task to Mvolz.Oct 14 2016, 11:41 PM

Jdforrester-WMF added a project: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).

Jdforrester-WMF set the point value for this task to 0.

Dlynch did this one actually :)

Mvolz reassigned this task from Mvolz to DLynch.Oct 15 2016, 6:15 AM

There is a fix in the frontend, but this bug still exists in the backend.

Other clients of citoid are also exposed to this bug. Example affected gadget: https://he.wikipedia.org/w/index.php?title=מדיה_ויקי:Gadget-Checkty.js&oldid=prev&diff=28037937&uselang=en

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 8 2020, 5:44 AM

Reopening per @eranroz's comment above. I also confirmed that this bug occurs with RefToolbar on English Wikipedia (which also uses Citoid). We should implement a fix within the Citoid service itself, rather than just in VE.

kaldari reassigned this task from DLynch to Mvolz.Sep 10 2020, 10:40 PM

kaldari removed projects: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), VisualEditor.

kaldari updated the task description. (Show Details)

@eranroz - I implemented a work-around for RefToolbar. You can probably use a similar work-around for Checkty: https://en.wikipedia.org/w/index.php?title=MediaWiki:RefToolbar.js&type=revision&diff=977779611&oldid=972381502.

Thanks - I already stole the fix from VE into the gadget.

Mvolz removed Mvolz as the assignee of this task.May 28 2021, 9:34 AM

	F4537340: pasted_file
	Sep 29 2016, 4:52 PM

Some input to Citoid extension, may already be URL encoded, and the Citoid extension encodes it again, resulting in double-encoded input to citoid.Open, MediumPublic0 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Some input to Citoid extension, may already be URL encoded, and the Citoid extension encodes it again, resulting in double-encoded input to citoid.
Open, MediumPublic0 Estimated Story Points
Actions