UI Regression: PointerOverlay's are broken
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 10 2016, 3:19 PM

Description

Visit https://en.m.wikipedia.org/w/index.php?title=Foozbar&article_action=signup-edit while logged in
Expected:

Screen Shot 2017-04-17 at 11.11.19 AM.png (341×467 px, 37 KB)

Actual:

Screen Shot 2017-04-17 at 11.09.10 AM.png (300×418 px, 21 KB)

Click the hamburger menu
Expected: Pointer overlay closes
Actual:

Screen Shot 2017-04-17 at 11.12.06 AM.png (341×462 px, 37 KB)

Acceptance criteria

UI regression removed
When I click the hamburger menu (the icon in the top left) the pointer overlay disappears

Developer notes

A class is being used that shouldn't - use pointer-overlay-tutorial not tutorial-overlay class
Inside skins.minerva.newusers you'll want to bind to the hamburger menu icon and hide the overlay when the pointer overlay is clicked. Alternatively consider require the passing of a MainMenu instance into all PointerOverlays.

Details

	Subject	Repo	Branch	Lines /-
	Sign up edit tutorial fixes	mediawiki/extensions/MobileFrontend	master	32 -1

Customize query in gerrit

Related Objects

Mentioned In: T241177: Product debt: Drop amcOutreachDrawer

Event Timeline

Jdlrobson created this task.Aug 10 2016, 3:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2016, 3:19 PM

phuedx added a project: Web-Team-Backlog.Aug 10 2016, 5:24 PM

This a more general problem and happens with toasts and possibly other similar items too. @Nirzar, do you think we should hide such things when the hamburger is tapped? To re-produce, go to https://en.m.wikipedia.org/wiki/Book and click on the edit pencil icon. You'll see a "vandalism..." message, then click on the hamburger menu. You'll see that the toast won't go away.

do you think we should hide such things when the hamburger is tapped?

Yes. hamburger should focus on the opening panel. we don't want to split attention.

• jhobs moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Aug 10 2016, 5:37 PM

Triaged as Normal over High since the toasts and tooltips still disappear properly and it is probably not the most likely scenario upon which a user will stumble.

• jhobs moved this task from Needs Prioritization to Incoming on the Web-Team-Backlog board.Aug 10 2016, 5:41 PM

• jhobs moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Aug 11 2016, 5:22 PM

Jdlrobson renamed this task from PointerOverlay's should close on menu open to UI Regression: PointerOverlay's are broken.Apr 17 2017, 6:14 PM

Jdlrobson added projects: Regression, patch-welcome, good first task.

Jdlrobson updated the task description. (Show Details)

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 17 2017, 6:14 PM

Jdlrobson updated the task description. (Show Details)Apr 17 2017, 6:14 PM

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Apr 27 2017, 3:46 PM

Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.Apr 29 2017, 12:06 AM

Jdlrobson updated the task description. (Show Details)May 3 2017, 11:37 PM

Jdlrobson set the point value for this task to 3.May 4 2017, 5:20 PM

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.

Jdlrobson moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog board.May 4 2017, 6:07 PM

• bmansurov claimed this task.May 10 2017, 6:19 PM

• bmansurov moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.

Change 353191 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/extensions/MobileFrontend@master] Edit overlay fixes

https://gerrit.wikimedia.org/r/353191

gerritbot added a project: Patch-For-Review.May 10 2017, 10:11 PM

• bmansurov moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.May 10 2017, 10:12 PM

Jdlrobson removed a project: Patch-For-Review.May 11 2017, 9:31 AM

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.

Change 353191 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Sign up edit tutorial fixes

https://gerrit.wikimedia.org/r/353191

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 11 2017, 11:00 AM

• bmansurov removed • bmansurov as the assignee of this task.May 11 2017, 2:24 PM

Jdlrobson assigned this task to ovasileva.May 11 2017, 5:05 PM

@Jdlrobson - tried testing this on a few pages (which do not exist) - I'm getting a "this page is protected to prevent vandalism" error everywhere.

@ovasileva are you logged in? What user account are you using? A new one or your own?

Tested on the beta cluster - all done.

Screen Shot 2017-05-15 at 11.51.38 AM.png (478×379 px, 58 KB)

Jdlrobson mentioned this in T241177: Product debt: Drop amcOutreachDrawer.Jan 6 2020, 4:41 PM

	F8081875: Screen Shot 2017-05-15 at 11.51.38 AM.png
	May 15 2017, 9:52 AM

	F7596646: Screen Shot 2017-04-17 at 11.11.19 AM.png
	Apr 17 2017, 6:14 PM

	F7596655: Screen Shot 2017-04-17 at 11.12.06 AM.png
	Apr 17 2017, 6:14 PM

	F7596632: Screen Shot 2017-04-17 at 11.09.10 AM.png
	Apr 17 2017, 6:14 PM

	F4350965: Screen Shot 2016-08-10 at 8.18.44 AM.png
	Aug 10 2016, 3:19 PM

UI Regression: PointerOverlay's are brokenClosed, ResolvedPublic3 Estimated Story PointsActions