Wrapping templatestyle tag in a noinclude was not intuitive.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 19 2016, 11:42 PM

Description

This didn't seem obvious to me. I wanted to include styles in the template.. so why did I have to wrap them in a noinclude ?

If this cannot be changed we should document this on the wiki page.

Details

	Subject	Repo	Branch	Lines /-
	Use wikimedia/css-sanitizer, and rewrite the hooking	mediawiki/extensions/TemplateStyles	master	1 K -953

Customize query in gerrit

Related Objects

Mentioned Here: T136054: TemplateStyles puts css in page_props table, which might be subject to race conditions, etc

Event Timeline

Jdlrobson created this task.May 19 2016, 11:42 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 19 2016, 11:42 PM

The alternative would be that styles are transcluded to every page and processed there, which is more flexible (e.g. styles can depend on template parameters) but also more expensive since styles would have to be reparsed in every article.

Change 346808 had a related patch set uploaded (by Anomie):
[mediawiki/extensions/TemplateStyles@master] Use wikimedia/css-sanitizer, and rewrite the hooking

https://gerrit.wikimedia.org/r/346808

gerritbot added a project: Patch-For-Review.Apr 6 2017, 6:48 PM

Change 346808 merged by jenkins-bot:
[mediawiki/extensions/TemplateStyles@master] Use wikimedia/css-sanitizer, and rewrite the hooking

https://gerrit.wikimedia.org/r/346808

Anomie closed this task as Resolved.Jun 7 2017, 4:13 PM

Anomie claimed this task.

• ggellerman moved this task from Backlog to Done on the TemplateStyles board.Nov 21 2017, 7:16 PM

Wrapping templatestyle tag in a noinclude was not intuitive.Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Wrapping templatestyle tag in a noinclude was not intuitive.
Closed, ResolvedPublic
Actions