Page MenuHomePhabricator
Create Task
Maniphest T132920

UploadWizard doesn't handle errors caused by upload rate limiting
Closed, ResolvedPublic
Actions

Description

UploadWizard doesn't handle errors caused by upload rate limiting ($wgRateLimits).

pasted_file (185×895 px, 26 KB)

Details

SubjectRepoBranchLines /-
Handle errors caused by upload rate limitingmediawiki/extensions/UploadWizardmaster 52 -10
Add 'api-error-ratelimited' message for UploadWizardmediawiki/coremaster 2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• matmarex created this task.Apr 18 2016, 3:09 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptApr 18 2016, 3:09 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
• matmarex added a parent task: T132930: Convert Commons filter 140 to a $wgRateLimits configuration.Apr 18 2016, 4:37 PM
• matmarex mentioned this in T132930: Convert Commons filter 140 to a $wgRateLimits configuration.Apr 18 2016, 8:09 PM
• matmarex mentioned this in T121896: Commons UploadWizard rejects all uploads with false error message after a certain number of uploads.Apr 18 2016, 8:57 PM
• matmarex added a parent task: T121896: Commons UploadWizard rejects all uploads with false error message after a certain number of uploads.
• matmarex claimed this task.Apr 18 2016, 9:03 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptApr 18 2016, 9:03 PM
Jdforrester-WMF triaged this task as Medium priority.Apr 25 2016, 11:08 PM
• matmarex raised the priority of this task from Medium to High.Apr 26 2016, 8:36 PM
gerritbot subscribed.Apr 27 2016, 12:46 AM

Change 285562 had a related patch set uploaded (by Bartosz Dziewoński):
Add 'api-error-ratelimited' message for UploadWizard

https://gerrit.wikimedia.org/r/285562

gerritbot added a project: Patch-For-Review.Apr 27 2016, 12:46 AM

Change 285564 had a related patch set uploaded (by Bartosz Dziewoński):
Handle errors caused by upload rate limiting

https://gerrit.wikimedia.org/r/285564

• matmarex added a comment.Apr 27 2016, 6:30 PM

A test with $wgRateLimits['upload']['user'] = [ 3, 60 ] (3 uploads per minute):

20160427_2025_05.avi2 MBDownload

• matmarex added a comment.Apr 27 2016, 6:54 PM

pasted_file (946×1 px, 250 KB)

• matmarex removed a parent task: T132930: Convert Commons filter 140 to a $wgRateLimits configuration.Apr 27 2016, 7:03 PM
gerritbot added a comment.Apr 29 2016, 1:49 PM

Change 285562 merged by jenkins-bot:
Add 'api-error-ratelimited' message for UploadWizard

https://gerrit.wikimedia.org/r/285562

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-05-03_(1.27.0-wmf.23)).Apr 29 2016, 2:00 PM
gerritbot added a comment.May 2 2016, 3:49 PM

Change 285564 merged by jenkins-bot:
Handle errors caused by upload rate limiting

https://gerrit.wikimedia.org/r/285564

• matmarex closed this task as Resolved.May 2 2016, 4:01 PM

This should be deployed to Wikimedia Commons this Wednesday.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits