Page MenuHomePhabricator
Create Task
Maniphest T131075

VRS should accept user-agent information and pass it along
Closed, InvalidPublic
Actions

Description

VE, CX, Flow all go through VRS and 'grep headers includes/libs/virtualrest/*' shows that user-agent is not being set there. This means that RESTBase then passes a RESTBase/WMF header in the user-agent string to Parsoid (In T129752#2118608, @mobrovac says that RESTBase adds that user agent string if the client doesn't provide any user-agent header).

So, if VRS can accept a user-agent param, then clients can pass RESTBase user-agent info via VRS and RESTBase would then pass that along to Parsoid which would simplify log analysis and attributing requests to the upstream clients that generated those requests.

Related Objects

Event Timeline

ssastry created this task.Mar 28 2016, 5:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2016, 5:56 PM
ssastry updated the task description. (Show Details)Mar 28 2016, 5:57 PM
ssastry added a subscriber: • mobrovac.
• GWicke subscribed.Mar 28 2016, 6:45 PM

Copying from mail:

I'm pretty sure VRS does support arbitrary headers:

https://github.com/wikimedia/mediawiki/blob/c339459eb3ee100c0abda4ebf7e4266f7b3d58bd/includes/libs/virtualrest/VirtualRESTServiceClient.php

Is there any reason why user-agent is not supported?

• mobrovac added a comment.Mar 29 2016, 12:55 PM

RestbaseVirtualRESTService does not mangle the headers at all, but lets them pass through. It [only alters the cookie header](https://github.com/wikimedia/mediawiki/blob/c339459eb3ee100c0abda4ebf7e4266f7b3d58bd/includes/libs/virtualrest/RestbaseVirtualRESTService.php#L96) if so set in the configuration.

Judging by the looks of it, all that VRS users need to do is actually set the UA header. Close this task as invalid?

• AlexMonk-WMF closed this task as Invalid.Mar 29 2016, 12:59 PM

Sounds like this already works

ssastry mentioned this in T131171: Add user-agent header in your requests to VirtualRestService.Mar 29 2016, 5:20 PM
ssastry mentioned this in T131172: Add user-agent header in your requests to VirtualRestService.
ssastry mentioned this in T131173: Please add user-agent header in your requests to Parsoid.Mar 29 2016, 5:22 PM
ssastry mentioned this in T131174: Add user-agent header in your requests to VirtualRestService.
santhosh reopened this task as Open.Jun 28 2016, 5:51 AM
santhosh triaged this task as Medium priority.
santhosh subscribed.

Both CX and VE are setting user-agent header in requests.

But, I still see "wikimedia/multi-http-client v1.0" as the user agent for logs in logstash for all the requests.
That comes from the default user-agent value of core/inculdes/lib/MultiHttpClient.php
Is the header value set getting lost somewhere?

• mobrovac closed this task as Invalid.Jun 29 2016, 11:28 AM

@santhosh From what I can tell, this is handled properly in the MW Core's HTTP Client. In the CX extension, however, there is bug in requestRestbase(): you set the header, but never associate the header array to the request object itself, so the Accept and User-Agent headers never actually make it through.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits