Page MenuHomePhabricator
Create Task
Maniphest T129641

BadMethodCallException in EditThresholdPresentationModel.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

User Brunter from ru.wikipedia reports an error in the notification
https://ru.wikipedia.org/w/index.php?title=Википедия:Форум/Технический&oldid=77032299#.D0.9E.D1.88.D0.B8.D0.B1.D0.BA.D0.B0_.D0.B2_.D1.83.D0.B2.D0.B5.D0.B4.D0.BE.D0.BC.D0.BB.D0.B5.D0.BD.D0.B8.D1.8F.D1.85

11800314.png (264×505 px, 11 KB)

"The day after the registration of such a thing happened.
If you click on "All Notifications", the following text is displayed: Exception encountered, of type "BadMethodCallException". In other language this error is not displayed"

2016-03-09 20:47:46 mw1136 ruwiki 1.27.0-wmf.15 exception ERROR: [fcc5f9ba] /w/api.php?action=query&format=json&notsections=alert&meta=notifications&notgroupbysection=1&notmessageunreadfirst=1&notformat=model&notlimit=25&notprop=index|list|count&uselang=ru&_=1457556461287   BadMethodCallException from line 15 of /srv/mediawiki/php-1.27.0-wmf.15/extensions/Echo/includes/formatters/EditThresholdPresentationModel.php: Call to a member function getLocalURL() on a non-object (NULL) {"exception_id":"fcc5f9ba"} 
[Exception BadMethodCallException] (/srv/mediawiki/php-1.27.0-wmf.15/extensions/Echo/includes/formatters/EditThresholdPresentationModel.php:15) Call to a member function getLocalURL() on a non-object (NULL)
  #0 /srv/mediawiki/php-1.27.0-wmf.15/extensions/Echo/includes/formatters/EventPresentationModel.php(371): EchoEditThresholdPresentationModel->getPrimaryLink()
  #1 /srv/mediawiki/php-1.27.0-wmf.15/extensions/Echo/includes/formatters/EchoModelFormatter.php(13): EchoEventPresentationModel->jsonSerialize()
  #2 /srv/mediawiki/php-1.27.0-wmf.15/extensions/Echo/includes/formatters/EchoEventFormatter.php(30): EchoModelFormatter->formatModel(EchoEditThresholdPresentationModel)
  #3 /srv/mediawiki/php-1.27.0-wmf.15/extensions/Echo/includes/DataOutputFormatter.php(142): EchoEventFormatter->format(EchoEvent)
  #4 /srv/mediawiki/php-1.27.0-wmf.15/extensions/Echo/includes/DataOutputFormatter.php(117): EchoDataOutputFormatter::formatNotification(EchoEvent, User, string, LanguageRu)
  #5 /srv/mediawiki/php-1.27.0-wmf.15/extensions/Echo/includes/api/ApiEchoNotifications.php(219): EchoDataOutputFormatter::formatOutput(EchoNotification, string, User, LanguageRu)
  #6 /srv/mediawiki/php-1.27.0-wmf.15/extensions/Echo/includes/api/ApiEchoNotifications.php(129): ApiEchoNotifications->getPropList(User, array, array, integer, NULL, string, boolean)
  #7 /srv/mediawiki/php-1.27.0-wmf.15/extensions/Echo/includes/api/ApiEchoNotifications.php(49): ApiEchoNotifications->getSectionPropList(User, string, array, integer, NULL, string, boolean)
  #8 /srv/mediawiki/php-1.27.0-wmf.15/includes/api/ApiQuery.php(277): ApiEchoNotifications->execute()
  #9 /srv/mediawiki/php-1.27.0-wmf.15/includes/api/ApiMain.php(1359): ApiQuery->execute()
  #10 /srv/mediawiki/php-1.27.0-wmf.15/includes/api/ApiMain.php(462): ApiMain->executeAction()
  #11 /srv/mediawiki/php-1.27.0-wmf.15/includes/api/ApiMain.php(433): ApiMain->executeActionWithErrorHandling()
  #12 /srv/mediawiki/php-1.27.0-wmf.15/api.php(83): ApiMain->execute()
  #13 /srv/mediawiki/w/api.php(3): include(string)
  #14 {main}

Details

SubjectRepoBranchLines /-
thank-you-edit: canRender for deleted page and extra fixmediawiki/extensions/Echowmf/1.27.0-wmf.16 5 -1
thank-you-edit: canRender for deleted page and extra fixmediawiki/extensions/Echomaster 5 -1
Customize query in gerrit

Related Objects

Event Timeline

Sunpriat created this task.Mar 11 2016, 11:57 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 11 2016, 11:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Arbnos subscribed.Mar 11 2016, 2:44 PM
• Mattflaschen-WMF renamed this task from BadMethodCallException to BadMethodCallException in EditThresholdPresentationModel.php.Mar 11 2016, 4:34 PM
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
• Mattflaschen-WMF claimed this task.Mar 11 2016, 4:50 PM
gerritbot subscribed.Mar 11 2016, 7:00 PM

Change 276788 had a related patch set uploaded (by Mattflaschen):
thank-you-edit: canRender for deleted page and extra fix

https://gerrit.wikimedia.org/r/276788

gerritbot added a project: Patch-For-Review.Mar 11 2016, 7:00 PM
gerritbot added a comment.Mar 11 2016, 7:11 PM

Change 276788 merged by jenkins-bot:
thank-you-edit: canRender for deleted page and extra fix

https://gerrit.wikimedia.org/r/276788

• Mattflaschen-WMF moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.Mar 11 2016, 7:57 PM
gerritbot added a comment.Mar 11 2016, 11:48 PM

Change 276916 had a related patch set uploaded (by Catrope):
thank-you-edit: canRender for deleted page and extra fix

https://gerrit.wikimedia.org/r/276916

• Mattflaschen-WMF merged a task: T129715: Echo: Call to a member function getLocalURL() on a non-object (null) in EditThresholdPresentationModel.php.Mar 12 2016, 12:00 AM
• Mattflaschen-WMF added a project: Wikimedia-production-error.
• Mattflaschen-WMF moved this task from Untriaged to Mar 2019 / 1.33wmf20-23 on the Wikimedia-production-error board.
• Mattflaschen-WMF added subscribers: • Catrope, • demon.
• Mattflaschen-WMF triaged this task as Medium priority.Mar 12 2016, 12:36 AM
• Mattflaschen-WMF merged a task: T129715: Echo: Call to a member function getLocalURL() on a non-object (null) in EditThresholdPresentationModel.php.
gerritbot added a comment.Mar 14 2016, 3:11 PM

Change 276916 merged by jenkins-bot:
thank-you-edit: canRender for deleted page and extra fix

https://gerrit.wikimedia.org/r/276916

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)).Mar 15 2016, 6:02 PM
Etonkovidova subscribed.Mar 15 2016, 8:45 PM

Checked in betalabs - if a page was deleted, all messages/alerts related to that page will be removed from Notifications. Since there is no notifications about a page being deleted, the abrupt removal of all notifications related to that page may be extremely confusing to users.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Mar 15 2016, 8:45 PM
• jmatazzoni closed this task as Resolved.Mar 23 2016, 6:52 PM
• demon moved this task from Mar 2019 / 1.33wmf20-23 to Resolved on the Wikimedia-production-error board.May 10 2016, 8:44 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits