Page MenuHomePhabricator
Create Task
Maniphest T129481

Refactor SpecialPages for Watchlist to use WatchedItemStore
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To
Addshore
Authored By
Tobi_WMDE_SW
Mar 10 2016, 2:56 PM
Tags
Referenced Files
None
Subscribers
Addshore
Aklapper
daniel
gerritbot
JEumerus
Ricordisamoa
Tobi_WMDE_SW
View All 9 Subscribers

Description

Could be refactored into a WatchedItemStore:

  • SpecialWatchlist
  • SpecialEditWatchlist

Details

SubjectRepoBranchLines /-
Use WatchedItemStore clearing in SpecialEditWatchlistmediawiki/coremaster 22 -30
Use WIS:addWatchBatchForUser in SpecialEditWatchlistmediawiki/coremaster 37 -27
Add WatchedItemStore::getWatchedItemsForUsermediawiki/coremaster 169 -20
Use WatchedItemStore::removeWatch in SpecialEditWatchlistmediawiki/coremaster 5 -29
Add WatchedItemStore::countWatchedItemsmediawiki/coremaster 61 -11
Use WatchedItemStore::countWatchers in SpecialWatchlistmediawiki/coremaster 9 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tobi_WMDE_SW created this task.Mar 10 2016, 2:56 PM
Addshore claimed this task.Mar 10 2016, 3:10 PM
Addshore set the point value for this task to 5.
Ricordisamoa subscribed.Mar 10 2016, 3:33 PM
Tobi_WMDE_SW added a project: TCB-Team-Sprint-2016-03-02.Mar 10 2016, 3:55 PM
Tobi_WMDE_SW moved this task from Proposed to Backlog on the TCB-Team-Sprint-2016-03-02 board.
Tobi_WMDE_SW moved this task from Backlog to Doing on the TCB-Team-Sprint-2016-03-02 board.Mar 11 2016, 1:46 PM
gerritbot subscribed.Mar 14 2016, 12:47 PM

Change 276446 had a related patch set uploaded (by Addshore):
Add clearWatchedItems to WatchedItemStore

https://gerrit.wikimedia.org/r/276446

gerritbot added a project: Patch-For-Review.Mar 14 2016, 12:47 PM
gerritbot added a comment.Mar 14 2016, 4:12 PM

Change 277262 had a related patch set uploaded (by Addshore):
Use WatchedItemStore::countWatchers in SpecialWatchlist

https://gerrit.wikimedia.org/r/277262

Anomie mentioned this in T129482: Refactor watchlist related API classes to use WatchedItemStore.Mar 14 2016, 4:28 PM
gerritbot added a comment.Mar 14 2016, 4:55 PM

Change 277276 had a related patch set uploaded (by Addshore):
Add WatchedItemStore::countWatchedItems

https://gerrit.wikimedia.org/r/277276

gerritbot added a comment.Mar 15 2016, 12:38 AM

Change 277436 had a related patch set uploaded (by Addshore):
Use WatchedItemStore in SpecialEditWatchlist

https://gerrit.wikimedia.org/r/277436

gerritbot added a comment.Mar 15 2016, 1:13 AM

Change 277444 had a related patch set uploaded (by Addshore):
Use WatchedItemStore::removeWatch in SpecialEditWatchlist

https://gerrit.wikimedia.org/r/277444

gerritbot added a comment.Mar 15 2016, 3:30 PM

Change 277262 merged by jenkins-bot:
Use WatchedItemStore::countWatchers in SpecialWatchlist

https://gerrit.wikimedia.org/r/277262

gerritbot added a comment.Mar 15 2016, 5:29 PM

Change 277276 merged by jenkins-bot:
Add WatchedItemStore::countWatchedItems

https://gerrit.wikimedia.org/r/277276

gerritbot added a comment.Mar 15 2016, 5:47 PM

Change 277444 merged by jenkins-bot:
Use WatchedItemStore::removeWatch in SpecialEditWatchlist

https://gerrit.wikimedia.org/r/277444

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)).Mar 15 2016, 8:02 PM
Tobi_WMDE_SW added a project: TCB-Team-Sprint-2016-03-16.Mar 16 2016, 11:37 AM
Tobi_WMDE_SW moved this task from Proposed to Doing on the TCB-Team-Sprint-2016-03-16 board.Mar 16 2016, 11:38 AM
gerritbot added a comment.Mar 16 2016, 1:21 PM

Change 277675 had a related patch set uploaded (by Addshore):
Add WatchedItemStore::getWatchedItemsForUser

https://gerrit.wikimedia.org/r/277675

gerritbot added a comment.Mar 16 2016, 1:54 PM

Change 277772 had a related patch set uploaded (by Addshore):
Use WIS:addWatchBatch in SpecialEditWatchlist

https://gerrit.wikimedia.org/r/277772

Addshore added a comment.Mar 16 2016, 4:34 PM

So most of this now has patches up. Still to go are:

  • The clearing methods in the edit wacthlist page may be blocked
  • The use in SpecialWatchlist::doMainQuery which joins on the recentchanges table and involves 2 hooks and just generally has lots of options and things..
Addshore updated the task description. (Show Details)Mar 16 2016, 4:34 PM
Addshore updated the task description. (Show Details)
Addshore added a comment.Mar 22 2016, 11:16 PM

Okay, right now I think I would class this task as all in review.
The clearing stuff will not be complete until the wl_id field is on all production dbs
and the doMainQuery method on SpecialWatchlist should probably stay as it is for now, trying to factor this out quickly would likely lead to lots of pain.

Addshore moved this task from Doing to Review on the TCB-Team-Sprint-2016-03-16 board.Mar 22 2016, 11:16 PM
gerritbot added a comment.Mar 23 2016, 3:45 PM

Change 277675 merged by jenkins-bot:
Add WatchedItemStore::getWatchedItemsForUser

https://gerrit.wikimedia.org/r/277675

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Mar 23 2016, 7:02 PM
gerritbot added a comment.Mar 25 2016, 10:47 AM

Change 277772 merged by jenkins-bot:
Use WIS:addWatchBatchForUser in SpecialEditWatchlist

https://gerrit.wikimedia.org/r/277772

Tobi_WMDE_SW moved this task from Incoming to Work in progress (TCB) on the TCB-Team (now WMDE-TechWish) board.Apr 19 2016, 11:33 AM
Tobi_WMDE_SW moved this task from Incoming to Work in progress on the German-Community-Wishlist board.May 9 2016, 10:17 AM
• Lea_WMDE moved this task from Work in progress (TCB) to Watchlist Expiry on the TCB-Team (now WMDE-TechWish) board.May 11 2016, 12:40 PM
Tobi_WMDE_SW added a project: Expiring-Watchlist-Items.May 11 2016, 12:52 PM
Addshore added a project: User-Addshore.Jul 12 2016, 1:02 PM
Addshore closed this task as Resolved.Jul 12 2016, 1:33 PM

I believe this is all done except for T132564 which is tracked seperatly

Addshore moved this task from Unsorted 💣 to Closing ✔️ on the User-Addshore board.Jul 12 2016, 1:33 PM
Tobi_WMDE_SW moved this task from Work in progress to Done on the German-Community-Wishlist board.Aug 31 2016, 2:13 PM
gerritbot added a comment.Feb 9 2018, 8:06 PM

Change 277436 merged by jenkins-bot:
[mediawiki/core@master] Use WatchedItemStore clearing in SpecialEditWatchlist

https://gerrit.wikimedia.org/r/277436

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)); removed MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Feb 9 2018, 9:00 PM
ifried moved this task from Backlog to Older WMDE Work (on hold; for reference only) on the Expiring-Watchlist-Items board.Oct 25 2019, 8:01 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptOct 25 2019, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits