Page MenuHomePhabricator
Create Task
Maniphest T129228

Changing a link inside a table cell makes the page re-scroll unnecessarily
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In Chrome, Win 8, Vector;
I'm trying to change the target for the "language variant" link at the bottom of https://www.mediawiki.org/wiki/VisualEditor#History .
Right after I select the new target, the page scrolls to the top.

This doesn't take place if you insert or alter a node (template, comment), apply/unapply a simple annotation (bold), or apply/alter the other rich annotation (language).

Details

SubjectRepoBranchLines /-
Link inspector: Remove premature call to onLinkTypeIndexSetmediawiki/extensions/VisualEditormaster 0 -1
Customize query in gerrit

Event Timeline

• Elitre created this task.Mar 8 2016, 3:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2016, 3:17 PM
• Elitre added a comment.Mar 8 2016, 4:32 PM

In Opera, it does jump up, but then refocuses again immediately after that.

Jdforrester-WMF renamed this task from Changing a link inside a table makes the page jump to Changing a link inside a table cell makes the page re-scroll unnecessarily.Mar 8 2016, 4:32 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added projects: VisualEditor-Links, VisualEditor-MediaWiki-Links.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF set the point value for this task to 1.
Esanders subscribed.Mar 8 2016, 4:44 PM

As the inspector opens it sets the selection to null which cancels the table editing mode. Doesn't happen in the core demo though.

Esanders added a subscriber: dchan.Mar 8 2016, 4:45 PM
gerritbot subscribed.Mar 8 2016, 4:55 PM

Change 275845 had a related patch set uploaded (by Esanders):
Link inspector: Remove premature call to onLinkTypeIndexSet

https://gerrit.wikimedia.org/r/275845

gerritbot added a project: Patch-For-Review.Mar 8 2016, 4:55 PM
gerritbot added a comment.Mar 8 2016, 5:24 PM

Change 275845 merged by jenkins-bot:
Link inspector: Remove premature call to onLinkTypeIndexSet

https://gerrit.wikimedia.org/r/275845

Jdforrester-WMF closed this task as Resolved.Mar 8 2016, 5:27 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)); removed Patch-For-Review.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
• Elitre awarded a token.Mar 8 2016, 5:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits