Provide a way to support HTML5 elements in browsers that don't support it and don't have JS shipped, like IE8 and below
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Jan 6 2016, 4:50 PM

Description

From T118303#1855079:

Wouldn't this implicate at the same time, that we can't fully support HTML5 Elements without extra <div> wrappers
for a long(/eternal) time(s)?

Because in IE 6-8 HTML5 elements can hold children and are affected by CSS only by help of JavaScript.

Or would it be a special treatment for a special friend out of Grade C browsers to include one JS in a
conditional comment in head exclusively for IE with JS enabled?
// Append JS shiv for supporting HTML5 elements in IE<9 @media screen 
$min = $this->getRequest()->getFuzzyBool( 'debug' ) ? '' : '.min';
$out->addHeadItem( 'html5shiv',
	''
);

Details

	Subject	Repo	Branch	Lines /-
	OutputPage: Support HTML5 elements in older browsers using html5shiv	mediawiki/core	master	342 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Arlolra	T118520 Use <figure-inline> instead of <span> for inline figures.
Resolved	None	T12467 Use semantic HTML (tracking)
Resolved	Arlolra	T122965 Provide a way to support HTML5 elements in browsers that don't support it and don't have JS shipped, like IE8 and below

Event Timeline

Jdforrester-WMF created this task.Jan 6 2016, 4:50 PM

Jdforrester-WMF raised the priority of this task from to Needs Triage.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added projects: MediaWiki-General, Browser-Support-Internet-Explorer.

Jdforrester-WMF added subscribers: Jdforrester-WMF, Volker_E, Krinkle.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 6 2016, 4:50 PM

Jdforrester-WMF mentioned this in T118303: Drop JavaScript support for IE8 (remove from "Grade A").Jan 6 2016, 4:51 PM

Krenair subscribed.Jan 6 2016, 5:20 PM

CCing Scott as he said he was looking at this already in the context of support for <figure> elements in the DOM.

Jdforrester-WMF added a parent task: T118520: Use <figure-inline> instead of <span> for inline figures..Jan 6 2016, 5:43 PM

I'd say, just use an IE conditional html5shim, but it's not a blocker. The elements we use are limited, the most high use element is probably <video> and that already takes care of this itself if I remember correctly...

The required output is really very simple. In the <head> (or at the beginning of <body> -- the important thing is that it precede any usage of HTML5 tags not recognized by IE, such as <figure>,<section>, etc:

<script>document.createElement('figure');document.createElement('section')</script>

For generality, we should probably create an MW API method that will add a new tag name to this set, so that extensions can register (say) <gallery> in the future if they wish. And we might find some way to minimize that code if the tag name list grows long. "figure,section,foo,bar".split(",").map(document.createElement) perhaps. But we can KISS to start.

(And at the moment, just including that fragment on all browsers is faster and smaller than trying to use IE conditional comments to load a shim file.)

@cscott Given the long history of html5shiv, it's widely tested, successful usage and support of edge cases I would rather urge for using it or orienting strongly on it. It also comes with support for custom elements.
Might there not be negative caching implications by inlining, especially on IE8? Also it needs to come after all stylesheets, to properly apply the styles in IE.

Volker_E renamed this task from Provide a way to support HTML5 in browsers that don't support it and don't have JS shipped, like IE8 and below to Provide a way to support HTML5 elements in browsers that don't support it and don't have JS shipped, like IE8 and below.Jan 6 2016, 10:31 PM

Volker_E set Security to None.

Volker_E added a subscriber: • GWicke.

• GWicke added a parent task: T100106: Replace Kaltura player with Video.js.Jan 6 2016, 10:44 PM

There is a patch in gerrit that is disabling ie8 for javascript. It was announced a month or two ago that ie8 js supported will be disabled in mw core in January.

Volker_E added a parent task: T21719: [DO NOT USE] HTML5 features (tracking) [superseded by #HTML5].Jan 6 2016, 10:51 PM

Volker_E added a parent task: T12467: Use semantic HTML (tracking).Jan 6 2016, 10:53 PM

@Paladox we are aware, but that means disabling support for anything ResourceLoader based and all ''features' provided by JS. It does not mean we cannot still make an IE8 specific 'hack' for this specifically. That is not without precedent.

In T122965#1919103, @TheDJ wrote:

@Paladox we are aware, but that means disabling support for anything ResourceLoader based and all ''features' provided by JS. It does not mean we cannot still make an IE8 specific 'hack' for this specifically. That is not without precedent.

Ok. I was referring to the suggestion to use a html5shiv library.

Ricordisamoa subscribed.Jan 7 2016, 1:04 AM

Jay8g subscribed.Jan 7 2016, 6:46 AM

Krinkle moved this task from Unsorted to IE8 on the Browser-Support-Internet-Explorer board.Feb 14 2016, 6:02 PM

Jdforrester-WMF edited projects, added MediaWiki-User-Interface; removed MediaWiki-General.Apr 29 2016, 3:21 PM

TheDJ mentioned this in T136203: Drop Grade C support for IE8.May 25 2016, 3:45 PM

Krinkle mentioned this in T100106: Replace Kaltura player with Video.js.May 19 2017, 4:02 PM

Krinkle removed a parent task: T100106: Replace Kaltura player with Video.js.

Krinkle added a subtask: T148586: TMH videojs mode has no fallback content for video and audio for IE 8.

• brooke mentioned this in T148586: TMH videojs mode has no fallback content for video and audio for IE 8.May 20 2017, 11:49 PM

Arlolra claimed this task.Jun 15 2017, 10:00 PM

Arlolra triaged this task as Medium priority.

Change 369991 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/core@master] resources: Support HTML5 elements in older browsers

https://gerrit.wikimedia.org/r/369991

Change 369992 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T122965: Support HTML5 elements in older browsers

https://gerrit.wikimedia.org/r/369992

Change 369991 merged by jenkins-bot:
[mediawiki/core@master] OutputPage: Support HTML5 elements in older browsers using html5shiv

https://gerrit.wikimedia.org/r/369991

Krinkle moved this task from Backlog to Done on the MediaWiki-User-Interface board.Aug 9 2017, 9:19 PM

TheDJ awarded a token.Aug 9 2017, 9:39 PM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)).Aug 9 2017, 10:00 PM

Arlolra closed this task as Resolved.Aug 9 2017, 10:34 PM

@Arlorla Is Change 369992 not necessary to fully resolve?

In T122965#3517882, @Volker_E wrote:

@Arlorla Is Change 369992 not necessary to fully resolve?

Not really; I'm not sure any clients currently make use of Parsoid's <head> information. VE certainly doesn't. Also, that patch makes some assumptions about the result of OutputPage::transformResourcePath() that aren't very satisfying. I'm considering abandoning it.