Page MenuHomePhabricator

Incorrect link in HTML email notification for URLs without protocol (starting with "//") (due to missing base URI?)
Open, LowestPublic

Description

The email message I received for T93049#1892551 has a link but it's broken and leads to https://phabricator.wikimedia.org//hu.wikisource.org/w/index.php?title=Wikiforrás:Kocsmafal&diff=85819&oldid=85803. This is probably due to the protocol relative url in the message. [[//hu.wikisource.org/w/index.php?title=Wikiforrás:Kocsmafal&diff=85819&oldid=85803|hu.wikisource]].
Note that it works fine on the web so whatever parses the link for the email message needs to be fixed.

Event Timeline

Glaisher raised the priority of this task from to Needs Triage.
Glaisher updated the task description. (Show Details)
Glaisher added a project: Phabricator.
Glaisher subscribed.
Aklapper renamed this task from Broken link in email notification to Incorrect link in HTML email notification for URLs without protocol (starting with "//").Dec 19 2015, 6:17 PM
Aklapper triaged this task as Lowest priority.
Aklapper edited projects, added Phabricator (Upstream); removed Phabricator.
Aklapper set Security to None.

No link for me in plain text email notifications...
A HTML email source (without private info) would be welcome plus info about the email client used.

<div>Tacsipacsi added a subscriber: Tacsipacsi.<br />
Tacsipacsi added a comment.</div><br /><p>It&#039;s also a problem on <a href="https://phabricator.wikimedia.org//hu.wikisource.org/w/index.php?title=Wikiforrás:Kocsmafal&amp;diff=85819&amp;oldid=85803" class="remarkup-link" target="_blank" rel="noreferrer">hu.wikisource</a>. This wasn&#039;t the first duplication, about the half of messages arrived twice since the creation of the village pump in July.</p><br /><div><strong>TASK DETAIL</strong><div><a href="https://phabricator.wikimedia.org/T93049" rel="noreferrer">https://phabricator.wikimedia.org/T93049</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.wikimedia.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.wikimedia.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong><CC users>

Using Thunderdbird on Ubuntu.

Is there any base URI defined in the message? RFC 3986 came to my mind...

Ah well, I will just retry by pasting your comment here again after setting "Send HTML Email" on https://phabricator.wikimedia.org/settings/user/USERNAME/page/emailformat/ :

It's also a problem on hu.wikisource. This wasn't the first duplication, about the half of messages arrived twice since the creation of the village pump in July.

Confirming. And no Base URI defined (after decoding the base64 content).

Aklapper renamed this task from Incorrect link in HTML email notification for URLs without protocol (starting with "//") to Incorrect link in HTML email notification for URLs without protocol (starting with "//") (due to missing base URI?).Aug 7 2018, 8:31 AM