https://tools.wmflabs.org/paws/user/John_Vandenberg/tree#clusters is useless , showing only:
"Clusters tab is now provided by IPython parallel. See IPython parallel for installation details."
https://tools.wmflabs.org/paws/user/John_Vandenberg/tree#clusters is useless , showing only:
"Clusters tab is now provided by IPython parallel. See IPython parallel for installation details."
This is an easy task because can hide it as Framawiki suggested. But I would like to know how we can contribute to this kind of tasks. Is it explained in some page in Mediawiki or Wikitech? If someone explain me that, as you @Chicocvenancio, I could claim this task.
@Framawiki sorry, I didn't respond!
@Ivanhercaz The live code for PAWS is in https://github.com/yuvipanda/paws PAWS-beta lives in https://github.com/chicocvenancio/paws/tree/dev PRs against either are very welcome.
I do understand it is not straightforward to understand what the code there does. We should create a general contributing guide. For this task, I'll limit myself to explaining that singleuser image is what runs the jupyter notebook server for each user.
Jupyter notebooks can be styled by either their default path .jupyter/custom/custom.css files for each user or by adding a NotebookApp.extra_static_paths config pointing to another directory to have the custom.css file. We need to have a way to serve the css for all notebook apps.
If I see anything in which I can contribute, I will do it.
I do understand it is not straightforward to understand what the code there does. We should create a general contributing guide. For this task, I'll limit myself to explaining that singleuser image is what runs the jupyter notebook server for each user.
Totally agree, having a general contributing guide would easier this kind of tasks and solve possible easy to solve doubts.
Jupyter notebooks can be styled by either their default path .jupyter/custom/custom.css files for each user or by adding a NotebookApp.extra_static_paths config pointing to another directory to have the custom.css file. We need to have a way to serve the css for all notebook apps.
Interesting. So I understand that this PR haven't been merged yet because now you are trying to serve the CSS for all and this PR doesn't make it.
In that case, the problem isn't to remove the clusters tab, but how to apply this change correctly.
Interesting. So I understand that this PR haven't been merged yet because now you are trying to serve the CSS for all and this PR doesn't make it.
In that case, the problem isn't to remove the clusters tab, but how to apply this change correctly.
Ha! Didn't remember I made that. Well, I made that to test CSS changes and how to include content to the users, this was before a big release for jupyterhub and I was content with the templates and announcement options we got once that was out.
I have no strong opinion against that approach as a definite solution, it will work. My only worry is that it will also overwrite any css changes someone makes to their own environment (but it probably is an unused feature, I could check).
Another observation is that Framawiki's css above is more specific than mine on the PR and doesn't need the !important.
Ha! Didn't remember I made that.
😆 😆 😆
I have no strong opinion against that approach as a definite solution, it will work. My only worry is that it will also overwrite any css changes someone makes to their own environment (but it probably is an unused feature, I could check).
At least at this moment it seems to be an unused feature. But, it might be possible to have a way in which there is a general stylesheet and then a specific stylesheet for each user, in which the user can replace what would be necessary.
Another observation is that Framawiki's css above is more specific than mine on the PR and doesn't need the !important.
Thus I propose this PR with the code suggested by @Framawiki, so if it could replace your PR. Would be necessary to make any other change or take another consideration about it to merge it and run this change in PAWS?