Page MenuHomePhabricator
Create Task
Maniphest T118052

API requests fail to load captcha information for some requests
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When an anonymous or non-autoconfirmed user tries to insert an external link with VE, the "Save" dialogue displays a CAPTCHA code. However, even if the CAPTCHA is inserted correctly, dialogue shows another CAPTCHA code and so on, so the user cannot save his work. It happens with Chrome 46 and Firefox 42.

Details

SubjectRepoBranchLines /-
Copy context request changes to wgRequest globalmediawiki/extensions/ConfirmEditwmf/1.27.0-wmf.5 5 -1
Copy context request changes to wgRequest globalmediawiki/extensions/ConfirmEditmaster 5 -1
Customize query in gerrit

Related Objects

Event Timeline

Mannivu created this task.Nov 6 2015, 11:41 PM
Mannivu raised the priority of this task from to Needs Triage.
Mannivu updated the task description. (Show Details)
Mannivu added a project: VisualEditor.
Mannivu subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 6 2015, 11:41 PM
Catrope triaged this task as Unbreak Now! priority.Nov 6 2015, 11:43 PM
Catrope subscribed.

Confirmed on enwiki with Chrome in incognito mode

Krenair added a project: VisualEditor-MediaWiki.Nov 6 2015, 11:45 PM
Krenair subscribed.

Usually helpful to at least CC me on these things if you're not going to add VisualEditor-MediaWiki. I only noticed this because of the feed on IRC

Krenair renamed this task from Dialogue asks CAPTCHA even if inserted correctly to API requests fail to load captcha information for some requests (anonymous users?).Nov 7 2015, 12:21 AM
Krenair edited projects, added ConfirmEdit (CAPTCHA extension); removed VisualEditor-MediaWiki, VisualEditor.
Krenair set Security to None.
Restricted Application added a subscriber: Florian. · View Herald TranscriptNov 7 2015, 12:21 AM
Krenair claimed this task.Nov 7 2015, 12:21 AM
Catrope added a comment.Nov 7 2015, 12:25 AM
In T118052#1790312, @Krenair wrote:

Usually helpful to at least CC me on these things if you're not going to add VisualEditor-MediaWiki. I only noticed this because of the feed on IRC

Sorry. I was going to investigate this myself, but I got a phone call and had to run.

gerritbot subscribed.Nov 7 2015, 12:27 AM

Change 251672 had a related patch set uploaded (by Alex Monk):
Copy context request changes to wgRequest global

https://gerrit.wikimedia.org/r/251672

gerritbot added a project: Patch-For-Review.Nov 7 2015, 12:27 AM
gerritbot added a comment.Nov 7 2015, 12:47 AM

Change 251672 merged by jenkins-bot:
Copy context request changes to wgRequest global

https://gerrit.wikimedia.org/r/251672

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)).Nov 7 2015, 1:00 AM
gerritbot added a comment.Nov 7 2015, 1:01 AM

Change 251673 had a related patch set uploaded (by Jforrester):
Copy context request changes to wgRequest global

https://gerrit.wikimedia.org/r/251673

Jdforrester-WMF closed this task as Resolved.Nov 7 2015, 1:01 AM
Jdforrester-WMF edited projects, added Contributors-Team; removed Patch-For-Review.
Jdforrester-WMF subscribed.

Will back-port for Monday.

Krenair mentioned this in T118127: Captcha doesn't allow to save edit without error.Nov 8 2015, 7:38 PM
Krenair merged a task: T118135: Captchas for external links not working in visual editor.Nov 8 2015, 8:31 PM
Krenair added a subscriber: • Quiddity.
• Quiddity renamed this task from API requests fail to load captcha information for some requests (anonymous users?) to API requests fail to load captcha information for some requests.Nov 8 2015, 8:35 PM
• Quiddity updated the task description. (Show Details)
Krenair merged a task: T118127: Captcha doesn't allow to save edit without error.Nov 8 2015, 8:39 PM
Krenair added a subscriber: Chimit.
gerritbot added a comment.Nov 8 2015, 8:40 PM

Change 251673 merged by jenkins-bot:
Copy context request changes to wgRequest global

https://gerrit.wikimedia.org/r/251673

Krenair added a comment.Nov 8 2015, 8:47 PM

@Quiddity pointed out some other reports of it affecting logged in users, so I deployed the fix early. Apparently it works now.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Nov 8 2015, 9:00 PM
Florian added a comment.Nov 9 2015, 6:36 AM

Thanks @Krenair for the fast deployment and fix for this problem :)

Jdforrester-WMF added projects: MediaWiki-Page-editing, VisualEditor, VisualEditor-MediaWiki.Nov 9 2015, 3:50 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Nov 9 2015, 4:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits