Page MenuHomePhabricator
Create Task
Maniphest T117737

Convert Special:Log to OOUI
Closed, ResolvedPublic
Actions

Assigned To
• Prtksxna
Authored By
Florian
Nov 4 2015, 5:21 PM
Tags
Referenced Files
F27176372: image.png
Nov 11 2018, 1:16 AM
F23767067: obrazek.png
Jul 15 2018, 12:37 PM
F17239564: image.png
Apr 22 2018, 2:17 AM
Subscribers
Aklapper
Amorymeltzer
BethNaught
Daimona
Florian
Jdforrester-WMF
Jdlrobson
View All 13 Subscribers
Tokens
"Doubloon" token, awarded by RandomDSdevel."100" token, awarded by Jayprakash12345."Meh!" token, awarded by Volker_E."Meh!" token, awarded by Prtksxna.

Description

This is probably one of the most difficult one ;)

BeforeAfter
image.png (980×1 px, 309 KB)
image.png (1×2 px, 179 KB)

Details

SubjectRepoBranchLines /-
Special:Log: Convert to HTMLFormmediawiki/coremaster 148 -132
Special:Log: Use OOUImediawiki/coremaster 1 -1
LogEventsListGetExtraInputs: Keep $input and add $formDescriptormediawiki/coremaster 29 -6
Provide correct param to Special:Logmediawiki/coremaster 1 -1
Rephrase 'logeventslist-more-filters'mediawiki/corewmf/1.32.0-wmf.13 2 -2
Rephrase 'logeventslist-more-filters'mediawiki/coremaster 2 -2
Update LogEventsListGetExtraInputs hookmediawiki/extensions/CentralAuthmaster 11 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Florian created this task.Nov 4 2015, 5:21 PM
Florian raised the priority of this task from to Medium.
Florian updated the task description. (Show Details)
Florian added a project: UI-Standardization.
Florian added subscribers: Ricordisamoa, Legoktm, Jdforrester-WMF and 4 others.
Volker_E moved this task from Unsorted to Conversion to OOUI on the UI-Standardization board.Jan 18 2016, 11:25 PM
Aastha03 subscribed.Mar 12 2016, 9:10 AM
Aastha03 unsubscribed.Mar 12 2016, 10:31 AM
Volker_E merged a task: T73442: Fix Special:Log.Jul 20 2016, 11:19 PM
Volker_E added subscribers: • Prtksxna, Liuxinyu970226, • violetto and 2 others.
BethNaught subscribed.Dec 11 2016, 3:03 PM
Liuxinyu970226 added a project: MediaWiki-Logevents.Oct 4 2017, 3:21 AM
Volker_E updated the task description. (Show Details)Apr 22 2018, 2:17 AM
• Prtksxna awarded a token.Apr 23 2018, 6:00 AM
gerritbot subscribed.Apr 25 2018, 5:24 AM

Change 428871 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] [wip] Special:Log: Convert to HTMLForm

https://gerrit.wikimedia.org/r/428871

gerritbot added a project: Patch-For-Review.Apr 25 2018, 5:24 AM
gerritbot added a comment.Jun 25 2018, 2:53 AM

Change 441759 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/CentralAuth@master] Update LogEventsListGetExtraInputs hook

https://gerrit.wikimedia.org/r/441759

Volker_E updated the task description. (Show Details)Jun 28 2018, 8:22 AM
Volker_E edited subscribers, added: Mattflaschen-Personal; removed: • Mattflaschen-WMF, • violetto.
gerritbot added a comment.Jul 12 2018, 11:10 AM

Change 428871 merged by jenkins-bot:
[mediawiki/core@master] Special:Log: Convert to HTMLForm

https://gerrit.wikimedia.org/r/428871

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 12 2018, 12:00 PM
• Prtksxna mentioned this in T199495: Allow $input in LogEventsListGetExtraInputs hook, deprecate it.Jul 13 2018, 2:33 AM
gerritbot added a comment.Jul 13 2018, 2:37 AM

Change 445559 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] LogEventsListGetExtraInputs: Keep $input and add $formDescriptor

https://gerrit.wikimedia.org/r/445559

matej_suchanek added subscribers: Daimona, matej_suchanek.Jul 15 2018, 12:37 PM

Some issues (from beta.wmflabs.org):

obrazek.png (286×1 px, 10 KB)

  1. It isn't really clear what "More filters:" should do.
  2. Extensions need to update their messages (T199645).
  3. Messages log-show-hide-patrol and log-show-hide-tag should probably be removed (and doc for wgFilterLogTypes updated).
Daimona added a comment.Jul 15 2018, 12:49 PM

Indeed. I can do the updates myself, but first I need to understand whether old messages are still meant to be used somewhere, or can be removed.

• Prtksxna mentioned this in T199657: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log.Jul 16 2018, 4:24 AM
In T117737#4425857, @matej_suchanek wrote:
  1. It isn't really clear what "More filters:" should do.

Would a better label help? Any suggestions?

  1. Extensions need to update their messages (T199645).
  2. Messages log-show-hide-patrol and log-show-hide-tag should probably be removed (and doc for wgFilterLogTypes updated).

Thanks for pointing this out, I have logged - T199657: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log

matej_suchanek added a comment.Jul 16 2018, 8:26 AM
In T117737#4426286, @Prtksxna wrote:
In T117737#4425857, @matej_suchanek wrote:
  1. It isn't really clear what "More filters:" should do.

Would a better label help? Any suggestions?

"Show log types" would be better.

matej_suchanek updated the task description. (Show Details)Jul 16 2018, 8:26 AM
• Prtksxna updated the task description. (Show Details)Jul 17 2018, 2:17 AM
• Prtksxna updated the task description. (Show Details)Jul 17 2018, 5:03 AM
Volker_E awarded a token.Jul 17 2018, 12:07 PM
Volker_E updated the task description. (Show Details)Jul 17 2018, 1:40 PM
gerritbot added a comment.Jul 17 2018, 6:52 PM

Change 445559 merged by jenkins-bot:
[mediawiki/core@master] LogEventsListGetExtraInputs: Keep $input and add $formDescriptor

https://gerrit.wikimedia.org/r/445559

gerritbot added a comment.Jul 17 2018, 6:52 PM

Change 441759 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Update LogEventsListGetExtraInputs hook

https://gerrit.wikimedia.org/r/441759

gerritbot added a comment.Jul 17 2018, 8:32 PM

Change 446480 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Rephrase 'logeventslist-more-filters'

https://gerrit.wikimedia.org/r/446480

gerritbot added a comment.Jul 17 2018, 9:38 PM

Change 446480 merged by jenkins-bot:
[mediawiki/core@master] Rephrase 'logeventslist-more-filters'

https://gerrit.wikimedia.org/r/446480

gerritbot added a comment.Jul 17 2018, 11:05 PM

Change 446506 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.32.0-wmf.13] Rephrase 'logeventslist-more-filters'

https://gerrit.wikimedia.org/r/446506

gerritbot added a comment.Jul 17 2018, 11:25 PM

Change 446506 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.13] Rephrase 'logeventslist-more-filters'

https://gerrit.wikimedia.org/r/446506

• Prtksxna updated the task description. (Show Details)Jul 18 2018, 1:55 AM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)); removed MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 18 2018, 5:01 AM
• Prtksxna updated the task description. (Show Details)Jul 18 2018, 5:07 AM
gerritbot added a comment.Jul 18 2018, 2:00 PM

Change 446587 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/core@master] Provide corrent param to Special:Log

https://gerrit.wikimedia.org/r/446587

gerritbot added a comment.Jul 18 2018, 5:16 PM

Change 446587 merged by jenkins-bot:
[mediawiki/core@master] Provide correct param to Special:Log

https://gerrit.wikimedia.org/r/446587

• Prtksxna updated the task description. (Show Details)Jul 23 2018, 2:41 AM
• Prtksxna updated the task description. (Show Details)Jul 23 2018, 4:43 AM
Volker_E updated the task description. (Show Details)Jul 23 2018, 12:32 PM
• Prtksxna updated the task description. (Show Details)Jul 24 2018, 1:42 AM
Jayprakash12345 awarded a token.Jul 26 2018, 5:14 PM
Volker_E updated the task description. (Show Details)Jul 26 2018, 6:38 PM
Volker_E added a subtask: T200446: Prefill username in form when calling Special:Log/<username>.Jul 26 2018, 6:40 PM
Jayprakash12345 closed subtask T200446: Prefill username in form when calling Special:Log/<username> as Resolved.Jul 26 2018, 8:06 PM
Jayprakash12345 updated the task description. (Show Details)
matej_suchanek added a project: User-notice.Jul 27 2018, 8:44 AM
matej_suchanek moved this task from To Triage to Announce in next Tech/News on the User-notice board.
matej_suchanek moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Jul 27 2018, 8:48 AM
• Prtksxna closed subtask T199657: Convert log-show-hide-{$type} messages to logeventslist-{$type}-log as Resolved.Jul 30 2018, 1:40 AM
• Prtksxna closed subtask T200174: Special:Log Warnings when changing log type as Invalid.Jul 30 2018, 7:24 AM
• Prtksxna closed subtask T199856: Special:Log form should be using GET not POST as Resolved.Jul 30 2018, 10:19 AM
• Prtksxna updated the task description. (Show Details)
• Prtksxna reopened subtask T199856: Special:Log form should be using GET not POST as Open.Jul 31 2018, 1:42 AM
• Prtksxna updated the task description. (Show Details)
matmarex closed subtask T199856: Special:Log form should be using GET not POST as Resolved.Jul 31 2018, 4:04 PM
• Prtksxna updated the task description. (Show Details)Aug 1 2018, 1:49 AM
• Petar.petkovic removed a project: Patch-For-Review.Aug 1 2018, 7:35 PM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Aug 2 2018, 2:20 PM
Amorymeltzer subscribed.Aug 6 2018, 8:17 PM
RandomDSdevel awarded a token.Oct 1 2018, 1:23 AM
gerritbot added a comment.Nov 11 2018, 1:11 AM

Change 472862 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Special:Log: Use OOUI

https://gerrit.wikimedia.org/r/472862

gerritbot added a project: Patch-For-Review.Nov 11 2018, 1:11 AM
Volker_E updated the task description. (Show Details)Nov 11 2018, 1:16 AM
gerritbot added a comment.Nov 14 2018, 1:13 PM

Change 472862 merged by jenkins-bot:
[mediawiki/core@master] Special:Log: Use OOUI

https://gerrit.wikimedia.org/r/472862

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 14 2018, 2:00 PM
Bawolff mentioned this in T209490: Date field will be prefilled with invalid date on Special:Log if 0000 is submitted.Nov 14 2018, 2:25 PM
Volker_E closed this task as Resolved.Nov 15 2018, 6:17 AM
Volker_E assigned this task to • Prtksxna.
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Volker_E removed a subscriber: gerritbot.
Liuxinyu970226 unsubscribed.Nov 21 2018, 2:13 PM
matej_suchanek unsubscribed.Nov 24 2018, 1:21 PM
Volker_E mentioned this in T117736: Convert Special:Contributions to OOUI.Jan 17 2019, 7:32 AM
Amorymeltzer mentioned this in T220555: Evaluate collapsible form on HistoryAction (collapsed by default?).Apr 10 2019, 10:29 AM
matej_suchanek mentioned this in T267722: "User creation log" auxiliary filter doesn't work under certain circumstances.Nov 11 2020, 10:58 AM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits