| alex-mashin | |
| Oct 10 2015, 11:00 PM |
| F2745001: ehren-paper_lights-96.mp4 | |
| Oct 20 2015, 6:12 PM |
When Mp4Handler is used to handle MP3 files, there is a warning: Notice: Undefined index: video in (MediaWiki path)/extensions/TimedMediaHandler/handlers/Mp4Handler/Mp4Handler.php on line 95.
isset ($metadata['video']) && should be added to the condition in that line.
| Subject | Repo | Branch | Lines /- | |
|---|---|---|---|---|
| Do not throw errors on audio-only MP4 files | mediawiki/extensions/TimedMediaHandler | master | 1 -1 |
I'm assuming that using Mp4Handler for mp3 files is a hack of some kind that should not be done. :D Does this also happen on audio-only .m4a/.mp4 files?
Change 247548 had a related patch set uploaded (by TheDJ):
Do not throw errors on audio-only MP4 files
So, if I try to upload an .mp4 file with only an AAC audio track:
, I get a failure during the upload process:File extension ".mp4" does not match the detected MIME type of the file (audio/mp4).
(This is with $wgTmhEnableMp4Uploads enabled.)
Presumably needs more work elsewhere to support audio-only files.
Meanwhile, MP3 support should be done with a dedicated handler, just as with other file types.