Maniphest T112019

Board description: VE icons are misplaced
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Sep 9 2015, 10:41 PM

Description

In betalabs click on Edit description without logging in.
Click on any of misplaced icons - three javascript errors appear:

Screen Shot 2015-09-09 at 3.17.07 PM.png (593×392 px, 75 KB)

Screen Shot 2015-09-09 at 3.24.46 PM.png (329×420 px, 56 KB)

More screenshots(to check after the fix):

Screen Shot 2015-09-09 at 3.51.28 PM.png (354×392 px, 30 KB)

Screen Shot 2015-09-09 at 3.51.09 PM.png (339×388 px, 29 KB)

[FLOW] Failed to getInstanceByElement: no $container.length [jQuery.fn.init[1]]mw.loader.implement.mw.flow.debug.FlowComponent.debug @ wAction.open @ load.php?

Uncaught TypeError: flowBoard.getTopicPosters is not a functionmw.loader.implement.mw.flow.ve.ui.MentionInspector.initialize @ VM1555:470OO.ui.Window.setManager @ load.php?debug=false&lang=en&modules=oojs-ui|oojs-ui.styles.icons,icons-editing-

Uncaught TypeError: Cannot read property 'connect' of null

And generally

Uncaught TypeError: Cannot read property 'focus' of undefined ve.ce.Surface.focus @ load.php?
debug=false&lang=en&modules=ext.flow.visualEditor|ext.visualEditor.core,mediawiki,mwco…:353mw.flow.ui.
VisualEditorWidget.focus @ load.php?
debug=false&lang=en&modules=ext.flow|ext.flow.templating,ui|ext.thanks.flowthank|oojs-
ui…:170mw.flow.ui.EditorSwitcherWidget.focus
.....

Details

	Subject	Repo	Branch	Lines /-
	Follow-up 87faf4b3241: don't break toolbar when setContent() is called	mediawiki/extensions/Flow	wmf/1.26wmf22	1 -0
	Follow-up 87faf4b3241: don't break toolbar when setContent() is called	mediawiki/extensions/Flow	master	1 -0

Customize query in gerrit

Related Objects

Mentioned In: rMEXTf1bf18df060e: Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
rEFLW7cbd192cd547: Follow-up 87faf4b3241: don't break toolbar when setContent() is called
Mentioned Here: rEFLW87faf4b3241c: VisualEditorWidget: Ensure toolbar is initialized after editor is attached

Event Timeline

Etonkovidova created this task.Sep 9 2015, 10:41 PM

Etonkovidova raised the priority of this task from to Needs Triage.

Etonkovidova updated the task description. (Show Details)

Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Triage.

Etonkovidova subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2015, 10:41 PM

Etonkovidova renamed this task from Board description: VE icons are misplaced for non-logged users to Board description: VE icons are misplaced .Sep 9 2015, 10:53 PM

Etonkovidova updated the task description. (Show Details)

Etonkovidova set Security to None.

Change 237291 had a related patch set uploaded (by Catrope):
Follow-up 87faf4b3241: don't break toolbar when setContent() is called

https://gerrit.wikimedia.org/r/237291

gerritbot added a project: Patch-For-Review.Sep 9 2015, 11:02 PM

Change 237291 merged by jenkins-bot:
Follow-up 87faf4b3241: don't break toolbar when setContent() is called

https://gerrit.wikimedia.org/r/237291

Catrope mentioned this in rEFLW7cbd192cd547: Follow-up 87faf4b3241: don't break toolbar when setContent() is called.Sep 9 2015, 11:07 PM

Catrope mentioned this in rMEXTf1bf18df060e: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….

Change 237292 had a related patch set uploaded (by Catrope):
Follow-up 87faf4b3241: don't break toolbar when setContent() is called

https://gerrit.wikimedia.org/r/237292

Change 237292 abandoned by Catrope:
Follow-up 87faf4b3241: don't break toolbar when setContent() is called

Reason:
Never mind, the commit this fixes isn't in wmf22

https://gerrit.wikimedia.org/r/237292

Etonkovidova edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Sep 10 2015, 6:42 PM

ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 10 2015, 10:02 PM

Mooeypoo assigned this task to Catrope.Sep 10 2015, 10:45 PM

Mooeypoo moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.

Checked in betalabs.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 11 2015, 5:00 PM

• DannyH closed this task as Resolved.Sep 14 2015, 5:19 PM

• DannyH subscribed.

• DannyH added a project: OKR-Work.Sep 14 2015, 10:46 PM

	F2563008: Screen Shot 2015-09-09 at 3.51.28 PM.png
	Sep 9 2015, 10:53 PM

	F2563010: Screen Shot 2015-09-09 at 3.51.09 PM.png
	Sep 9 2015, 10:53 PM

	F2562966: Screen Shot 2015-09-09 at 3.17.07 PM.png
	Sep 9 2015, 10:41 PM

	F2562968: Screen Shot 2015-09-09 at 3.24.46 PM.png
	Sep 9 2015, 10:41 PM

Board description: VE icons are misplaced Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Board description: VE icons are misplaced
Closed, ResolvedPublic
Actions