Page MenuHomePhabricator

Missing tab styles in "DB clusters" page (on noc.wikimedia.org)
Closed, ResolvedPublic

Description

After T107399: Make top queue fully asynchronous, the tabs in https://noc.wikimedia.org/db.php appear as a plain, unstyled list of links.

The page first loads https://bits.wikimedia.org/www.mediawiki.org/load.php?modules=startup&only=scripts, then at the end of the body, calls mw.loader.using() to load the "jquery.ui.tabs" module (see https://phabricator.wikimedia.org/diffusion/OMWC/browse/master/docroot/noc/db.php). This fails because the "mediawiki" module has not yet finished loading.

An obvious workaround would be to add the window.RLQ boilerplate (and stop using bits.wikimedia.org), though as noted in T96499, only MediaWiki should be using ResourceLoader. Also, is it really necessary to use JS code for the tabs?

Event Timeline

PleaseStand raised the priority of this task from to Needs Triage.
PleaseStand updated the task description. (Show Details)
PleaseStand added subscribers: PleaseStand, Krinkle.
Krenair set Security to None.
Krenair subscribed.

noc code is under the control of deployers, in mediawiki-config.git, therefore moving this to Wikimedia-Site-requests instead of SRE

Change 232920 had a related patch set uploaded (by Alex Monk):
Fix noc.wikimedia.org/db.php

https://gerrit.wikimedia.org/r/232920

Change 232920 merged by Alex Monk:
Fix noc.wikimedia.org/db.php

https://gerrit.wikimedia.org/r/232920